[$250] Hold expense - RBR is not shown instantly when holding expense from main chat

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com
2. Open DM with user that has no unsettled expense.
3. Submit an expense.
4. In the mian chat, right click on the expense preview.
5. Select Hold.
6. Enter a reason and save it.
7. Note that the expense preview in the main chat does not show RBR.
8. Go to the transaction thread and return to main chat.
9. Note that the expense preview in the main chat now shows RBR.
10. Submit another expense.
11. Go to expense report.
12. Right click on the expense preview > Hold.
13. Enter reason and save it.
14. Note that the expense preview in the expense report displays RBR and hold label without the need to visit the transaction thread.

Expected Result:

In Step 7, the expense preview in the main chat will show RBR after holding the expense from the main chat.

Actual Result:

In Step 7, the expense preview in the main chat does not show RBR after holding the expense from the main chat.
It only shows RBR after visiting the report and back to main chat in Step 9.

When holding the expense from expense report (at least two expenses), the RBR and Hold label are shown without visiting the transaction thread (Step 14).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6569930_1723470967140.20240812_215033.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0162d2bf8d74991b81
• Upwork Job ID: 1823077860579616696
• Last Price Increase: 2024-08-12
• Automatic offers:
• Nodebrute | Contributor | 103588043

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Triggered auto assignment to @johnmlee101 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

[dylanexpensify]

@johnmlee101 can repro, but don't think this is necessarily a deploy blocker? LMK what you think!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0162d2bf8d74991b81

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[johnmlee101]

Yeah doesn't seem like a blocker necessarily

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-08-12 21:51:43 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

RBR is not shown instantly when holding expense from main chat

What is the root cause of that problem?

In the expense preview, we check for transaction violations to see if any are present. However, when we put an expense on hold through the preview, we don’t set the transaction violation optimistically. As a result, the transaction violation will be empty unless we access the child report. This is why we can’t see the RBR without visiting the report.

App/src/components/ReportActionItem/ReportPreview.tsx

Line 168 in fa30a89

ReportUtils.hasViolations(iouReportID, transactionViolations) ||

but in MoneyRequestPreviewContent we also have another check isOnHold that's why we can see the RBR without visiting the child report.

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 136 in fa30a89

const shouldShowRBR = hasNoticeTypeViolations || hasViolations || hasFieldErrors || (!isFullySettled && !isFullyApproved && isOnHold) || hasDuplicates;

What changes do you think we should make in order to solve the problem?

We can optimistically add the violation data when placing the expense on hold. We can do something like this here

const newViolation = { name: 'hold', type: CONST.VIOLATION_TYPES.VIOLATION };
const transactionViolations = allTransactionViolations[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`] ?? [];
const updatedViolations = [...transactionViolations, newViolation];
  {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`,
            value:updatedViolations,
        },

What alternative solutions did you explore? (Optional)

Use same logic by adding isOnHold that we are using in

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 136 in fa30a89

const shouldShowRBR = hasNoticeTypeViolations || hasViolations || hasFieldErrors || (!isFullySettled && !isFullyApproved && isOnHold) || hasDuplicates;

[melvin-bot]

@mananjadhav, @johnmlee101, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mananjadhav]

@Nodebrute's proposal would work.

🎀 👀 🎀

[melvin-bot]

Current assignee @johnmlee101 is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[johnmlee101]

@Nodebrute just making sure you've seen this!

[Nodebrute]

@johnmlee101 I'll raise the pull request in a few hours.

[Nodebrute]

This was deployed to production in v9.0.26-6.
Payment is due 2024-09-06.

[mananjadhav]

@dylanexpensify this is ready for payout. I couldn't pinpoint the exact PR where we should've added the RBR changes. I also don't think we need a regression test for this one.

[dylanexpensify]

Payment summary:

Contributor: @Nodebrute $250 via Upwork
Contributor+: @mananjadhav $250 via NewDot

Please apply/request!

[garrettmknight]

$250 approved for @mananjadhav