[$250] Profile - After the user's address is saved, Address Line 2 is added to Address Line 1

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4738169
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Open App or go to staging.new.expensify.com
2. Login with any account
3. Go to Settings > Profile > Private > Address
4. Add any address in Address Line 1, Line 2 and in other fields
5. Save address
6. Open saved address

Expected Result:

All address fields are saved correctly

Actual Result:

Contents of Address Line 2 was added to the end of Address Line 1. Field "Address Line 2" is empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6546667_1721338922580.iOS-Address-2-added-to-Address-1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015086577f7d57dabf
• Upwork Job ID: 1817941170058231435
• Last Price Increase: 2024-07-29
• Automatic offers:
• nyomanjyotisa | Contributor | 103594215

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile - After the user's address is saved, Address Line 2 is added to Address Line 1

What is the root cause of that problem?

We are saving both street and street2 in street separating with new line

App/src/libs/PersonalDetailsUtils.ts

Lines 214 to 215 in b8b99d0

	return `${street1}\n${street2}`;
	}

But we are not extracting street2 properly here

App/src/pages/AddressPage.tsx

Lines 31 to 32 in b8b99d0

	const {street, street2} = address ?? {};
	const [currentCountry, setCurrentCountry] = useState(address?.country);

What changes do you think we should make in order to solve the problem?

We can start saving them separately by creating street2 prop privatePersonalDetails?.address and then we can displaying them easily by accessing the props
or we can also extract the street2 by assigning the string after newline to street2 like

const {street: bothStreets} = address ?? {};
    const streetArr = bothStreets?.split('\n');
    const street = streetArr?.[0];
    const street2 = streetArr?.[1];

What alternative solutions did you explore? (Optional)

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After the user's address is saved, Address Line 2 is added to Address Line 1

What is the root cause of that problem?

Street value from API response are combined for Street 1 and Street 2, separated by \n

And we don't handle it here

What changes do you think we should make in order to solve the problem?

Handle the street value with \n from API response to separate it to Street 1 and Street 2

    const { street } = address ?? {};
    const [street1, street2] = street ? street.split('\n') : [undefined, undefined];

And change this to

street1={street1}

RESULT

What alternative solutions did you explore? (Optional)

[FitseTLT]

Updated to fix a typo /n to \n

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Profile - After the user's address is saved, Address Line 2 is added to Address Line 1

What is the root cause of that problem?

We already have addressLine1 and addressLine2 property in Address but we aren't using that.

App/src/libs/actions/PersonalDetails.ts

Lines 173 to 179 in b8b99d0

	address: {
	street: PersonalDetailsUtils.getFormattedStreet(street, street2),
	city,
	state,
	zip,
	country,
	},

What changes do you think we should make in order to solve the problem?

We are already sending street & street2 to backend as homeAddressStreet & addressStreet2, we can update the backend to return homeAddressStreet & addressStreet2 as addressLine1 and addressLine2 and then we can use addressLine1 and addressLine2 in AddressPage.

App/src/libs/actions/PersonalDetails.ts

Lines 152 to 159 in b8b99d0

	const parameters: UpdateHomeAddressParams = {
	homeAddressStreet: street,
	addressStreet2: street2,
	homeAddressCity: city,
	addressState: state,
	addressZipCode: zip,
	addressCountry: country,
	};

What alternative solutions did you explore? (Optional)

We should save addressLine1 and addressLine2 separately in Address object.

                    address: {
                        street: PersonalDetailsUtils.getFormattedStreet(street, street2),
                        addressLine1:street,
                        addressLine2:street2,
                        city,
                        state,
                        zip,
                        country,
                    },

And then use addressLine1 and addressLine2 in AddressPage and pass it as street1={addressLine1} and street2={addressLine2}
const {addressLine1, addressLine2} = address ?? {};

We can use street & street2 as fallback if addressLine1 and addressLine2 doesn't exist.

[Krishna2323]

Proposal Updated

• Added alternative
• Updated main solution

[melvin-bot]

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[JmillsExpensify]

Adding this to wave-collect since it's about private addresses, which is used for the bank/reimbursement flow. I'm also opening up to the community.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015086577f7d57dabf

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[thesahindia]

I am not sure if we wanna handle this in back end or front end. Gonna wait for internal engineer's opinion.

🎀 👀 🎀 C+ reviewed (using it to get the internal engineer assigned here)

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[thesahindia]

We are already sending street & street2 to backend as homeAddressStreet & addressStreet2, we can update the backend to return homeAddressStreet & addressStreet2 as addressLine1 and addressLine2 and then we can use addressLine1 and addressLine2 in AddressPage.

@marcochavezf, can we make this change in the backend? Or should we handle this issue in the front-end like mentioned in #45765 (comment)?

[melvin-bot]

@JmillsExpensify @marcochavezf @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[marcochavezf]

Not overdue, PR is WIP

[melvin-bot]

This issue has not been updated in over 15 days. @JmillsExpensify, @marcochavezf, @nyomanjyotisa, @thesahindia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

The PR for this hit prod a month ago...

[JmillsExpensify]

Payment summary:

• Contributor: $250 @nyomanjyotisa
• Reviewer: $250 @thesahindia

[garrettmknight]

$250 approved for @thesahindia

[JmillsExpensify]

All contributors paid out, so closing.