Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace Feeds] [$250] Expensify card - Unable to issue new cards to members #48199

Closed
1 of 6 tasks
IuliiaHerets opened this issue Aug 28, 2024 · 26 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.25-4
Reproducible in staging?: Y
Reproducible in production?: Can't check
Issue was found when executing this PR: #47844
Issue reported by: Applause Internal Team

Action Performed:

  1. Log in with an expensifail account
  2. Create a workspace and invite an existing Gmail member
  3. Navigate to Workspace settings - More features
  4. Enable "Expensify Card"
  5. Navigate to Workspace settings - Expensify Card
  6. Click on the "Issue new card" button
  7. Add Regions bank with Plaid
  8. Click on the "Issue new card" button again
  9. Choose the bank account and member
  10. Choose "Physical" or "Virtual" card
  11. Set any limit type
  12. Set any limit
  13. Set any name
  14. Click on the "Issue card" button

Expected Result:

The card should be added for the member

Actual Result:

Unable to issue new cards to members. I'm returned to the "Expensify Card" after issuing the card but it's not added for the member. Affects both the "Expensify Card" flow and a card added from the "Members" page after selecting one.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6584379_1724779087797.Members_page.mp4
Bug6584379_1724779087771.Add_card.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01daeec4f6ff832c54
  • Upwork Job ID: 1831039312939789039
  • Last Price Increase: 2024-09-03
  • Automatic offers:
    • DylanDylann | Reviewer | 103809990
    • allgandalf | Contributor | 103809991
Issue OwnerCurrent Issue Owner: @sobitneupane
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Aug 28, 2024
Copy link

melvin-bot bot commented Aug 28, 2024

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 28, 2024

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 28, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 28, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 2

@arosiclair
Copy link
Contributor

I found these logs for that test user which show CreateExpensifyCard failing with error 404 Business not provisioned. I think this probably doesn't need to block App deploy, but I'm not sure.

@mountiny can you take a look? cc @nkuoch since I see you authored most of CreateExpensifyCard.

@arosiclair
Copy link
Contributor

Asked if this is related to the fireroom here as well

@arosiclair arosiclair added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 labels Aug 28, 2024
@arosiclair
Copy link
Contributor

Removed the label since this looks to be behind a beta (slack convo) and assigning to @mountiny to take a look when he gets back.

@arosiclair arosiclair assigned mountiny and unassigned arosiclair Aug 28, 2024
@mountiny
Copy link
Contributor

Thanks! I have seen this error before for some testers. Not sure yet what is leading to it as they should be provisioned when they enter the new card flow

@koko57
Copy link
Contributor

koko57 commented Aug 29, 2024

@mountiny @arosiclair although nothing has changed since CreateExpensifyCard was merged let's keep in touch whether it's a BE or FE issue. I'll look into it later if it could be some problem on the FE side.

@nkuoch
Copy link
Contributor

nkuoch commented Aug 30, 2024

Maybe it just hasn't been implemented FE side yet?
From the video and the logs, I see that we never actually called ConfigureExpensifyCardsForPolicy.
It should have been called after adding the vbba successfully.
We shouldn't allow to call CreateExpensifyCard from the front end if the workspace hasn't been provisioned.

@koko57
Copy link
Contributor

koko57 commented Aug 30, 2024

@nkuoch this was implemented, but I'll check why ConfigureExpensifyCardsForPolicy is not called, thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 2, 2024
@mountiny
Copy link
Contributor

mountiny commented Sep 2, 2024

I think this might be some old policy which enabled the feature before we had this fully implemented.

@IuliiaHerets Can you confirm if you can repro this starting from scratch with a new account?

@isabelastisser isabelastisser added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 3, 2024
@melvin-bot melvin-bot bot changed the title Expensify card - Unable to issue new cards to members [$250] Expensify card - Unable to issue new cards to members Sep 3, 2024
Copy link

melvin-bot bot commented Sep 3, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01daeec4f6ff832c54

Copy link

melvin-bot bot commented Sep 3, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 4, 2024
Copy link

melvin-bot bot commented Sep 4, 2024

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Sep 4, 2024

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@mountiny
Copy link
Contributor

mountiny commented Sep 4, 2024

Alright we will need to debug this more, seems like some race condition or we skip calling some API command during the card setup

@koko57
Copy link
Contributor

koko57 commented Sep 4, 2024

@mountiny can we retest it? The request cannot be triggered only when we don't have the bankAccountID. probably it occurred for the same reason we had a problem with #45729. As now we're getting the same bankAccountList object we should have all the necessary data. I cannot reproduce ConfigureExpensifyCardsForPolicy locally.

@mountiny
Copy link
Contributor

mountiny commented Sep 4, 2024

Hmm seems like they have retested this just yesterday though

@trjExpensify trjExpensify changed the title [$250] Expensify card - Unable to issue new cards to members [Workspace Feeds] [$250] Expensify card - Unable to issue new cards to members Sep 5, 2024
@mountiny
Copy link
Contributor

mountiny commented Sep 5, 2024

For @kevinksullivan I could not find any API calls to the ConfigureExpensifyCardsForPolicy So we need to dig into why that would not be called for some reason

@mountiny
Copy link
Contributor

mountiny commented Sep 5, 2024

@allgandalf @DylanDylann will look into this one as soon as they can to try to narrow down the rootcause here

@DylanDylann
Copy link
Contributor

@mountiny I confirmed that CONFIGURE_EXPENSIFY_CARDS_FOR_POLICY isn't called

The problem: The backend doesn't return bankAccountID in bankAccountList > accountData

Screenshot 2024-09-06 at 09 58 32

@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2024

Perfect, yeah, so the problem is different formats of the bank account ID, which is a relic issue from the past. for some API commands, we return the data straight from Auth, and for some, we modify the data shape in Web, and it's causing this mess.

I also see that the methodID is actually bankAccountID 🤦 so you can use that

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 6, 2024
@mountiny mountiny added Daily KSv2 and removed Weekly KSv2 labels Sep 6, 2024
@mountiny
Copy link
Contributor

mountiny commented Sep 6, 2024

This should be fixed in staging now

@mountiny mountiny closed this as completed Sep 6, 2024
@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review
Projects
Status: Done
Development

No branches or pull requests

9 participants