-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace Feeds] [$250] Expensify card - Unable to issue new cards to members #48199
Comments
Triggered auto assignment to @arosiclair ( |
Triggered auto assignment to @isabelastisser ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #wave-collect - Release 2 |
I found these logs for that test user which show @mountiny can you take a look? cc @nkuoch since I see you authored most of |
Asked if this is related to the fireroom here as well |
Removed the label since this looks to be behind a beta (slack convo) and assigning to @mountiny to take a look when he gets back. |
Thanks! I have seen this error before for some testers. Not sure yet what is leading to it as they should be provisioned when they enter the new card flow |
@mountiny @arosiclair although nothing has changed since CreateExpensifyCard was merged let's keep in touch whether it's a BE or FE issue. I'll look into it later if it could be some problem on the FE side. |
Maybe it just hasn't been implemented FE side yet? |
@nkuoch this was implemented, but I'll check why ConfigureExpensifyCardsForPolicy is not called, thanks! |
I think this might be some old policy which enabled the feature before we had this fully implemented. @IuliiaHerets Can you confirm if you can repro this starting from scratch with a new account? |
Job added to Upwork: https://www.upwork.com/jobs/~01daeec4f6ff832c54 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Alright we will need to debug this more, seems like some race condition or we skip calling some API command during the card setup |
@mountiny can we retest it? The request cannot be triggered only when we don't have the bankAccountID. probably it occurred for the same reason we had a problem with #45729. As now we're getting the same bankAccountList object we should have all the necessary data. I cannot reproduce ConfigureExpensifyCardsForPolicy locally. |
Hmm seems like they have retested this just yesterday though |
For @kevinksullivan I could not find any API calls to the |
@allgandalf @DylanDylann will look into this one as soon as they can to try to narrow down the rootcause here |
@mountiny I confirmed that CONFIGURE_EXPENSIFY_CARDS_FOR_POLICY isn't called The problem: The backend doesn't return |
Perfect, yeah, so the problem is different formats of the bank account ID, which is a relic issue from the past. for some API commands, we return the data straight from Auth, and for some, we modify the data shape in Web, and it's causing this mess. I also see that the methodID is actually bankAccountID 🤦 so you can use that |
This should be fixed in staging now |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.25-4
Reproducible in staging?: Y
Reproducible in production?: Can't check
Issue was found when executing this PR: #47844
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The card should be added for the member
Actual Result:
Unable to issue new cards to members. I'm returned to the "Expensify Card" after issuing the card but it's not added for the member. Affects both the "Expensify Card" flow and a card added from the "Members" page after selecting one.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6584379_1724779087797.Members_page.mp4
Bug6584379_1724779087771.Add_card.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @sobitneupaneThe text was updated successfully, but these errors were encountered: