[HOLD for payment 2024-10-01] [$250] [Android] When App is opened from notification the top safe area is missing

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.25-11
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shubham1206agra
Slack conversation:

Action Performed:

Break down in numbered steps

1. [User A] Send a message to user B with chat history
2. [User B] Open the notification received.

Expected Result:

Describe what you think should've happened

There is a safe padding at the top of the app for status bar

Actual Result:

Describe what actually happened

There is no safe padding

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

You have to close and reopen the app again

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015d43274e3d80ec35
• Upwork Job ID: 1828856156434772354
• Last Price Increase: 2024-09-18

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[francoisl]

I'm having a hard time running the app in an Android virtual device at the moment, going to open externally to see if anyone can figure it out.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015d43274e3d80ec35

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[francoisl]

I'm now able to build the app locally in dev, but running into issues getting system notifications to show up at all.

One interesting thing I noticed with the app on my physical device is that I randomly opened it (manually, without tapping a notification), and the top padding was also missing until I killed and reopened the app.

I can't reproduce anymore after closing and reopening the app multiple times though, so I feel like there might be other conditions for this to happen.

[francoisl]

Going to demote as discussed in https://expensify.slack.com/archives/C01GTK53T8Q/p1724857609487429, since we can't consistently reproduce.

[WoLewicki]

I'm now able to build the app locally in dev, but running into issues getting system notifications to show up at all.
One interesting thing I noticed with the app on my physical device is that I randomly opened it (manually, without tapping a notification), and the top padding was also missing until I killed and reopened the app.

@francoisl could you tell if this happened on dev or only on release? I was not able to reproduce it on dev.

[francoisl]

On my physical device? It was a staging release version, at the time 9.0.25-1 (the latest staging version was greater than that, but I guess my phone had not auto-updated the app yet)

[melvin-bot]

@puneetlath, @francoisl, @jayeshmangwani Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jayeshmangwani]

Not Overdue, We're still awaiting proposals here

[wildan-m]

I am an oracle #48190 (comment)

@puneetlath why this is closed and paid? where is the upstream PR?

The merged PR is essentially the same with my proposed solution. How compensation works in this case?

discussing in slack if no satisfactory answer within 24 hours.

[shubham1206agra]

The merged PR is essentially the same with my proposed solution. How compensation works in this case?

@wildan-m No compensation for you as no help wanted label was applied before PR was deployed.

[wildan-m]

@shubham1206agra every issues has help wanted tag removed after assignemnt. Please check carefully, I've send the proposal after help wanted tag added.

[shubham1206agra]

Ouch. Didn't noticed this.

@jayeshmangwani Can you check if @wildan-m is eligible for partial payment? Similar to other cases, payout will be $50.

[wildan-m]

@shubham1206agra can you send me the links to similar cases? where that 1/5 partial payment come from?

[jayeshmangwani]

discussing in slack if no satisfactory answer within 24 hours.

You can start a discussion if you'd like to.

[jayeshmangwani]

The merged PR is essentially the same with my proposed solution. How compensation works in this case?

Yes, the merged PR uses the same logic as your proposal. Regarding the compensation, I'm not sure if it will be a partial or full payout, so I'll leave that decision to @francoisl and @puneetlath.

[puneetlath]

Oh good point about the upstream PR, I forgot about that. @perunt that still needs to be done, correct?

[melvin-bot]

@puneetlath, @francoisl, @jayeshmangwani, @perunt Huh... This is 4 days overdue. Who can take care of this?

[puneetlath]

@perunt just checking in. Mind providing an update here?

[jayeshmangwani]

Hey @perunt , do we have any plans for an upstream fix? Can you please provide an update here?

[melvin-bot]

@puneetlath, @francoisl, @jayeshmangwani, @perunt Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@puneetlath, @francoisl, @jayeshmangwani, @perunt 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[jayeshmangwani]

Waiting on an update from Taras. bumped on Slack

[melvin-bot]

@puneetlath, @francoisl, @jayeshmangwani, @perunt 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@puneetlath, @francoisl, @jayeshmangwani, @perunt 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

This issue has not been updated in over 14 days. @puneetlath, @francoisl, @jayeshmangwani, @perunt eroding to Weekly issue.

[puneetlath]

Bumped in Slack again.

[perunt]

hey guys, quick update. I got a bit sidetracked with integrating the Nitro Module into the app, but I’m aiming to wrap it up by the end of this week and get back to this task. As I mentioned before, some changes were made to one of our libraries that should resolve the issue, and I'll test it once I finish the Contact Module