[$250] Send invoice - System message for invoice edit is missing "Reply in thread" for invoice sender #43797

lanitochka17 · 2024-06-15T17:35:18Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.4.84-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to FAB > Send invoice
Send invoice to User B
Go to transaction thread
Edit Amount
[User A and User B] Right click on the system message
Note that "Reply in thread" is missing for invoice sender but present for invoice receiver
[User B] Send a reply to the system message
[User A] Open the reply in thread
{User A] Click on the thread header subtitle
{User A] Click on the thread header subtitle again

Expected Result:

In Step 7, "Reply in thread" should be available for both invoice sender and receiver
In Step 10, the invoice thread should have no visual issue
In Step 11, user should be navigated to the main chat

Actual Result:

In Step 7, "Reply in thread" is missing for invoice sender but present for invoice receiver
In Step 10, the invoice details appear broken above existing invoice details
In Step 11, user is navigated to the same invoice thread instead of the main chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6514451_1718472036865.send_invoice_reply_in_thread.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0111ac375ebfe2baa1
Upwork Job ID: 1803175554822916116
Last Price Increase: 2024-08-08
Automatic offers:

rayane-djouah | Reviewer | 103213577
truph01 | Contributor | 103213579

Issue Owner

Current Issue Owner: @dylanexpensify

melvin-bot · 2024-06-15T17:35:30Z

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 · 2024-06-15T17:35:42Z

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

truph01 · 2024-06-17T05:18:44Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 7, "Reply in thread" is missing for invoice sender but present for invoice receiver
In Step 10, the invoice details appear broken above existing invoice details
In Step 11, user is navigated to the same invoice thread instead of the main chat

What is the root cause of that problem?

When we create a send invoice, we don't pass the ID of iouAction as a parameter in the SendInvoice API. It leads after the API is complete, the iou report has two IOU action

App/src/libs/actions/IOU.ts

Line 3545 in 1e0831e

const parameters: SendInvoiceParams = {

And then getOriginalReportID returns the wrong reportID for the system message because we get all reportActions of the iou report in Onyx which makes getOneTransactionThreadReportID function returns undefined.

App/src/libs/ReportUtils.ts

Line 6063 in 1e0831e

    
           const transactionThreadReportID = ReportActionsUtils.getOneTransactionThreadReportID(reportID, reportActions ?? ([] as ReportAction[]));

It doesn't happen in the ReportScreen because when we get the report actions here, it doesn't include the optimistic iou action

App/src/pages/home/ReportScreen.tsx

Line 261 in 1e0831e

    
           return ReportActionsUtils.getContinuousReportActionChain(sortedAllReportActions, reportActionIDFromRoute);

What changes do you think we should make in order to solve the problem?

We should pass the reportActionID of iouAction as a parameter of the SendInvoice API and BE will use this reportActionID to create the iouAction and return data for the user.

App/src/libs/actions/IOU.ts

Line 3545 in 1e0831e

const parameters: SendInvoiceParams = {

To do that we should

In getSendInvoiceInformation function, we will return iouReportActionID: iouAction.reportID here

App/src/libs/actions/IOU.ts

Line 1844 in 1e0831e

return {

What alternative solutions did you explore? (Optional)

Get the iouReportActionID when we call getSendInvoiceInformation function here

App/src/libs/actions/IOU.ts

Line 3542 in 1e0831e

    
           const {senderWorkspaceID, receiver, invoiceRoom, createdChatReportActionID, invoiceReportID, reportPreviewReportActionID, transactionID, transactionThreadReportID, onyxData} =

and then pass it as a parameter of SendInvoice API here

App/src/libs/actions/IOU.ts

Line 3545 in 1e0831e

const parameters: SendInvoiceParams = {

We need a BE change here that will use iouReportActionID param to generate the the iouAction.

OPTIONAL: The created action of the transaction thread report is also duplicated. The RCA is the same with the iouAction, we can add the same fix for this action as well.

tsa321 · 2024-06-17T15:16:21Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Send invoice - System message for invoice edit is missing "Reply in thread" for invoice sender and some visual issues related to transaction details.

What is the root cause of that problem?

When user send an invoice to the server returns new IOU report action which has different report action id than optimistic report action.

Basically because there are two IOU report action after user send invoice (one from optimistic action, one from server, this two IOU have different report action ids). The report view/list success to display correct report actions, this is because the optimistic IOU report action is filtered by this function, so it is not displayed in report actions list:

App/src/pages/home/ReportScreen.tsx

Line 261 in f618a94

    
           return ReportActionsUtils.getContinuousReportActionChain(sortedAllReportActions, reportActionIDFromRoute);

When report actions in view/list only have 1 IOU report actions it will display transaction details (this is already correct).
If it is more than one it will displayed as REPORTPREVIEW for each IOU report actions.

Also, when only 1 IOU report actions is displayed, the child transactions details thread reportactions will be merged into parent report report actions(which is the report which don't has "Reply in thread").
So basically the report actions of report which doesn't have a "Reply in thread" consist of report actions from that report and child transaction thread report.

Because of the getContinuousReportActionChain which is success to filter the optimistic IOU report action, but when user right click to show report acitons context menu item it fails to display Reply in Thread. This is because:

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Lines 205 to 207 in b3f688b

    
           const originalReportID = ReportUtils.getOriginalReportID(reportID, reportAction); 
        
           const originalReport = ReportUtils.getReport(originalReportID); 
        
           showContextMenu(

The getOriginalReportID fails to get the correct child (original) report id / the transaction thread report which is the report that show the system message about money request update / the report which is the report actions are merged into parent if parent only has 1 IOU report action.

This is because:

App/src/libs/ReportUtils.ts

Lines 6066 to 6070 in f618a94

    
           function getOriginalReportID(reportID: string, reportAction: OnyxInputOrEntry<ReportAction>): string | undefined { 
        
               const reportActions = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`]; 
        
               const currentReportAction = reportActions?.[reportAction?.reportActionID ?? '-1'] ?? null; 
        
               const transactionThreadReportID = ReportActionsUtils.getOneTransactionThreadReportID(reportID, reportActions ?? ([] as ReportAction[])); 
        
               if (Object.keys(currentReportAction ?? {}).length === 0) {

getOneTransactionThreadReportID :

App/src/libs/ReportActionsUtils.ts

Lines 920 to 922 in f618a94

    
           if (!iouRequestActions.length || iouRequestActions.length > 1) { 
        
               return; 
        
           }

Fails to returns correct childreportid / trasaction thread report id, because early return in that if clause.
This is because there are two IOU report actions (one from optimistic update and one from backend, these two report actions have different reportActionID).

Because of incorrect originalReportID, the reportActions here:

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Lines 131 to 144 in f618a94

    
           const reportAction: OnyxEntry<ReportAction> = useMemo(() => { 
        
               if (isEmptyObject(reportActions) || reportActionID === '0' || reportActionID === '-1') { 
        
                   return; 
        
               } 
        
               return reportActions[reportActionID]; 
        
           }, [reportActions, reportActionID]); 
        
           const originalReportID = useMemo(() => ReportUtils.getOriginalReportID(reportID, reportAction), [reportID, reportAction]); 
        
           const shouldEnableArrowNavigation = !isMini && (isVisible || shouldKeepOpen); 
        
           let filteredContextMenuActions = ContextMenuActions.filter( 
        
               (contextAction) => 
        
                   !disabledActions.includes(contextAction) && 
        
                   contextAction.shouldShow(type, reportAction, isArchivedRoom, betas, anchor, isChronosReport, reportID, isPinnedChat, isUnreadChat, !!isOffline, isMini),

the reportAction here will be undefined, and ContextMenuActions.filter will filter Reply In Thread context menu because the context menu give false result in contextAction.shouldShow.

What changes do you think we should make in order to solve the problem?

We could remove onyx optimistic IOU report actions because server returns new/different IOU report actions, in here:

App/src/libs/actions/IOU.ts

Lines 1035 to 1041 in b3f688b

    
           [iouCreatedAction.reportActionID]: { 
        
               pendingAction: null, 
        
               errors: null, 
        
           }, 
        
           [iouAction.reportActionID]: { 
        
               pendingAction: null, 
        
               errors: null,

inside successData in buildOnyxDataForInvoice,

We set the

[transactionThreadCreatedReportAction.reportActionID]: null
....

[iouCreatedAction.reportActionID]: null,
[iouAction.reportActionID]: null,

We set it to null, to remove the optimistic iou report actions...

For the navigation and header issue, we should use the parent of parent header and back to report link, if the parent of parent report is one trasaction / only has 1 IOU report action.

alternative solution:

Use getContinuousReportActionChain inside getOneTrasactionReportID to filter out the optmistic IOU report action.

dylanexpensify · 2024-06-17T19:40:43Z

reproing today!

melvin-bot · 2024-06-18T21:18:50Z

Job added to Upwork: https://www.upwork.com/jobs/~0111ac375ebfe2baa1

melvin-bot · 2024-06-18T21:18:55Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

dylanexpensify · 2024-06-18T21:19:19Z

added to project

rayane-djouah · 2024-06-20T14:39:17Z

@truph01, @tsa321
Thank you, everyone, for the proposals.
Both proposals do not have a clear RCA.
Can you please clearly explain in detail:

Why is the "Reply in thread" option disabled for invoice sender?
Why is there a duplicate report action for the invoice details?
Why is the user navigated to the same invoice thread instead of the main chat?

tsa321 · 2024-06-20T15:58:13Z

@rayane-djouah

Why is the "Reply in thread" option disabled for invoice sender?

Basically because there are two IOU report action after user send invoice (one from optimistic action, one from server, this two IOU have different report action ids).
The optimistic IOU is filtered by this function, so it is not displayed in report actions list:

App/src/pages/home/ReportScreen.tsx

Line 261 in f618a94

    
           return ReportActionsUtils.getContinuousReportActionChain(sortedAllReportActions, reportActionIDFromRoute);

When report actions in view/list only have 1 IOU report actions it will display transaction details (this is already correct).
If it is more than one it will displayed as REPORTPREVIEW for each IOU report actions.

Also, when only 1 IOU report actions is displayed, the child transactions details thread reportactions will be merged into parent report report actions(which is the report which don't has "Reply in thread").
So basically the report actions of report which doesn't have a "Reply in thread" consist of report actions from that report and child transaction thread report.

The getContinuousReportActionChain success to filter out the optimistic IOU report action, but when user right click to show report actions context menu item it fails to display Reply in Thread. This is because:

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Lines 205 to 207 in b3f688b

    
           const originalReportID = ReportUtils.getOriginalReportID(reportID, reportAction); 
        
           const originalReport = ReportUtils.getReport(originalReportID); 
        
           showContextMenu(

The getOriginalReportID fails to get the correct child (original) report id / the transaction thread report which is the report that show the system message about money request update / the report which is the report actions are merged into parent if parent only has 1 IOU report action.

This is because:

App/src/libs/ReportUtils.ts

Lines 6066 to 6070 in f618a94

    
           function getOriginalReportID(reportID: string, reportAction: OnyxInputOrEntry<ReportAction>): string | undefined { 
        
               const reportActions = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`]; 
        
               const currentReportAction = reportActions?.[reportAction?.reportActionID ?? '-1'] ?? null; 
        
               const transactionThreadReportID = ReportActionsUtils.getOneTransactionThreadReportID(reportID, reportActions ?? ([] as ReportAction[])); 
        
               if (Object.keys(currentReportAction ?? {}).length === 0) {

getOneTransactionThreadReportID :

App/src/libs/ReportActionsUtils.ts

Lines 920 to 922 in f618a94

    
           if (!iouRequestActions.length || iouRequestActions.length > 1) { 
        
               return; 
        
           }

Fails to returns correct childreportid / trasaction thread report id, because early return in that if clause.
This is because there are two IOU report actions (one from optimistic update and one from backend, these two report actions have different reportActionID).

Because of incorrect originalReportID, the reportActions here:

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Lines 131 to 144 in f618a94

    
           const reportAction: OnyxEntry<ReportAction> = useMemo(() => { 
        
               if (isEmptyObject(reportActions) || reportActionID === '0' || reportActionID === '-1') { 
        
                   return; 
        
               } 
        
               return reportActions[reportActionID]; 
        
           }, [reportActions, reportActionID]); 
        
           const originalReportID = useMemo(() => ReportUtils.getOriginalReportID(reportID, reportAction), [reportID, reportAction]); 
        
           const shouldEnableArrowNavigation = !isMini && (isVisible || shouldKeepOpen); 
        
           let filteredContextMenuActions = ContextMenuActions.filter( 
        
               (contextAction) => 
        
                   !disabledActions.includes(contextAction) && 
        
                   contextAction.shouldShow(type, reportAction, isArchivedRoom, betas, anchor, isChronosReport, reportID, isPinnedChat, isUnreadChat, !!isOffline, isMini),

the reportAction here will be undefined, and ContextMenuActions.filter will filter Reply In Thread context menu because the context menu give false result in contextAction.shouldShow.

I have updated my proposal in RCA section.

Why is there a duplicate report action for the Why is there a duplicate report action for the invoice details??

Because after user send invoice the report action of type CREATE and IOU from optimistic update and from back end are preserved/stored. Both have different report action ids. The details is representation of CREATE report action, when there are two create report action, there is a glitch when the APP try to display two invoice details.

Why is the user navigated to the same invoice thread instead of the main chat?

because the system message of IOU request upate/edit are from child thread transaction report. The system message is displayed/merged into parent report because the parent has exactly one IOU report action (because report screen success filtering the optimistic IOU report action).
basically the system message is from child transaction thread report.

truph01 · 2024-06-20T17:31:25Z

@rayane-djouah

Why is the "Reply in thread" option disabled for invoice sender?

This because the originalReportID is wrong as I mentioned in my proposal and then we can't get the current reportAction in BaseReportActionContextMenu

Why is there a duplicate report action for the invoice details?

Because BE generate an iou action with a random reportActionID instead of using the reportActionID from front-end, after SendInvoice API is complete we have two iou action, one from server, one is optimistic iou action.

Why is the user navigated to the same invoice thread instead of the main chat?

This is not the same chat. The first chat is the transaction thread report that is the current parent report of the system message thread. The second is the invoice room but this report has only one transaction and then this report display as combine report that will display all report actions of invoice room and all report actions of the transaction thread. So this case isn't a bug.

rayane-djouah · 2024-06-20T20:25:12Z

@truph01 - I think you included the "What alternative solutions did you explore? (Optional)" title in the middle of your solution by mistake?

rayane-djouah · 2024-06-20T20:25:27Z

@tsa321, @truph01 Thank you for your explanations.

I confirmed that we are having duplicate iouAction and createdActionForIOUReport for the invoice sender; below my investigation:

I sent an invoice
Result from :

App/src/libs/actions/IOU.ts

Line 1828 in 896c14c

    
           const [optimisticCreatedActionForChat, optimisticCreatedActionForIOUReport, iouAction, optimisticTransactionThread, optimisticCreatedActionForTransactionThread] =

Invoice sender onyx data:

Invoice receiver onyx data:

The "Reply in thread" option is missing for the sender.
When I deleted site data in the invoice sender session and logged in again, the "Reply in thread" option was available.
I retried the scenario and sent the reply in a thread from the receiver; the invoice details appear duplicated in the sender session.
When I deleted site data in the invoice sender session and logged in again, the invoice details appeared correct.

Conclusion: the root bug cause of the bug is that we have duplicate reportActionID, createdIOUReportActionID, and createdReportActionIDForThread. Therefore, similar to RequestMoneyParams and other IOU API endpoints, we should includereportActionID, createdIOUReportActionID, and createdReportActionIDForThread in SendInvoiceParams, and BE should use this IDs to create the report actions and return data with correct IDs.

Both proposals have a correct RCA, but @truph01 was the first to identify the root cause and provide the correct solution based on what we established as a pattern in IOU flows like Track Expense and Request Money...

@tsa321 - Removing optimistic IOU report actions inside successData in buildOnyxDataForInvoice could work, but I think it's not the optimal solution and does not follow the established pattern in other IOU flows.

Why is the user navigated to the same invoice thread instead of the main chat?
This is not the same chat. The first chat is the transaction thread report that is the current parent report of the system message thread. The second is the invoice room but this report has only one transaction and then this report display as combine report that will display all report actions of invoice room and all report actions of the transaction thread. So this case isn't a bug.

I will let the assigned internal engineer decide whether we should fix the header link so we can navigate directly to the invoice room when we are in one transaction report instead of navigating to the iou report and then to the invoice report. I think we can address this in the PR.

@truph01's proposal looks good to me.

🎀👀🎀 C+ reviewed

melvin-bot · 2024-06-20T20:25:37Z

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

dylanexpensify · 2024-06-21T09:57:26Z

@cristipaval to review and confirm

cristipaval · 2024-06-21T12:14:54Z

I think @truph01 can work on new issues once they merge all the ongoing ones. @dylanexpensify, can you confirm? 🙏

melvin-bot · 2024-06-24T18:34:26Z

@cristipaval, @dylanexpensify, @rayane-djouah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

rayane-djouah · 2024-06-24T18:40:30Z

@dylanexpensify ^^

melvin-bot · 2024-06-25T16:00:08Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

cristipaval · 2024-08-26T12:56:34Z

Waiting for the PR to get deployed.

rayane-djouah · 2024-08-28T00:17:33Z

@cristipaval - Reminder that the old reports with 2 CREATED report actions still need to be cleaned up. Are you tracking this internally?

dylanexpensify · 2024-08-28T10:44:46Z

Bump @cristipaval 🙇‍♂️

cristipaval · 2024-08-28T11:31:05Z

@cristipaval - Reminder that the old reports with 2 CREATED report actions still need to be cleaned up. Are you tracking this internally?

I don't think it makes sense to spend time on cleaning that as we don't have active users using the invoice rooms yet.

@madmax330, do you think we should run some custom queries to clean the DB, or should we deal with it if it becomes a real problem?

rayane-djouah · 2024-08-31T08:23:47Z

⚠️ We just got confirmation on Slack that the Deploy Checklist: New Expensify 2024-08-26 which includes the PR of this issue was only deployed to production in Deploy Checklist: New Expensify 2024-08-28. More context on why this happened can be found in this Slack thread and this Slack comment.

Given the context above, this issue should be on [HOLD for Payment 2024-09-6] according to today's production deploy from Deploy Checklist: New Expensify 2024-08-28.

cc @dylanexpensify

madmax330 · 2024-09-02T12:51:44Z

do you think we should run some custom queries to clean the DB, or should we deal with it if it becomes a real problem?

@cristipaval are they real users or test users?
Let's clean them up anyway so we don't spend time looking into it later?

rayane-djouah · 2024-09-02T14:58:22Z

@madmax330 - It looks like @cristipaval is on parental leave, could you please create an internal issue for this? Thanks!

melvin-bot · 2024-09-02T18:05:16Z

@madmax330, @cristipaval, @dylanexpensify, @rayane-djouah, @truph01 Eep! 4 days overdue now. Issues have feelings too...

dylanexpensify · 2024-09-04T14:48:25Z

@madmax330 shall we get a new engineer on this? Or are you on it?

madmax330 · 2024-09-06T14:56:46Z

@dylanexpensify actually I think we can just close this out since it was fixed already and the 2 report actions don't cause much of a problem

rayane-djouah · 2024-09-06T18:45:48Z

@dylanexpensify This is due payment - #43797 (comment) Thanks!

madmax330 · 2024-09-09T13:58:40Z

Cool is there a payment summary already?

melvin-bot · 2024-09-09T18:03:32Z

@madmax330, @cristipaval, @dylanexpensify, @rayane-djouah, @truph01 Huh... This is 4 days overdue. Who can take care of this?

dylanexpensify · 2024-09-10T10:47:40Z

Payment summary:

Contributor: @truph01 $250
Contributor+: @rayane-djouah $250

Please apply/request!

rayane-djouah · 2024-09-10T10:48:42Z

Here is the pull request that resolves this issue:

Fix: Send invoice - System message for invoice edit is missing Reply in thread for invoice sender #46001

Here are the issues fixed by the PR:

[$250] Send invoice - System message for invoice edit is missing "Reply in thread" for invoice sender #43797
[HOLD][$250] Send invoices - Date notification not copied when invoice date is changed #43571
[HOLD][$250] Send invoice - Unable to dismiss error after editing the amount of paid invoice #43577.
[$250 BLOCKED BY #44388] Send invoice - Invoice report appears broken #44992

Checklist

The PR that introduced the bug has been identified. Link to the PR: Implement Send Invoice flow from Global Create #40015
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40015/files#r1751709178
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Test case 1:

Go to FAB > Send invoice.
Send invoice to User B.
Go to transaction thread. Verify there is no visual issue.
Edit Amount.
[User A and User B] Right click on the system message.
Verify that "Reply in thread" is displayed in both invoice sender and invoice receiver.

Test case 2:

Navigate to FAB > Send invoice
Add amount, select user and workspace
Add merchant and send the invoice
Go to invoice details and change the date
Notice the notification appears. Attempt to copy it, and verify that is copied successfully.

Test case 3:

[User A] Send invoice to User B
[User A and B] Go to invoice thread
[User B] Pay the invoice
[User A] Quickly change the amount
[User A] Dismiss the error under the amount edit system message
Verify that User A will be able to dismiss the error under the amount edit system message

Test case 4:

Go to FAB > Send invoice
Enter amount and select a receiver
Enter merchant and send the invoice
In invoice chat, click on the preview
Verify that the invoice report will not appear broken

Do we agree 👍 or 👎

melvin-bot · 2024-09-13T18:01:16Z

@madmax330, @cristipaval, @dylanexpensify, @rayane-djouah, @truph01 Whoops! This issue is 2 days overdue. Let's get this updated quick!

rayane-djouah · 2024-09-16T14:52:15Z

@dylanexpensify Friendly bump

melvin-bot · 2024-09-17T18:01:38Z

@madmax330, @cristipaval, @dylanexpensify, @rayane-djouah, @truph01 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

dylanexpensify · 2024-09-17T18:02:26Z

on it now.

dylanexpensify · 2024-09-17T18:12:11Z

done!

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 15, 2024

melvin-bot bot assigned dylanexpensify Jun 15, 2024

dylanexpensify added the External Added to denote the issue can be worked on by a contributor label Jun 18, 2024

melvin-bot bot changed the title ~~Send invoice - System message for invoice edit is missing "Reply in thread" for invoice sender~~ [$250] Send invoice - System message for invoice edit is missing "Reply in thread" for invoice sender Jun 18, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 18, 2024

melvin-bot bot assigned rayane-djouah Jun 18, 2024

dylanexpensify added this to [#whatsnext] #billpay Jun 18, 2024

melvin-bot bot assigned cristipaval Jun 20, 2024

melvin-bot bot added the Overdue label Jun 24, 2024

melvin-bot bot removed the Overdue label Jun 24, 2024

melvin-bot bot removed the Overdue label Aug 26, 2024

melvin-bot bot added the Overdue label Aug 30, 2024

melvin-bot bot removed the Overdue label Sep 4, 2024

melvin-bot bot added the Overdue label Sep 6, 2024

rayane-djouah mentioned this issue Sep 10, 2024

Implement Send Invoice flow from Global Create #40015

Merged

50 tasks

melvin-bot bot removed the Overdue label Sep 10, 2024

melvin-bot bot added the Overdue label Sep 12, 2024

melvin-bot bot removed the Overdue label Sep 17, 2024

dylanexpensify closed this as completed Sep 17, 2024

github-project-automation bot moved this from Low to Done in [#whatsnext] #billpay Sep 17, 2024

[$250] Send invoice - System message for invoice edit is missing "Reply in thread" for invoice sender #43797

[$250] Send invoice - System message for invoice edit is missing "Reply in thread" for invoice sender #43797

Comments

lanitochka17 commented Jun 15, 2024 • edited by cristipaval Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Jun 15, 2024

lanitochka17 commented Jun 15, 2024

truph01 commented Jun 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

tsa321 commented Jun 17, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

alternative solution:

dylanexpensify commented Jun 17, 2024

melvin-bot bot commented Jun 18, 2024

melvin-bot bot commented Jun 18, 2024

dylanexpensify commented Jun 18, 2024

rayane-djouah commented Jun 20, 2024 • edited Loading

tsa321 commented Jun 20, 2024 • edited Loading

truph01 commented Jun 20, 2024

rayane-djouah commented Jun 20, 2024

rayane-djouah commented Jun 20, 2024

melvin-bot bot commented Jun 20, 2024

dylanexpensify commented Jun 21, 2024

cristipaval commented Jun 21, 2024

melvin-bot bot commented Jun 24, 2024

rayane-djouah commented Jun 24, 2024

melvin-bot bot commented Jun 25, 2024

cristipaval commented Aug 26, 2024

rayane-djouah commented Aug 28, 2024

dylanexpensify commented Aug 28, 2024

cristipaval commented Aug 28, 2024

rayane-djouah commented Aug 31, 2024

madmax330 commented Sep 2, 2024

rayane-djouah commented Sep 2, 2024

melvin-bot bot commented Sep 2, 2024

dylanexpensify commented Sep 4, 2024

madmax330 commented Sep 6, 2024

rayane-djouah commented Sep 6, 2024

madmax330 commented Sep 9, 2024

melvin-bot bot commented Sep 9, 2024

dylanexpensify commented Sep 10, 2024

rayane-djouah commented Sep 10, 2024 • edited Loading

Checklist

melvin-bot bot commented Sep 13, 2024

rayane-djouah commented Sep 16, 2024

melvin-bot bot commented Sep 17, 2024

dylanexpensify commented Sep 17, 2024

dylanexpensify commented Sep 17, 2024

lanitochka17 commented Jun 15, 2024 •

edited by cristipaval

Loading

tsa321 commented Jun 17, 2024 •

edited

Loading

rayane-djouah commented Jun 20, 2024 •

edited

Loading

tsa321 commented Jun 20, 2024 •

edited

Loading

rayane-djouah commented Sep 10, 2024 •

edited

Loading