-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Send Invoice flow from Global Create #40015
Merged
cristipaval
merged 64 commits into
Expensify:main
from
VickyStash:feature/global-send-invoice
Apr 29, 2024
Merged
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
820276d
Partly update start, participants and confirmation steps to support i…
VickyStash b6689d3
Implement send from (select sender) screen
VickyStash dd8d87b
Merge branch 'main' into feature/global-send-invoice
VickyStash 059f946
Implement send invoice functionality
VickyStash 3456531
Merge branch 'main' into feature/global-send-invoice
VickyStash 56e3b9a
Fix ts issues after merging main
VickyStash 23be9e4
Code improvements
VickyStash 36b645e
IOU file updates and lint fixes
VickyStash f611c60
Implement buildOptimisticInviteReportAction function
VickyStash c4b0fdb
Fix navigation
VickyStash ad6829b
Fix invoice creation from global in invoice chat room already exists
VickyStash a361e7e
Merge branch 'main' into feature/global-send-invoice
VickyStash 8895b17
Minor lint fix
VickyStash 7526db1
Enable add receipt file feature, lint fixes
VickyStash e8f56c4
Minor UI fixes
VickyStash 66e6a31
Fix translation
VickyStash 0c2b802
Fix report preview message
VickyStash 290eeb4
Merge branch 'main' into feature/global-send-invoice
VickyStash d831b0d
Minor code improvements
VickyStash 531b3c5
Fix canSendInvoice check
VickyStash dafdc75
Minor code improvements
VickyStash 96aa755
Put iouCreatedAction to optimistic data
VickyStash 111c1fa
Merge branch 'main' into feature/global-send-invoice
VickyStash 4d872eb
Minor improvements
VickyStash 75f8b23
Update optimistic invoice room creation to include current user as a …
VickyStash 6db22e2
Add INVOICE_RECEIVER_TYPE to consts
VickyStash 173432f
Code improvements
VickyStash ae06c5b
Add optimistic personal details for the receiver; update params
VickyStash 42612fe
Merge branch 'main' into feature/global-send-invoice
VickyStash f19a19c
Add SendInvoiceInformation type
VickyStash 982ec59
Merge branch 'main' into feature/global-send-invoice
VickyStash 0c4209d
Fix to follow typing rules in ROUTES
VickyStash aefb407
Merge branch 'main' into feature/global-send-invoice
VickyStash 0738a3e
Update param invoiceRoomID -> invoiceRoomReportID
VickyStash 37ba264
Merge branch 'main' into feature/global-send-invoice
VickyStash a3c0e38
Updates to follow main branch changes
VickyStash 6687828
Merge branch 'main' into feature/global-send-invoice
VickyStash 4dd7699
Lint fix
VickyStash 209ed51
Merge branch 'main' into feature/global-send-invoice
VickyStash 8618241
Update sender logic to work with updates in main
VickyStash 41aa191
Merge branch 'main' into feature/global-send-invoice
VickyStash 5ca73f1
Lint fix
VickyStash 2ab9717
Merge branch 'main' into feature/global-send-invoice
VickyStash 5579af2
TS fixes
VickyStash 5801e4f
Lint fixes
VickyStash 68afedd
Hide tabs on the amount step for invoices
VickyStash 5c8d058
Merge branch 'main' into feature/global-send-invoice
VickyStash 31b47a7
Fixes after merging main
VickyStash b30e98f
Merge branch 'main' into feature/global-send-invoice
VickyStash e22c3eb
Update invoice-generic.svg icon
VickyStash f3d0233
Use default SectionList checkmark on the SendFrom screen
VickyStash cc36c78
Remove unused style
VickyStash 43c0ad7
Don't show three dots on the confirmation screen
VickyStash e448d96
Update Send From list display
VickyStash df9feae
Merge branch 'main' into feature/global-send-invoice
VickyStash 9e6a446
Lint fix
VickyStash 976967d
Merge branch 'main' into feature/global-send-invoice
VickyStash ff25547
Remove duplicates
VickyStash b2f9320
Fix invoice report name display
VickyStash c36bd3b
Hide payment button for invoices
VickyStash 88db153
Disable invoice editing for the invoice receiver
VickyStash 00f490a
Disable invoice receipt update
VickyStash ef766ad
Fix LHN option display
VickyStash 4371082
Remove quick action update during invoice creation
VickyStash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
type SendInvoiceParams = { | ||
senderWorkspaceID: string; | ||
accountID: number; | ||
receiverEmail?: string; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice little pro tip: either |
||
receiverInvoiceRoomID?: string; | ||
amount: number; | ||
currency: string; | ||
merchant: string; | ||
date: string; | ||
category?: string; | ||
invoiceRoomReportID?: string; | ||
createdChatReportActionID: string; | ||
invoiceReportID: string; | ||
reportPreviewReportActionID: string; | ||
transactionID: string; | ||
transactionThreadReportID: string; | ||
}; | ||
|
||
export default SendInvoiceParams; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, This PR missed
createdIOUReportActionID
,createdReportActionIDForThread
,reportActionID
Send Invoice params and caused these issues: #43797, #43571, #43577, #44992. More info in this proposal: #43797 (comment)