chore(linting): restore some ESLint rules #9123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
requested review from
benelan,
driskull,
geospatialem and
a team
as code owners
github-actions
bot
added
the
chore
jcfranco
added
the
skip visual snapshots
jcfranco
changed the title
This was referenced May 2, 2024
jcfranco
added a commit
that referenced
this pull request
May 3, 2024
…-mode` and `input-mode` attributes (#9245) **Related Issue:** #9235 ## Summary This fixes the following issues introduced by #9123 when component props that shadowed global attributes were removed: * the kebab-cased attribute names of those props would no longer work (namely, `enter-key-mode`, `input-mode`) * `autofocus` was missing from component types as Stencil does not include it in the base `HTMLAttribute` type (see ionic-team/stencil#5726).
jcfranco
added a commit
that referenced
this pull request
May 10, 2024
…-mode` and `input-mode` attributes (#9245) **Related Issue:** #9235 ## Summary This fixes the following issues introduced by #9123 when component props that shadowed global attributes were removed: * the kebab-cased attribute names of those props would no longer work (namely, `enter-key-mode`, `input-mode`) * `autofocus` was missing from component types as Stencil does not include it in the base `HTMLAttribute` type (see ionic-team/stencil#5726).
jcfranco
added a commit
that referenced
this pull request
May 10, 2024
…-mode` and `input-mode` attributes (#9245) (#9306) **Related Issue:** #9235 ## Summary This fixes the following issues introduced by #9123 when component props that shadowed global attributes were removed: * the kebab-cased attribute names of those props would no longer work (namely, `enter-key-mode`, `input-mode`) * `autofocus` was missing from component types as Stencil does not include it in the base `HTMLAttribute` type (see ionic-team/stencil#5726). Co-authored-by: Ben Elan <[email protected]>
jcfranco
added a commit
that referenced
this pull request
Jul 11, 2024
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
Restores the following rules:
@jest/expect-expect@stencil-community/decorators-context@stencil-community/strict-boolean-conditions@stencil-community/reserved-member-names@stencil-community/ban-exported-const-enums@typescript-eslint/no-duplicate-enum-valuesDisables the following:
@esri/calcite-components/strict-boolean-attributes(replaced by@stencil-community/ban-default-true)