Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are ESLint errors for a few rules #8371

Closed
benelan opened this issue Dec 7, 2023 · 1 comment
Closed

There are ESLint errors for a few rules #8371

benelan opened this issue Dec 7, 2023 · 1 comment
Assignees
@jcfranco
Labels
1 - assigned Issues that are assigned to a sprint and a team member. tooling Issues relating to build system fixes or improvements.
Milestone
2024-08-27 - Aug ...

Comments

@benelan
Copy link
Member

benelan commented Dec 7, 2023 •
edited
Loading

Summary

We have ESLint errors for the following rules

  • @typescript-eslint/no-duplicate-enum-values - once here

  • @stencil-community/reserved-member-names - lots of places related to the hidden prop

  • @stencil-community/ban-exported-const-enums a few places in resource.ts files e.g. here and here

Desired Outcome

Resolve the ESLint errors (if possible) And re-enable the rules that were disabled in #8372

Resources

No response
@benelan benelan added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 7, 2023
@benelan benelan mentioned this issue Dec 7, 2023
Merged
@benelan benelan added 1 - assigned Issues that are assigned to a sprint and a team member. needs triage Planning workflow - pending design/dev review. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 7, 2023
jcfranco pushed a commit that referenced this issue Dec 8, 2023
@benelan
ci(eslint): disable eslint rules that are failing (#8372)
d30d19e 
**Related Issue:** #8371

## Summary

Disables a few ESLint rules that we have errors for in Calcite
Components. Franco asked me to disable them for now and create an issue
for him to see if any can be resolved and re-enabled.

- `@typescript-eslint/no-duplicate-enum-values` - once
[here](https://github.com/Esri/calcite-design-system/blob/81fab56c6e8a76623c3f0adcb3f9cde761f46b98/packages/calcite-components/src/components/resources.ts#L3-L6)
- `@stencil-community/reserved-member-names` - lots of places related to
the `hidden` prop

- `@stencil-community/ban-exported-const-enums` a few places in
`resource.ts` files e.g.
[here](https://github.com/Esri/calcite-design-system/blob/81fab56c6e8a76623c3f0adcb3f9cde761f46b98/packages/calcite-components/src/components/resources.ts#L3-L6)
and
[here](https://github.com/Esri/calcite-design-system/blob/81fab56c6e8a76623c3f0adcb3f9cde761f46b98/packages/calcite-components/src/components/value-list/resources.ts#L5-L7)


You can reproduce the errors with:

```sh
npm --workspace=@esri/calcite-components run lint:ts
```
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 29, 2024
@jcfranco
Copy link
Member

This was addressed by #9123. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfranco jcfranco

Labels
1 - assigned Issues that are assigned to a sprint and a team member. tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @benelan