Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input, input-number, input-text): restore autofocus, enter-key-mode and input-mode attributes (#9245) #9306

Merged
merged 2 commits into from
May 10, 2024
Merged

fix(input, input-number, input-text): restore autofocus, enter-key-mode and input-mode attributes (#9245) #9306

merged 2 commits into from
May 10, 2024

Conversation

jcfranco
Copy link
Member

Related Issue: #9235

Summary

This fixes the following issues introduced by #9123 when component props
that shadowed global attributes were removed:

@jcfranco
fix(input, input-number, input-text): restore autofocus, `enter-key…
2542f4e 
…-mode` and `input-mode` attributes (#9245)

**Related Issue:** #9235

## Summary

This fixes the following issues introduced by #9123 when component props
that shadowed global attributes were removed:

* the kebab-cased attribute names of those props would no longer work
(namely, `enter-key-mode`, `input-mode`)
* `autofocus` was missing from component types as Stencil does not
include it in the base `HTMLAttribute` type (see
ionic-team/stencil#5726).
@jcfranco jcfranco requested a review from a team as a code owner May 10, 2024 17:44
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 10, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label May 10, 2024
@jcfranco jcfranco requested a review from benelan May 10, 2024 20:12
@jcfranco
Copy link
Member Author

Merging into the hotfix branch as this was already approved in #9245.

@jcfranco jcfranco merged commit 0498c6e into hotfix May 10, 2024
10 checks passed
@jcfranco jcfranco deleted the jcfranco/fix-regression-from-global-attr-change branch May 10, 2024 20:40
@calcite-admin calcite-admin mentioned this pull request May 10, 2024
Merged
geospatialem pushed a commit that referenced this pull request May 14, 2024
@calcite-admin
chore: release hotfix (#9308)
d1f9381 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.8.1</summary>

##
[2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-14)


### Bug Fixes

* Add type-fest as dependency due to build error
([3819688](3819688))
* **carousel:** Animate items with the same direction
([#9325](#9325))
([6bf7b74](6bf7b74))
* **input, input-number, input-text:** Restore `autofocus`,
`enter-key-mode` and `input-mode` attributes
([#9245](#9245))
([#9306](#9306))
([0498c6e](0498c6e))
* **list-item:** Decrease horizontal spacing between selection icon and
content
([#9304](#9304))
([0e828b6](0e828b6))
</details>

<details><summary>@esri/calcite-components-angular: 2.8.1</summary>

##
[2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-14)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1
</details>

<details><summary>@esri/calcite-components-react: 2.8.1</summary>

##
[2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-14)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
benelan pushed a commit that referenced this pull request May 14, 2024
@calcite-admin @benelan
chore: release hotfix (#9308)
3a4f5ed 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.8.1</summary>

[2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-14)

* Add type-fest as dependency due to build error
([3819688](3819688))
* **carousel:** Animate items with the same direction
([#9325](#9325))
([6bf7b74](6bf7b74))
* **input, input-number, input-text:** Restore `autofocus`,
`enter-key-mode` and `input-mode` attributes
([#9245](#9245))
([#9306](#9306))
([0498c6e](0498c6e))
* **list-item:** Decrease horizontal spacing between selection icon and
content
([#9304](#9304))
([0e828b6](0e828b6))
</details>

<details><summary>@esri/calcite-components-angular: 2.8.1</summary>

[2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-14)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1
</details>

<details><summary>@esri/calcite-components-react: 2.8.1</summary>

[2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-14)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@benelan benelan mentioned this pull request May 14, 2024
Merged
benelan added a commit that referenced this pull request May 14, 2024
@benelan @calcite-admin
chore: release hotfix (#9338)
3153012 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.8.1</summary>


[2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-14)

* Add type-fest as dependency due to build error
([3819688](3819688))
* **carousel:** Animate items with the same direction
([#9325](#9325))
([6bf7b74](6bf7b74))
* **input, input-number, input-text:** Restore `autofocus`,
`enter-key-mode` and `input-mode` attributes
([#9245](#9245))
([#9306](#9306))
([0498c6e](0498c6e))
* **list-item:** Decrease horizontal spacing between selection icon and
content
([#9304](#9304))
([0e828b6](0e828b6))
</details>

<details><summary>@esri/calcite-components-angular: 2.8.1</summary>


[2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-14)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1
</details>

<details><summary>@esri/calcite-components-react: 2.8.1</summary>


[2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-14)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1
</details>

---
This PR was generated with
[ReleasePlease](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <[email protected]>
@calcite-admin calcite-admin mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan Awaiting requested review from benelan

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @geospatialem @benelan