fix(carousel): animate items with the same direction #9325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
macandcheese
approved these changes
May 14, 2024
| @@ -653,3 +653,61 @@ export function isBefore(a: HTMLElement, b: HTMLElement): boolean { | |||
| const children = Array.from(a.parentNode.children); | |||
| return children.indexOf(a) < children.indexOf(b); | |||
| } | |||
|
|
|||
| /** | |||
|
E2E test added! |
jcfranco
added
skip visual snapshots
Merged
geospatialem
modified the milestones:
2024-05-28 - May Main Release,
2024-05-14 - May maintenance release
geospatialem
pushed a commit
that referenced
this pull request
May 14, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.1</summary> ## [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-14) ### Bug Fixes * Add type-fest as dependency due to build error ([3819688](3819688)) * **carousel:** Animate items with the same direction ([#9325](#9325)) ([6bf7b74](6bf7b74)) * **input, input-number, input-text:** Restore `autofocus`, `enter-key-mode` and `input-mode` attributes ([#9245](#9245)) ([#9306](#9306)) ([0498c6e](0498c6e)) * **list-item:** Decrease horizontal spacing between selection icon and content ([#9304](#9304)) ([0e828b6](0e828b6)) </details> <details><summary>@esri/calcite-components-angular: 2.8.1</summary> ## [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-14) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> <details><summary>@esri/calcite-components-react: 2.8.1</summary> ## [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-14) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benelan
pushed a commit
that referenced
this pull request
May 14, 2024
**Related Issue:** #9232 ## Summary Updates carousel to wait for item animations before each slide. **Note**: I'll submit a follow-up PR to refactor [`openCloseComponent.onToggleOpenCloseComponent`](https://github.com/Esri/calcite-design-system/blob/main/packages/calcite-components/src/utils/openCloseComponent.ts#L91) to use the same DOM util as carousel.
benelan
pushed a commit
that referenced
this pull request
May 14, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-14) * Add type-fest as dependency due to build error ([3819688](3819688)) * **carousel:** Animate items with the same direction ([#9325](#9325)) ([6bf7b74](6bf7b74)) * **input, input-number, input-text:** Restore `autofocus`, `enter-key-mode` and `input-mode` attributes ([#9245](#9245)) ([#9306](#9306)) ([0498c6e](0498c6e)) * **list-item:** Decrease horizontal spacing between selection icon and content ([#9304](#9304)) ([0e828b6](0e828b6)) </details> <details><summary>@esri/calcite-components-angular: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-14) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> <details><summary>@esri/calcite-components-react: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-14) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Merged
benelan
added a commit
that referenced
this pull request
May 14, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-14) * Add type-fest as dependency due to build error ([3819688](3819688)) * **carousel:** Animate items with the same direction ([#9325](#9325)) ([6bf7b74](6bf7b74)) * **input, input-number, input-text:** Restore `autofocus`, `enter-key-mode` and `input-mode` attributes ([#9245](#9245)) ([#9306](#9306)) ([0498c6e](0498c6e)) * **list-item:** Decrease horizontal spacing between selection icon and content ([#9304](#9304)) ([0e828b6](0e828b6)) </details> <details><summary>@esri/calcite-components-angular: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-14) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> <details><summary>@esri/calcite-components-react: 2.8.1</summary> [2.8.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-14) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.1-hotfix.0 to ^2.8.1 </details> --- This PR was generated with [ReleasePlease](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Calcite Admin <[email protected]>
Merged
jcfranco
added a commit
that referenced
this pull request
Jun 7, 2024
**Related Issue:** N/A ## Summary Stems from #9325 (comment). Consolidates transition/animation waiting logic and adds `whenTransitionDone` to DOM utils to complement `whenAnimationDone`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9232
Summary
Updates carousel to wait for item animations before each slide.
Note: I'll submit a follow-up PR to refactor
openCloseComponent.onToggleOpenCloseComponentto use the same DOM util as carousel.