Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[input-number] numeric keyboard no longer appears on mobile devices/tablets when input is focused #9740

Closed
2 of 6 tasks
jcfranco opened this issue Jul 6, 2024 · 2 comments
Closed
2 of 6 tasks

[input-number] numeric keyboard no longer appears on mobile devices/tablets when input is focused #9740

jcfranco opened this issue Jul 6, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. has workaround Issues have a workaround available in the meantime. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Milestone
2024-07-31 - Jul ...

Comments

@jcfranco
Copy link
Member

jcfranco commented Jul 6, 2024 •
edited
Loading

Check existing issues

Actual Behavior

The numeric keyboard no longer shows up on mobile devices/tablets when an input-number receives focus.

As a workaround, inputmode="decimal" (or inputMode property) can be set on the component.

Expected Behavior

For the numeric keyboard to show up when an input-number is focused on mobile/tablets.

Reproduction Sample

https://codepen.io/jcfranco/pen/dyBbwBx

Reproduction Steps

  1. Open the repro case on iOS or iPad
  2. Tap on the input
  3. Notice how the default virtual keyboard shows up (changing the version to 2.7.1 triggers the numeric keyboard when focused)

Reproduction Version

2.10.1

Relevant Info

2.8.0 introduced a regression (see https://github.com/Esri/calcite-design-system/pull/9123/files#diff-eb691ddf7a85985a3113e037a62db7b4c27bc134ac572baccecd23500f40c268L283) where input-number's inputMode property is no longer decimal.

Regression?

2.7.1

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 2 - in development Issues that are actively being worked on. p - medium Issue is non core or affecting less that 60% of people using the library has workaround Issues have a workaround available in the meantime. estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Jul 6, 2024
@jcfranco jcfranco self-assigned this Jul 6, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jul 6, 2024
@jcfranco jcfranco added this to the 2024-07-30 - Jul Release milestone Jul 6, 2024
@jcfranco jcfranco added impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone regression Issues that are caused by changes in a release, but were working before that. and removed ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. calcite-components Issues specific to the @esri/calcite-components package. labels Jul 6, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. labels Jul 6, 2024
@jcfranco jcfranco mentioned this issue Jul 6, 2024
Merged
jcfranco added a commit that referenced this issue Jul 11, 2024
@jcfranco
fix(input-number): restore decimal input mode default (#9741)
9264011 
**Related Issue:** #9740

## Summary

Restores `decimal` default for the internal input's `inputmode`, which
was unintentionally removed in
#9123.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 11, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Jul 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jul 12, 2024

🍡 Verified on 2.11.0-next.6 using iOS with Chrome, FireFox, and Safari

@DitwanP DitwanP closed this as completed Jul 12, 2024
@DitwanP DitwanP removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Jul 12, 2024
@DitwanP DitwanP added the 4 - verified Issues that have been released and confirmed resolved. label Jul 12, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@jcfranco @github-actions
fix(input-number): restore decimal input mode default (#9741)
1165dca 
**Related Issue:** #9740

## Summary

Restores `decimal` default for the internal input's `inputmode`, which
was unintentionally removed in
#9123.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. has workaround Issues have a workaround available in the meantime. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP