-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: restore some ESLint rules #9236
Conversation
I was wrong initially, these are all global attributes. |
Closing, I think the maquette VDOM library just needs to update its typings to support inputMode, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The revert
type should only be used when fully reverting a previous commit. Maybe we could use docs
or chore
instead, since that was the problem this PR resolves? For example:
chore: restore ESLint rule that removed ref for global attributes
Imo we should still have these documented if our components don't support all global attributes. |
Could you clarify this @benelan? What do you mean. Our components are web components which are HTML Elements. They do support all global attributes because of that nature. |
Okay cool, I wasn't sure if all global attributes were handled correctly or not since this PR was restoring custom logic for two of them. But if all global attributes are handled correctly then we don't need to document them. |
Related Issue: #9235
Summary
"@stencil-community/reserved-member-names": "warn",
to eslint config because eslint was preventing commits due to these props being reserved global attributes.