test(commonTests, alert, combobox, dropdown, input-date-picker, modal, popover, tooltip): extracts a general test utility OpenClose for all components implementing openCloseComponent util
#7379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sitionChainedEvents
github-actions
bot
added
the
testing
…enCloseComponents
Elijbet
added
the
skip visual snapshots
Elijbet
changed the title
emitsOpenCloseTransitionChainedEvents
…enCloseComponents
Is it ok if I wire up this helper in other components separately from this PR? I think it's going to bloat up the PR and make it hard to merge. I was hoping to address each case or several cases in a bunch within continuing PRs, so I can progressively adjust the util. |
I'd prefer to have the test helper cover all existing use cases from the get go. There's 6 other components that would need to be included, so I don't think it'll add much bloat since we're replacing any existing tests. |
jcfranco
reviewed
Jul 27, 2023
jcfranco
reviewed
Jul 30, 2023
packages/calcite-components/src/components/dropdown/resources.ts
Outdated
Show resolved
Hide resolved
…enCloseComponents
…or to extract a function with a common test
…enCloseComponents
Elijbet
added
the
refactor
…enCloseComponents
…se, so we should use it to keep that assosication
…se, so we should use it to keep that assosication
Elijbet
added
skip visual snapshots
…enCloseComponents
…enCloseComponents
…re descriptive example to the docs
…enCloseComponents
jcfranco
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️
🛠️🛠️🧪🧪🧪🛠️🛠️🧪🧪🛠️🛠️🛠️🧪🧪🛠️🛠️🧪🛠️🛠️🛠️🧪🛠️
🛠️🧪🛠️🛠️🛠️🛠️🧪🛠️🛠️🧪🛠️🧪🛠️🛠️🧪🛠️🧪🛠️🛠️🛠️🧪🛠️
🛠️🧪🛠️🛠️🛠️🛠️🧪🛠️🛠️🧪🛠️🧪🛠️🛠️🧪🛠️🧪🛠️🛠️🛠️🧪🛠️
🛠️🧪🛠️🛠️🛠️🛠️🧪🛠️🛠️🧪🛠️🧪🛠️🛠️🧪🛠️🧪🛠️🛠️🛠️🛠️🛠️
🛠️🛠️🧪🧪🧪🛠️🛠️🧪🧪🛠️🛠️🛠️🧪🧪🛠️🛠️🧪🧪🧪🛠️🧪🛠️
🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️🛠️
…enCloseComponents
Elijbet
deleted the
elijbet/4968-add-common-test-util-for-all-OpenCloseComponents
branch
github-actions
bot
added this to the 2023 September Priorities - Main release milestone
Elijbet
added a commit
that referenced
this pull request
Dec 21, 2023
…e commonTests helper (#8392) Remove e2e tests that are covered by the dedicated `openClose commonTests` helper. **Related Issue:** #8391, #7379 ## Summary Remove e2e tests that are covered by dedicated `openClose commonTests` helper to simplify test setup, ensure testing consistency across all `openClose` components, and enhance test maintainability.
benelan
pushed a commit
that referenced
this pull request
Dec 22, 2023
…nClose` commonTests helper (#8472) Remove e2e tests covered by the dedicated `openClose` commonTests helper. **Related Issue:** #8392, #7379 ## Summary Remove e2e tests covered by dedicated `openClose` commonTests helper to simplify test setup, ensure testing consistency across all openClose components, and enhance test maintainability.
jcfranco
added a commit
that referenced
this pull request
Sep 11, 2024
**Related Issue:** N/A ## Summary Removes `beforeToggle` option as it is not being used by any test. **Note:** It appears this option has not been used since it was introduced by #7379.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4968
Summary
Extracts a common test utility
openClosefor all components implementingopenCloseComponentutil.Implemented on all relevant components.