refactor(openClose): drop unused test helper options (#10250)

**Related Issue:** N/A ## Summary Removes `beforeToggle` option as it is not being used by any test. **Note:** It appears this option has not been used since it was introduced by #7379.
Esri · Sep 11, 2024 · 7caae86 · 7caae86
1 parent 3dfcdc1
commit 7caae86
Showing 1 changed file with 2 additions and 37 deletions.
diff --git a/packages/calcite-components/src/tests/commonTests/openClose.ts b/packages/calcite-components/src/tests/commonTests/openClose.ts
@@ -6,29 +6,12 @@ import { ComponentTag, ComponentTestSetup, WithBeforeContent } from "./interface
 
 expect.extend(toHaveNoViolations);
 
-interface BeforeToggle {
-  /**
-   * Function argument to simulate user input (mouse or keyboard), to open the component.
-   */
-  open: (page: E2EPage) => Promise<void>;
-
-  /**
-   * Function argument to simulate user input (mouse or keyboard), to close the component.
-   */
-  close: (page: E2EPage) => Promise<void>;
-}
-
 interface OpenCloseOptions {
   /**
    * Toggle property to test. Currently, either "open" or "expanded".
    */
   openPropName?: string;
 
-  /**
-   * Optional argument with functions to simulate user input (mouse or keyboard), to open or close the component.
-   */
-  beforeToggle?: BeforeToggle;
-
   /**
    * When `true`, the test will assert that the delays match those used when animation is disabled
    */
@@ -74,7 +57,6 @@ export function openClose(componentTestSetup: ComponentTestSetup, options?: Open
       tag,
       page,
       openPropName: effectiveOptions.openPropName,
-      beforeToggle: effectiveOptions.beforeToggle,
       animationsEnabled: !effectiveOptions.willUseFallback,
     });
   });
@@ -87,7 +69,6 @@ export function openClose(componentTestSetup: ComponentTestSetup, options?: Open
     await setUpEventListeners(tag, page);
     await testOpenCloseEvents({
       animationsEnabled: false,
-      beforeToggle: effectiveOptions.beforeToggle,
       openPropName: effectiveOptions.openPropName,
       page,
       tag,
@@ -123,7 +104,6 @@ openClose.initial = function openCloseInitial(
     await setUpEventListeners(tag, page);
     await testOpenCloseEvents({
       animationsEnabled: true,
-      beforeToggle: effectiveOptions.beforeToggle,
       openPropName: effectiveOptions.openPropName,
       page,
       startOpen: true,
@@ -140,7 +120,6 @@ openClose.initial = function openCloseInitial(
     await setUpEventListeners(tag, page);
     await testOpenCloseEvents({
       animationsEnabled: false,
-      beforeToggle: effectiveOptions.beforeToggle,
       openPropName: effectiveOptions.openPropName,
       page,
       startOpen: true,
@@ -170,11 +149,6 @@ interface TestOpenCloseEventsParams {
    */
   startOpen?: boolean;
 
-  /**
-   * Functions to simulate user input (mouse or keyboard) to open or close the component.
-   */
-  beforeToggle?: BeforeToggle;
-
   /**
    * Whether animations are enabled.
    */
@@ -183,7 +157,6 @@ interface TestOpenCloseEventsParams {
 
 async function testOpenCloseEvents({
   animationsEnabled,
-  beforeToggle,
   openPropName,
   page,
   startOpen = false,
@@ -232,11 +205,7 @@ async function testOpenCloseEvents({
   await page.waitForChanges();
 
   if (!startOpen) {
-    if (beforeToggle) {
-      await beforeToggle.open(page);
-    } else {
-      element.setProperty(openPropName, true);
-    }
+    element.setProperty(openPropName, true);
   }
 
   await page.waitForChanges();
@@ -245,11 +214,7 @@ async function testOpenCloseEvents({
 
   assertEventSequence([1, 1, 0, 0]);
 
-  if (startOpen || !beforeToggle) {
-    element.setProperty(openPropName, false);
-  } else {
-    await beforeToggle.close(page);
-  }
+  element.setProperty(openPropName, false);
 
   await page.waitForChanges();
   await beforeCloseEvent;