Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(modal): remove e2e tests that are covered by the dedicated openClose commonTests helper #8472

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Dec 21, 2023

Remove e2e tests covered by the dedicated openClose commonTests helper.

Related Issue: #8392, #7379

Summary

Remove e2e tests covered by dedicated openClose commonTests helper to simplify test setup, ensure testing consistency across all openClose components, and enhance test maintainability.

@Elijbet Elijbet requested a review from a team as a code owner December 21, 2023 02:03
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Dec 21, 2023
@Elijbet Elijbet changed the title chore(modal): remove e2e tests that are covered by dedicated openClose commonTests helper chore(modal): remove e2e tests that are covered by dedicated openClose commonTests helper Dec 21, 2023
@Elijbet Elijbet changed the title chore(modal): remove e2e tests that are covered by dedicated openClose commonTests helper chore(modal): remove e2e tests that are covered by the dedicated openClose commonTests helper Dec 21, 2023
@Elijbet Elijbet added skip visual snapshots Pull requests that do not need visual regression testing. low risk Issues with low risk for consideration in low risk milestones labels Dec 21, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@benelan benelan merged commit 92b3f07 into main Dec 22, 2023
11 checks passed
@benelan benelan deleted the elijbet/8391-remove-e2e-modal-tests-covered-by-openClose-commonTests branch December 22, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. low risk Issues with low risk for consideration in low risk milestones skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants