Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(modal): update e2e tests with the dedicated openClose commonTests helper #8391

Closed
1 of 5 tasks
Elijbet opened this issue Dec 11, 2023 · 3 comments
Closed
1 of 5 tasks

chore(modal): update e2e tests with the dedicated openClose commonTests helper #8391

Elijbet opened this issue Dec 11, 2023 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Dec 11, 2023

Description

Substitute e2e tests on modal with the new openClose commonTests helper that covers all of the existing cases.

Proposed Advantages

This will simplify test setup, ensure testing consistency across all our openClose components, and enhance test maintainability.

Which Component

modal

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@Elijbet Elijbet added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 11, 2023
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Dec 11, 2023
@Elijbet Elijbet self-assigned this Dec 11, 2023
@Elijbet
Copy link
Contributor Author

Elijbet commented Dec 11, 2023 •
edited
Loading

We have 4 cases with emit on [initialization] with animations enabled/disabled. The only difference in the old setup that the helper doesn't cover is the user-initiated click option. Is there any significance in setting the open property directly versus calling a click method?

I will go ahead and start on swapping the old tests with the new helper, and if this component has any specific testing considerations, we should enhance the helper instead with the missing options.

@jcfranco

@Elijbet Elijbet changed the title chore: substitute e2e tests on modal with the new openClose commonTests test helper chore: update e2e tests on modal with the dedicated openClose commonTests helper Dec 11, 2023
@Elijbet Elijbet changed the title chore: update e2e tests on modal with the dedicated openClose commonTests helper chore(modal): update e2e tests with the dedicated openClose commonTests helper Dec 11, 2023
@Elijbet Elijbet added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Dec 11, 2023
@Elijbet Elijbet mentioned this issue Dec 11, 2023
Merged
Elijbet added a commit that referenced this issue Dec 21, 2023
@Elijbet
chore(modal): remove e2e tests that are covered by dedicated openClos…
6e7cff1 
…e commonTests helper (#8392)

Remove e2e tests that are covered by the dedicated `openClose
commonTests` helper.

**Related Issue:** #8391, #7379

## Summary

Remove e2e tests that are covered by dedicated `openClose commonTests`
helper to simplify test setup, ensure testing consistency across all
`openClose` components, and enhance test maintainability.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 16, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned Elijbet May 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@jcfranco
Copy link
Member

Is there any significance in setting the open property directly versus calling a click method?

Not at the moment, as open/close events emit whether triggered by user interaction or directly setting the open prop. We can enhance the helper as you suggested if this changes later (see #8453 (comment)).

Closing as verified.

@jcfranco jcfranco added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @Elijbet @DitwanP