Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a common test util for all OpenCloseComponents #4968

Closed
driskull opened this issue Jul 19, 2022 · 2 comments
Closed

Add a common test util for all OpenCloseComponents #4968

driskull opened this issue Jul 19, 2022 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. tooling Issues relating to build system fixes or improvements.
Milestone
2023 September Pr...

Comments

@driskull
Copy link
Member

driskull commented Jul 19, 2022 •
edited by jcfranco
Loading

Description

Add a common test util for all OpenCloseComponents.

Acceptance Criteria

A common utility to handle #4962 (review)

Relevant Info

#4962 (review)

Which Component

All openCloseComponents

Example Use Case

No response
@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 19, 2022
@driskull driskull mentioned this issue Jul 19, 2022
Merged
@Elijbet Elijbet self-assigned this Jul 19, 2022
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Mar 30, 2023
@jcfranco jcfranco changed the title Add a common test util for all OpenCloseComponents that covers only emitting when necessary Add a common test util for all OpenCloseComponents Jul 10, 2023
@jcfranco jcfranco mentioned this issue Jul 10, 2023
Closed
@Elijbet Elijbet added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 24, 2023
@Elijbet Elijbet mentioned this issue Jul 25, 2023
Merged
7 tasks
Elijbet added a commit that referenced this issue Sep 19, 2023
@Elijbet
test(commonTests, alert, combobox, dropdown, input-date-picker, modal…
996e2b9 
…, popover, tooltip): extracts a general test utility `OpenClose` for all components implementing `openCloseComponent` util (#7379)

**Related Issue:** #4968

## Summary
Extracts a common test utility `openClose` for all components
implementing `openCloseComponent` util.

Implemented on all relevant components. 

- [x] alert
- [x] combobox
- [x] dropdown
- [x] input-date-picker
- [x] modal
- [x] popover
- [x] tooltip
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 19, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and unassigned Elijbet Sep 19, 2023
@geospatialem geospatialem added tooling Issues relating to build system fixes or improvements. and removed enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Sep 20, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 20, 2023
@geospatialem
Copy link
Member

Verified on the main branch. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
2023 September Priorities - Main release
Development

No branches or pull requests
4 participants
@driskull @alisonailea @geospatialem @Elijbet