Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tile Group] Create new component #8615

Closed
6 of 10 tasks
geospatialem opened this issue Jan 16, 2024 · 2 comments
Closed
6 of 10 tasks

[Tile Group] Create new component #8615

geospatialem opened this issue Jan 16, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. c-tile Issues that pertain to the calcite-tile and related components Calcite (design) Issues logged by Calcite designers. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive new component Issues tied to a new component. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2024-02-27 - Feb ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Jan 16, 2024 •
edited
Loading

Check existing issues

Description

Create a new component, tile-group, which will deprecate the tile-select-group component and consumes the new consolidated tile component, with responsive design in mind via #6662.

Acceptance Criteria

Refer to https://www.figma.com/file/8CiAVHkXIMTsI9hTSbotEz/Tile-Redesign-%5BEpic-6662%5D?node-id=720%3A2738&mode=dev for the specs on tile-group. cc @SkyeSeitz

  • Create a new tile-group component
  • Deprecate the tile-select-group component
  • Consume the newly consolidated tile component
  • Adds the scale property

image

Relevant Info

Breaks up the addition of the scale attr/prop from #4759.

Which Component

  • tile-group (new)
  • related to tile-select-group and tile

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. new component Issues tied to a new component. p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. Calcite (design) Issues logged by Calcite designers. labels Jan 16, 2024
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. labels Jan 16, 2024
This was referenced Jan 16, 2024
Closed
Closed
@eriklharper eriklharper added the c-tile Issues that pertain to the calcite-tile and related components label Jan 16, 2024
@eriklharper eriklharper mentioned this issue Jan 16, 2024
Closed
38 tasks
@eriklharper eriklharper added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 17, 2024
@geospatialem geospatialem changed the title [Tile Group] Create new component + support scale prop [Tile Group] Create new component Jan 18, 2024
@geospatialem geospatialem mentioned this issue Jan 25, 2024
Closed
4 tasks
@brittneytewks brittneytewks added the estimate - 8 Requires input from team, consider smaller steps. label Jan 29, 2024
@eriklharper eriklharper mentioned this issue Feb 2, 2024
Merged
eriklharper added a commit that referenced this issue Feb 20, 2024
@eriklharper
feat(tile-group): add responsive Tile Group component (#8687)
bf0c906 
**Related Issues:** #8615 #6691 #6662

## Summary

This PR adds the new `calcite-tile-group` component. It includes these
responsiveness features that address #6691:

- Wrapped Tiles match width of Tiles above
- Wrapped Tiles match height of tallest Tile in the group

The changes in this PR were extracted from and depend on the changes in
#8681.

---------

Co-authored-by: Erik Harper <[email protected]>
@eriklharper eriklharper mentioned this issue Feb 22, 2024
Merged
jcfranco pushed a commit that referenced this issue Feb 22, 2024
@eriklharper
feat(tile-group): add Tile Group component (#8806)
4f65bdd 
**Related Issues:** #8615 #6691 #6662

## Summary

This PR adds the new `calcite-tile-group` component. It includes these
responsiveness features that address #6691:

- Wrapped Tiles match width of Tiles above
- Wrapped Tiles match height of tallest Tile in the group

The changes in this PR were extracted from and depend on the changes in
#8681.

---------

Co-authored-by: Erik Harper <[email protected]>
@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 23, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned eriklharper Feb 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Feb 26, 2024
@geospatialem geospatialem added the 4 - verified Issues that have been released and confirmed resolved. label Feb 26, 2024
@geospatialem
Copy link
Member Author

Verified in 2.6.0-next.1 with https://codepen.io/geospatialem/pen/yLwmjrW.*

* Note that the deprecation of tile-select-group was not part of the attached PR, instead we'll work on the deprecation once the effort of #6662 is complete, targeted for April.

<calcite-tile-group layout="vertical" scale="s">
  <calcite-tile heading="Tile heading lorem ipsum" description="Leverage agile frameworks to provide a robust synopsis for high level overviews. Iterative approaches to corporate strategy foster collab on thinking to further the overall." icon="layers"></calcite-tile>
  <calcite-tile heading="Tile heading lorem ipsum" description="Leverage agile frameworks to provide a robust synopsis for high level overviews. Iterative approaches to corporate strategy foster collab on thinking to further the overall." icon="layers"></calcite-tile>
  <calcite-tile heading="Tile heading lorem ipsum" description="Leverage agile frameworks to provide a robust synopsis for high level overviews. Iterative approaches to corporate strategy foster collab on thinking to further the overall." icon="layers"></calcite-tile>
  <calcite-tile heading="Tile heading lorem ipsum" description="Leverage agile frameworks to provide a robust synopsis for high level overviews. Iterative approaches to corporate strategy foster collab on thinking to further the overall." icon="layers"></calcite-tile>
</calcite-tile-group>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. c-tile Issues that pertain to the calcite-tile and related components Calcite (design) Issues logged by Calcite designers. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive new component Issues tied to a new component. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2024-02-27 - Feb Maintenance Release
Development

No branches or pull requests
4 participants
@eriklharper @geospatialem @DitwanP @brittneytewks