Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tile Group] Responsive layout #6691

Closed
5 tasks
brittneytewks opened this issue Mar 28, 2023 · 7 comments
Closed
5 tasks

[Tile Group] Responsive layout #6691

brittneytewks opened this issue Mar 28, 2023 · 7 comments
Assignees
@geospatialem @DitwanP
Labels
c-tile Issues that pertain to the calcite-tile and related components Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Milestone
2024-02-27 - Feb ...

Comments

@brittneytewks
Copy link

brittneytewks commented Mar 28, 2023 •
edited by geospatialem
Loading

Description

Responsiveness across Calcite Design System, focused on web (traditionally desktop sized web browser), tablet, phone screen sizes, and large monitors.

Acceptance Criteria

Task breakdown:

  1. Consider breaking changes for folks. Consultation should occur on both the design and development teams.
  2. Components need to be designed for the following breakpoints:
  • Small (s), 476px
  • Medium (m), 768px
  • Large (l), 1152px
  • Extra larger (xl), 1440px

Relevant Info

No response

Which Component

tile-group

Example Use Case

No response

Priority impact

p4 - not time sensitive

Esri team

Calcite (design)
@brittneytewks brittneytewks added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. Calcite (design) Issues logged by Calcite designers. estimate - 8 Requires input from team, consider smaller steps. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Mar 28, 2023
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Mar 28, 2023
@brittneytewks brittneytewks mentioned this issue Mar 28, 2023
Closed
27 tasks
@brittneytewks brittneytewks changed the title [Tile-select-group] Responsive Layout [Tile Select Group] Responsive layout Mar 28, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed needs triage Planning workflow - pending design/dev review. 0 - new New issues that need assignment. labels Mar 30, 2023
@brittneytewks brittneytewks added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Mar 31, 2023
@SkyeSeitz SkyeSeitz self-assigned this Apr 14, 2023
@SkyeSeitz
Copy link

I will be rolling responsive layout considerations into the Tile redesign epic in June.

@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label May 4, 2023
@geospatialem geospatialem mentioned this issue May 4, 2023
Closed
38 tasks
@macandcheese macandcheese added the c-tile Issues that pertain to the calcite-tile and related components label May 5, 2023
@ashetland ashetland removed this from the Design Sprint Next milestone Aug 18, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 23, 2023
@eriklharper
Copy link
Contributor

eriklharper commented Dec 6, 2023 •
edited
Loading

I will be rolling responsive layout considerations into the Tile redesign epic in June.

@SkyeSeitz Since this is part of the Tile redesign epic, does that mean we won't apply responsiveness changes to the planned-to-be-deprecated Tile Select Group/Tile Select components?

@SkyeSeitz
Copy link

Discussed and decided to roll responsiveness into the Tile & Tile Group redesign to avoid applying new functionality to Tile Select and Tile Select Group which will be deprecated shortly after in favor of Tile and Tile Group.

@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 12, 2023
@eriklharper eriklharper changed the title [Tile Select Group] Responsive layout [Tile Group] Responsive layout Dec 29, 2023
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Dec 29, 2023
@geospatialem geospatialem mentioned this issue Jan 16, 2024
Closed
10 tasks
@geospatialem
Copy link
Member

Closing as effort will instead focus on responsive layout with the effort of the tile redesign and new component tile-group in #6662 and #8615 respectively.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
This was referenced Feb 1, 2024
Closed
Merged
eriklharper added a commit that referenced this issue Feb 20, 2024
@eriklharper
feat(tile-group): add responsive Tile Group component (#8687)
bf0c906 
**Related Issues:** #8615 #6691 #6662

## Summary

This PR adds the new `calcite-tile-group` component. It includes these
responsiveness features that address #6691:

- Wrapped Tiles match width of Tiles above
- Wrapped Tiles match height of tallest Tile in the group

The changes in this PR were extracted from and depend on the changes in
#8681.

---------

Co-authored-by: Erik Harper <[email protected]>
@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned eriklharper Feb 21, 2024
@eriklharper eriklharper mentioned this issue Feb 22, 2024
Merged
jcfranco pushed a commit that referenced this issue Feb 22, 2024
@eriklharper
feat(tile-group): add Tile Group component (#8806)
4f65bdd 
**Related Issues:** #8615 #6691 #6662

## Summary

This PR adds the new `calcite-tile-group` component. It includes these
responsiveness features that address #6691:

- Wrapped Tiles match width of Tiles above
- Wrapped Tiles match height of tallest Tile in the group

The changes in this PR were extracted from and depend on the changes in
#8681.

---------

Co-authored-by: Erik Harper <[email protected]>
@geospatialem geospatialem removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
c-tile Issues that pertain to the calcite-tile and related components Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-02-27 - Feb Maintenance Release
Development

No branches or pull requests
7 participants
@eriklharper @macandcheese @geospatialem @SkyeSeitz @DitwanP @ashetland @brittneytewks