-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tile-group): add responsive Tile Group component #8687
feat(tile-group): add responsive Tile Group component #8687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Some things I saw in local testing:
This hover state needs some adjustment:
I'm also unable to see a focus outline when focused - the Tile is focused as I can navigate with keyboard "Enter" when href
is present but there isn't a visual indication.
Should there be keyboard support for arrow / home / end within these groups? If so, would it change based on layout
?
This PR is just about adding responsive layout features. I intend on addressing this in follow-up PRs tied to the #6662 epic. |
packages/calcite-components/src/components/tile-group/tile-group.scss
Outdated
Show resolved
Hide resolved
…t tests focusing focusable child tiles
…klharper/8615-tile-group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
(design) - should there be a hover state that is distinct from focus state? Right now they are the same cc @SkyeSeitz @ashetland
This reverts commit bf0c906.
Related Issues: #8615 #6691 #6662
Summary
This PR adds the new
calcite-tile-group
component. It includes these responsiveness features that address #6691:The changes in this PR were extracted from and depend on the changes in #8681.