feat(tile-group): add Tile Group component #8806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t tests focusing focusable child tiles
…klharper/8615-tile-group
…klharper/8615-tile-group
github-actions
bot
added
the
enhancement
eriklharper
added
the
pr ready for visual snapshots
eriklharper
added
pr ready for visual snapshots
jcfranco
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Awesome! 🚀 Approving to get this landed, but let's address comments in a separate PR.
Also, can we add a usage file for this new component (see https://github.com/Esri/calcite-design-system/blob/main/packages/calcite-components/conventions/Documentation.md#usage-snippets)?
packages/calcite-components/src/components/tile-group/tile-group.stories.ts
Show resolved
Hide resolved
packages/calcite-components/src/components/tile-group/tile-group.stories.ts
Show resolved
Hide resolved
driskull
approved these changes
Feb 22, 2024
| //-------------------------------------------------------------------------- | ||
|
|
||
| private updateTiles = (): void => { | ||
| this.el.querySelectorAll("calcite-tile").forEach((item) => (item.scale = this.scale)); |
There was a problem hiding this comment.
Maybe for future but can we get the slotted assigned elements instead of querying the dom?
Agreed. Good catch! |
jcfranco
added
the
low risk
Merged
eriklharper
added a commit
that referenced
this pull request
Feb 23, 2024
**Related Issue:** #8806 ## Summary This is a follow-up for #8806, addressing comments in the review. No changes to functionality. --------- Co-authored-by: Erik Harper <[email protected]>
geospatialem
pushed a commit
that referenced
this pull request
Feb 27, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.6.0</summary> ## [2.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-02-27) ### Features * **card-group:** Add Card Group component ([#8749](#8749)) ([b012324](b012324)) * **tile-group:** Add Tile Group component ([#8806](#8806)) ([4f65bdd](4f65bdd)) ### Bug Fixes * **combobox:** Long text truncates on single and single-persist modes ([#8731](#8731)) ([8fc42b1](8fc42b1)) * **navigation-logo:** No longer changes icon color when `href` is parsed ([#8830](#8830)) ([16d456f](16d456f)) * Only show validation message when status='invalid' ([#8649](#8649)) ([7eac8d7](7eac8d7)) * **preset:** Calcite—color-brand to calcite-color-brand ([#8809](#8809)) ([ee2cf4e](ee2cf4e)) * **table:** Ensure border are correctly applied with complex rowSpan ([#8779](#8779)) ([69f05d4](69f05d4)) </details> <details><summary>@esri/calcite-components-angular: 2.6.0</summary> ## [2.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-02-27) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.6.0-next.3 to ^2.6.0 </details> <details><summary>@esri/calcite-components-react: 2.6.0</summary> ## [2.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-02-27) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.6.0-next.3 to ^2.6.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues: #8615 #6691 #6662
Summary
This PR adds the new
calcite-tile-groupcomponent. It includes these responsiveness features that address #6691:The changes in this PR were extracted from and depend on the changes in #8681.