fix: only show validation message when status='invalid' #8649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelan
added
the
pr ready for visual snapshots
github-actions
bot
added
the
bug
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
benelan
added
pr ready for visual snapshots
Merged
geospatialem
pushed a commit
that referenced
this pull request
Feb 27, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.6.0</summary> ## [2.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-02-27) ### Features * **card-group:** Add Card Group component ([#8749](#8749)) ([b012324](b012324)) * **tile-group:** Add Tile Group component ([#8806](#8806)) ([4f65bdd](4f65bdd)) ### Bug Fixes * **combobox:** Long text truncates on single and single-persist modes ([#8731](#8731)) ([8fc42b1](8fc42b1)) * **navigation-logo:** No longer changes icon color when `href` is parsed ([#8830](#8830)) ([16d456f](16d456f)) * Only show validation message when status='invalid' ([#8649](#8649)) ([7eac8d7](7eac8d7)) * **preset:** Calcite—color-brand to calcite-color-brand ([#8809](#8809)) ([ee2cf4e](ee2cf4e)) * **table:** Ensure border are correctly applied with complex rowSpan ([#8779](#8779)) ([69f05d4](69f05d4)) </details> <details><summary>@esri/calcite-components-angular: 2.6.0</summary> ## [2.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-02-27) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.6.0-next.3 to ^2.6.0 </details> <details><summary>@esri/calcite-components-react: 2.6.0</summary> ## [2.6.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-02-27) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.6.0-next.3 to ^2.6.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The validation message for form components should only be displayed when the
statusproperty is "invalid".