Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tile] Add visual scales #4759

Closed
macandcheese opened this issue Jun 16, 2022 · 5 comments
Closed

[Tile] Add visual scales #4759

macandcheese opened this issue Jun 16, 2022 · 5 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. c-tile Issues that pertain to the calcite-tile and related components design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Milestone
2024-01-17 - Jan ...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jun 16, 2022 •
edited by eriklharper
Loading

Description

We should bring these components in line with others by adding additional scales to provide S, M, L.

Acceptance Criteria

Additional scales are added to these components, and to the Figma component library.

Relevant Info

No response

Which Component

Tile / Tile Group

Example Use Case

No response
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 16, 2022
@driskull driskull added the design Issues that need design consultation prior to development. label Jun 29, 2022
@ptmdmusique ptmdmusique mentioned this issue Dec 7, 2022
Closed
@geospatialem geospatialem mentioned this issue Mar 25, 2023
Closed
38 tasks
@macandcheese macandcheese added the c-tile Issues that pertain to the calcite-tile and related components label May 5, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed needs triage Planning workflow - pending design/dev review. 0 - new New issues that need assignment. labels May 5, 2023
@ashetland ashetland assigned SkyeSeitz and unassigned ashetland May 30, 2023
@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Sep 12, 2023
@SkyeSeitz
Copy link

Link to Figma specs: https://www.figma.com/file/8CiAVHkXIMTsI9hTSbotEz/Tile-Redesign-%5BEpic-6662%5D?type=design&node-id=720%3A2738&mode=dev

@SkyeSeitz SkyeSeitz added the ready for dev Issues ready for development implementation. label Sep 25, 2023
@SkyeSeitz SkyeSeitz removed their assignment Sep 25, 2023
@github-actions github-actions bot added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 25, 2023
@github-actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@brittneytewks brittneytewks added the p - medium Issue is non core or affecting less that 60% of people using the library label Oct 24, 2023
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 22, 2023
@geospatialem geospatialem added this to the 2024 April Priorities milestone Nov 22, 2023
@eriklharper eriklharper self-assigned this Dec 5, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 12, 2023
@eriklharper eriklharper added 2 - in development Issues that are actively being worked on. estimate - 3 A day or two of work, likely requires updates to tests. estimate - 5 A few days of work, definitely requires updates to tests. and removed 0 - new New issues that need assignment. estimate - 3 A day or two of work, likely requires updates to tests. labels Dec 13, 2023
@eriklharper eriklharper changed the title [Tile / Tile Select / Tile Select Group] Add visual scales [Tile / Tile Group] Add visual scales Dec 15, 2023
This was referenced Dec 22, 2023
Open
Merged
eriklharper added a commit that referenced this issue Jan 12, 2024
@eriklharper
feat(tile): add visual scales (#8496)
7638ec4 
**Related Issue:** #4759 

## Summary

This PR adds a `scale` property to control visual display for small,
medium and large scales.

---------

Co-authored-by: Erik Harper <[email protected]>
@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 12, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned eriklharper Jan 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 16, 2024
@geospatialem
Copy link
Member

Verified in 2.2.0-next.18 when tile's scale is set to "s", "m", or "l" ("m" is the default).

image

cc @SkyeSeitz + @eriklharper It looks like the original ask was for both tile and tile-group. The Figma file mentions adding a new tile-group component, but I'm not seeing the addition in the code. Is that part of this issue, or a different issue? Want to verify before closing the above out. TIA! 🙌🏻

image

@geospatialem geospatialem mentioned this issue Jan 16, 2024
Closed
10 tasks
@geospatialem
Copy link
Member

Closing with tile completed per #4759 (comment), and tile-group will be addressed in next months release with #8615.

@eriklharper eriklharper changed the title [Tile / Tile Group] Add visual scales [Tile] Add visual scales Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. c-tile Issues that pertain to the calcite-tile and related components design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2024-01-17 - Jan Main Release
Development

No branches or pull requests
9 participants
@eriklharper @driskull @alisonailea @macandcheese @geospatialem @SkyeSeitz @DitwanP @ashetland @brittneytewks