Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.61.x] [incident-33304] Mark dogstatsd e2e tests as flaky #32237

Closed
wants to merge 1 commit into from

Conversation

agent-platform-auto-pr[bot]
Copy link
Contributor

Backport 2daad7f from #32220.


What does this PR do?

Mark Test(?:EKS|Kind)Suite/TestDogstatsd(?:InAgent|Standalone)/metric___custom.metric{^kube_deployment:dogstatsd-udp$,^kube_namespace:workload-dogstatsd$} as flaky.

Motivation

The merge of DataDog/test-infra-definitions#1299 broke those tests and we need time to investigate if this PR is only making a bug in the admission controller more visible or if it’s the tests that were wrong and that need to be fixed.

Describe how you validated your changes

<!--
Validate your changes before merge, ensuring that:

  • Your PR is tested by static / unit / integrations / e2e tests
  • Your PR description details which e2e tests cover your changes, if any
  • The PR description contains details of how you validated your changes. If you validated changes manually and not through automated tests, add context on why automated tests did not fit your changes validation.

If you want additional validation by a second person, you can ask reviewers to do it. Describe how to set up an environment for manual tests in the PR description. Manual validation is expected to happen on every commit before merge.

Any manual validation step should then map to an automated test. Manual validation should not substitute automation, minus exceptions not supported by test tooling yet.
-->

Possible Drawbacks / Trade-offs

Additional Notes

<!--

  • Anything else we should know when reviewing?
  • Include benchmarking information here whenever possible.
  • Include info about alternatives that were considered and why the proposed
    version was chosen.
    -->

incident-33304

@agent-platform-auto-pr agent-platform-auto-pr bot added team/containers dev/testing changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation backport bot short review PR is simple enough to be reviewed quickly labels Dec 16, 2024
@agent-platform-auto-pr
Copy link
Contributor Author

[Fast Unit Tests Report]

On pipeline 51226546 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 277f9948-b892-44fe-b036-bbf860003fe6

Baseline: 8c991a8
Comparison: ad76b1a
Diff

Optimization Goals: ❌ Regression(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +5.10 [+1.03, +9.16] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +5.10 [+1.03, +9.16] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.37 [-0.42, +1.15] 1 Logs
quality_gate_idle memory utilization +0.05 [+0.01, +0.09] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.61, +0.64] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.10, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.00 [-0.10, +0.09] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.74, +0.71] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.83, +0.80] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.03 [-0.80, +0.74] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.12 [-0.58, +0.34] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.25 [-0.98, +0.49] 1 Logs
quality_gate_idle_all_features memory utilization -0.60 [-0.71, -0.49] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput -0.66 [-1.38, +0.05] 1 Logs
file_tree memory utilization -0.78 [-0.93, -0.63] 1 Logs
quality_gate_logs % cpu utilization -1.47 [-4.44, +1.49] 1 Logs
pycheck_lots_of_tags % cpu utilization -3.33 [-6.81, +0.15] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Copy link
Member

@L3n41c L3n41c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should backport #32222 instead: #32268.

@L3n41c
Copy link
Member

L3n41c commented Dec 17, 2024

Superseded by #32268.

@L3n41c L3n41c closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bot changelog/no-changelog dev/testing qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant