Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datadog-go lib in dogstatsd app #1299

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Dec 13, 2024

What does this PR do?

Update the datadog-go lib now that v5.6.0 has been released: https://github.com/DataDog/datadog-go/releases/tag/v5.6.0.

Which scenarios this will impact?

Motivation

Get rid of replace statement in go.mod.

It also fixes an issue where container tags are missing from dogstatsd metrics because the library fails to identify the container:
image

Additional Notes

@L3n41c L3n41c requested a review from a team as a code owner December 13, 2024 12:40
@L3n41c
Copy link
Member Author

L3n41c commented Dec 13, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 13, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-13 13:58:32 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-13 17:58:36 UTC ⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

@pducolin
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 16, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-16 10:01:48 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 2m.


2024-12-16 10:03:04 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants