Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.61.x] [incident-33304] Expect container tags on dogstatsd metrics #32268

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

agent-platform-auto-pr[bot]
Copy link
Contributor

Backport 626f570 from #32222.


What does this PR do?

Expect container tags on dogstatsd metrics in all scenarios.

Motivation

With the latest improvements of origin detection, the agent is now able to figure out the origin container in all cases.

Describe how you validated your changes

Run e2e tests.

Possible Drawbacks / Trade-offs

Additional Notes

<!--

  • Anything else we should know when reviewing?
  • Include benchmarking information here whenever possible.
  • Include info about alternatives that were considered and why the proposed
    version was chosen.
    -->

incident-33304

@agent-platform-auto-pr agent-platform-auto-pr bot requested review from a team as code owners December 16, 2024 20:57
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Dec 16, 2024
@agent-platform-auto-pr
Copy link
Contributor Author

[Fast Unit Tests Report]

On pipeline 51266106 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor Author

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=51266106 --os-family=ubuntu

Note: This applies to commit d058fc1

@L3n41c
Copy link
Member

L3n41c commented Dec 17, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 17, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-17 08:36:16 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in 7.61.x is 26m.


2024-12-17 09:04:27 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit c3a01f3 into 7.61.x Dec 17, 2024
285 of 286 checks passed
@dd-mergequeue dd-mergequeue bot deleted the backport-32222-to-7.61.x branch December 17, 2024 09:04
@github-actions github-actions bot added this to the 7.61.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bot changelog/no-changelog dev/testing qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants