Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incident-33304] Expect container tags on dogstatsd metrics #32222

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Dec 16, 2024

What does this PR do?

Expect container tags on dogstatsd metrics in all scenarios.

Motivation

With the latest improvements of origin detection, the agent is now able to figure out the origin container in all cases.

Describe how you validated your changes

Run e2e tests.

Possible Drawbacks / Trade-offs

Additional Notes

incident-33304

Verified

This commit was signed with the committer’s verified signature.
L3n41c Lénaïc Huard

Verified

This commit was signed with the committer’s verified signature.
L3n41c Lénaïc Huard
@L3n41c L3n41c added team/containers dev/testing changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 16, 2024
@L3n41c L3n41c added this to the 7.62.0 milestone Dec 16, 2024
@L3n41c L3n41c requested review from a team as code owners December 16, 2024 13:10
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 16, 2024
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 16, 2024

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Co-authored-by: Wassim Dhif <wassim.dhif@datadoghq.com>
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 16, 2024

[Fast Unit Tests Report]

On pipeline 51201039 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 93555c374bbd1beb399d9f1306047344296219ff

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.01MB ⚠️ 1003.97MB 1003.96MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB ⚠️ 1013.18MB 1013.18MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.52MB 78.52MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.74MB 55.74MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.42MB 505.42MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.28MB 113.28MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.35MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.35MB 113.35MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.76MB 108.76MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.83MB 108.83MB 10.00MB
datadog-agent-amd64-deb -0.01MB 1268.87MB 1268.88MB 140.00MB
datadog-agent-x86_64-rpm -0.01MB 1278.11MB 1278.12MB 140.00MB
datadog-agent-x86_64-suse -0.01MB 1278.11MB 1278.12MB 140.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51201039 --os-family=ubuntu

Note: This applies to commit 58a15da

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9d37bcff-2e1d-4a08-8649-63b018f431ea

Baseline: 93555c3
Comparison: 58a15da
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.64 [-1.32, +4.61] 1 Logs
quality_gate_idle memory utilization +0.97 [+0.92, +1.03] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput +0.46 [-0.21, +1.12] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.42 [-0.32, +1.15] 1 Logs
quality_gate_idle_all_features memory utilization +0.22 [+0.08, +0.35] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.19 [-0.59, +0.98] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.09 [-0.67, +0.86] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.04 [-0.83, +0.92] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.80, +0.84] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.09, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.62] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.76, +0.71] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.04 [-0.95, +0.87] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.13 [-0.59, +0.34] 1 Logs
file_tree memory utilization -0.91 [-1.04, -0.78] 1 Logs
tcp_syslog_to_blackhole ingress throughput -2.13 [-2.20, -2.05] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency_http1 lost_bytes 9/10
file_to_blackhole_500ms_latency lost_bytes 9/10
quality_gate_idle_all_features memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.

@L3n41c
Copy link
Member Author

L3n41c commented Dec 16, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 16, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-16 16:14:17 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 34m.


2024-12-16 17:08:25 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 626f570 into main Dec 16, 2024
222 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lenaic/incident-33304_2 branch December 16, 2024 17:08
@L3n41c L3n41c added backport/7.59.x Automatically create a backport PR to 7.59.x backport/7.60.x Automatically create a backport PR to 7.60.x backport/7.61.x Automatically create a backport PR to 7.61.x labels Dec 16, 2024
@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.60.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.60.x 7.60.x
# Navigate to the new working tree
cd .worktrees/backport-7.60.x
# Create a new branch
git switch --create backport-32222-to-7.60.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 626f570cf380d1c1fc680ccb85934e5abcb24a9b
# Push it to GitHub
git push --set-upstream origin backport-32222-to-7.60.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.60.x

Then, create a pull request where the base branch is 7.60.x and the compare/head branch is backport-32222-to-7.60.x.

@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.59.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.59.x 7.59.x
# Navigate to the new working tree
cd .worktrees/backport-7.59.x
# Create a new branch
git switch --create backport-32222-to-7.59.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 626f570cf380d1c1fc680ccb85934e5abcb24a9b
# Push it to GitHub
git push --set-upstream origin backport-32222-to-7.59.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.59.x

Then, create a pull request where the base branch is 7.59.x and the compare/head branch is backport-32222-to-7.59.x.

agent-platform-auto-pr bot pushed a commit that referenced this pull request Dec 16, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Co-authored-by: Wassim Dhif <wassim.dhif@datadoghq.com>
(cherry picked from commit 626f570)
L3n41c added a commit that referenced this pull request Dec 16, 2024

Verified

This commit was signed with the committer’s verified signature.
L3n41c Lénaïc Huard
L3n41c added a commit that referenced this pull request Dec 16, 2024

Verified

This commit was signed with the committer’s verified signature.
L3n41c Lénaïc Huard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.59.x Automatically create a backport PR to 7.59.x backport/7.60.x Automatically create a backport PR to 7.60.x backport/7.61.x Automatically create a backport PR to 7.61.x changelog/no-changelog dev/testing medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants