Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.59.x] [incident-33304] Expect container tags on dogstatsd metrics #32270

Closed
wants to merge 1 commit into from

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Dec 16, 2024

Backport 626f570 from #32222.


What does this PR do?

Expect container tags on dogstatsd metrics in all scenarios.

Motivation

With the latest improvements of origin detection, the agent is now able to figure out the origin container in all cases.

Describe how you validated your changes

Run e2e tests.

Possible Drawbacks / Trade-offs

Additional Notes

incident-33304

@L3n41c L3n41c added team/containers dev/testing changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 16, 2024
@L3n41c L3n41c added this to the 7.59.0 milestone Dec 16, 2024
@L3n41c L3n41c requested review from a team as code owners December 16, 2024 21:23
@L3n41c L3n41c changed the title [Backport 7.59.x] [incident-33304] Expect container tags on dogstatsd metrics (#32222) [Backport 7.59.x] [incident-33304] Expect container tags on dogstatsd metrics Dec 16, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 51268742 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=51268742 --os-family=ubuntu

Note: This applies to commit ddb4f92

Copy link

Regression Detector

@L3n41c
Copy link
Member Author

L3n41c commented Dec 17, 2024

No fixes need to be backported to 7.59.x.

@L3n41c L3n41c closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants