PrivateEndpoint & PrivateLinkService APIs update #6332

bowen0106 · 2019-06-13T06:23:48Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-06-13T06:25:14Z

Automation for azure-sdk-for-java

A PR has been created for you:
Azure/azure-sdk-for-java#3952

AutorestCI · 2019-06-13T06:25:34Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp6oded9o3/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp6oded9o3/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4385)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[6124:0x271acc0]    88419 ms: Mark-sweep 1381.8 (1425.8) -> 1381.5 (1426.3) MB, 1306.4 / 0.0 ms  (average mu = 0.091, current mu = 0.002) allocation failure scavenge might not succeed
[6124:0x271acc0]    90298 ms: Mark-sweep 1382.3 (1426.3) -> 1382.0 (1426.8) MB, 1861.3 / 0.0 ms  (average mu = 0.048, current mu = 0.009) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x2d1d4c09e6e9 <JSObject>
    0: builtin exit frame: stringify(this=0x2d1d4c091a21 <Object map = 0x3d7508d042a9>,0x3443456826f1 <undefined>,0x3443456826f1 <undefined>,0x1e94ae6cf639 <JSArray[8]>,0x2d1d4c091a21 <Object map = 0x3d7508d042a9>)

    1: arguments adaptor frame: 1->3
    2: IdentitySourceMapping [0x379522bcc999] [/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-cor...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xe9f655  [node]
11: 0xea6eca v8::internal::Factory::NewRawOneByteString(int, v8::internal::PretenureFlag) [node]
12: 0x11d69d0 v8::internal::IncrementalStringBuilder::IncrementalStringBuilder(v8::internal::Isolate*) [node]
13: 0xf99459 v8::internal::JsonStringifier::JsonStringifier(v8::internal::Isolate*) [node]
14: 0xba90ec v8::internal::Builtin_JsonStringify(int, v8::internal::Object**, v8::internal::Isolate*) [node]
15: 0x34c085a5bf7d

AutorestCI · 2019-06-13T06:26:03Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5185

AutorestCI · 2019-06-13T06:27:28Z

Automation for azure-sdk-for-js

Encountered a Subprocess error: (azure-sdk-for-js)

Command: ['/usr/local/bin/autorest', '/tmp/tmp5ozm8qja/rest/specification/network/resource-manager/readme.md', '--license-header=MICROSOFT_MIT_NO_VERSION', '--typescript', '--typescript-sdks-folder=/tmp/tmp5ozm8qja/azure-sdk-for-js', '[email protected]/[email protected]']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4299)
   Loading AutoRest extension '@microsoft.azure/autorest.typescript' (4.0.0->4.0.0)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.51->2.3.51)

<--- Last few GCs --->

[2604:0x406e860]   176978 ms: Mark-sweep 1404.6 (1490.2) -> 1404.6 (1490.7) MB, 1825.4 / 0.0 ms  allocation failure GC in old space requested
[2604:0x406e860]   178611 ms: Mark-sweep 1404.6 (1490.7) -> 1404.6 (1455.2) MB, 1632.1 / 0.0 ms  last resort GC in old space requested
[2604:0x406e860]   180201 ms: Mark-sweep 1404.6 (1455.2) -> 1404.6 (1451.2) MB, 1590.3 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x28613b0a5879 <JSObject>
    1: readLineBreak(aka readLineBreak) [/node_modules/yaml-ast-parser/dist/src/loader.js:~300] [pc=0xc787dd49b22](this=0x201ac2c022d1 <undefined>,state=0x268433f59589 <State map = 0x5f20ff20081>)
    2: readFlowCollection(aka readFlowCollection) [/node_modules/yaml-ast-parser/dist/src/loader.js:~596] [pc=0xc787dd41060](this=0x201ac2c022d1 <undefined>,state=0x268433f59589 <State map = 0x5f20ff20...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewUninitializedFixedArray(int) [node]
 6: 0xd7fc13 [node]
 7: v8::internal::Runtime_GrowArrayElements(int, v8::internal::Object**, v8::internal::Isolate*) [node]
 8: 0xc787d7842fd

AutorestCI · 2019-06-13T06:30:59Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

azuresdkci · 2019-06-13T07:23:53Z

Can one of the admins verify this patch?

EvgenyAgafonchikov

Left some comments.

I also ran validation tools on the API, could you please also take a look into below? Likely we can change this API (I believe we can while in preview).

There is a pair of warning related to missing scheme in response (inserted below). When I tested UpdatePrivateEndpointConnection previous time, it returned connection body if I remember correctly. Please re-check this fact and update with scheme value if so.

PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateLinkServices_UpdatePrivateEndpointConnection
200/201 Responses of long running operations must have a schema definition for return type.

...rk/resource-manager/Microsoft.Network/stable/2019-04-01/autoApprovedPrivateLinkServices.json

EvgenyAgafonchikov · 2019-06-13T10:00:18Z

.../resource-manager/Microsoft.Network/stable/2019-04-01/checkPrivateLinkServiceVisibility.json

+  "paths": {
+    "/subscriptions/{subscriptionId}/providers/Microsoft.Network/locations/{location}/checkPrivateLinkServiceVisibility": {
+      "post": {
+        "operationId": "CheckPrivateLinkServiceVisibility",


Please check if this expected operation name (i.e. plain operation name instead of Class_Operation form).
Current value would place this operation directly under INetworkManagementClient like CheckDnsNameAvailability

Thanks for the suggestion, I was thinking that the cmdlet that under different path from private link service, should be a separate operation id. But since both you and Anton is suggested, I have already changed the operation id to merge them into private endpoint. This make code looks more neat. Thanks.

anton-evseev · 2019-06-13T14:26:01Z

Given that two new APIs are related to PrivateLinkServices, maybe it would be better to add them to privateLinkServices.json instead of creating two new files?

specification/network/resource-manager/readme.md

EvgenyAgafonchikov · 2019-06-18T09:36:27Z

Could you please review my comment above (response schema related). Adding previously recorded traffic for more context (there is response body received from server):

DEBUG: ============================ HTTP REQUEST ============================

HTTP Method:
PUT

Absolute Uri:
https://management.azure.com/subscriptions/<ID>/resourceGroups/test-evg/providers/Microsoft.Network/privateLinkServices/test/privateEndpointConnections/test.
19b38612-9576-4036-88d2-dc34e0cb5b18?api-version=2019-04-01

Body:
{
  "properties": {
    "privateEndpoint": {
      "properties": {
        "privateLinkServiceConnections": [],
        "manualPrivateLinkServiceConnections": []
      },
      "id": "/subscriptions/<ID>/resourceGroups/test-evg/providers/Microsoft.Network/privateEndpoints/test",
      "tags": {}
    },
    "privateLinkServiceConnectionState": {
      "status": "Rejected",
      "description": "change"
    }
  },
  "name": "test.19b38612-9576-4036-88d2-dc34e0cb5b18",
  "id":
"/subscriptions/<ID>/resourceGroups/test-evg/providers/Microsoft.Network/privateLinkServices/test/privateEndpointConnections/test.19b38612-9576-4036-88d2-dc34e0cb5b18"
}

DEBUG: ============================ HTTP RESPONSE ============================

Status Code:
OK

Body:
{
  "name": "test.19b38612-9576-4036-88d2-dc34e0cb5b18",
  "id":
"/subscriptions/<ID>/resourceGroups/test-evg/providers/Microsoft.Network/privateLinkServices/test/privateEndpointConnections/test.19b38612-9576-4036-88d2-dc34e0cb5b18",
  "etag": "W/\"0cd819b1-aa1c-4ccc-ae61-de4928d37de0\"",
  "properties": {
    "provisioningState": "Updating",
    "privateEndpoint": {
      "id": "/subscriptions/<ID>/resourceGroups/test-evg/providers/Microsoft.Network/privateEndpoints/test"
    },
    "privateLinkServiceConnectionState": {
      "status": "Rejected",
      "description": "change",
      "actionsRequired": ""
    }
  },
  "type": "Microsoft.Network/privateLinkServices/privateEndpointConnections"
}

anton-evseev

Comments for both 2019-04-01 and 2019-06-01

specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/privateEndpoint.json

...ication/network/resource-manager/Microsoft.Network/stable/2019-04-01/privateLinkService.json

EvgenyAgafonchikov · 2019-06-19T10:55:13Z

specification/network/resource-manager/Microsoft.Network/stable/2019-06-01/privateEndpoint.json

@@ -306,7 +306,7 @@
    },
    "/subscriptions/{subscriptionId}/providers/Microsoft.Network/locations/{location}/availablePrivateEndpointTypes": {
      "get": {
-        "operationId": "AvailablePrivateEndpointTypes_List",
+        "operationId": "PrivateEndpoints_ListAvailablePrivateEndpointTypes",


This kind of naming seems to trigger new warnings like this:

Per the Noun_Verb convention for Operation Ids, the noun 'PrivateEndpoints' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.

Could you please consider naming operations w/o noun on the right side of underscore? E.g. PrivateEndpoints_ListAvailableTypes or something like this.

Please also check the same for other operations.
Cmd to check locally:
azure-rest-api-specs\specification\network\resource-manager>autorest --azure-validator --openapi-type=arm

Hi Evgeny, the AvailablePrivateEndpointType is a single noun. It's a single class type, different from privateEndpoint. So let's consider to still use 'PrivateEndpoints_ListAvailablePrivateEndpointTypes'. Thank you.

I haven't noticed this earlier, but AvailablePrivateEndpointTypes.List has already been published in Network SDK and is being used in Azure PowerShell. So changing it would be a breaking change and we wouldn't want that. Could you please revert this change?
Also, I think in this case we would also need to change PrivateEndpoints_ListPrivateEndpointAvailableTypesByResourceGroup to AvailablePrivateEndpointTypes_ListByResourceGroup to keep consistent naming with List/ListByResourceGroup pair.

@number213 Thanks , that was my concern too. I have already revert it back and add _ListByResourceGroup.

anton-evseev · 2019-06-25T14:27:21Z

@KrisBash could you please give feedback from ARM's side?

ravbhatnagar

looks fine, just one minor note.

ravbhatnagar · 2019-06-27T20:53:41Z

specification/network/resource-manager/Microsoft.Network/stable/2019-04-01/privateEndpoint.json

+          "type": "string",
+          "description": "Resource type."
+        },
+        "resourceName": {


can we call this something else? providerNamespace? its not resource name. its the resourceType name of the onboarded service. resource name can be confusing.

@ravbhatnagar Thanks for reviewing. I agreed with you. The name sounds inaccuracy. In design doc, it is called 'ServiceName' and in the NRP code it's 'ResouceName' , both are not good, but in order to works with NRP side correctly , I changed the name accordingly. So I guess we should leave it unless RP have changed.

ravbhatnagar · 2019-06-27T22:52:23Z

Signing off from ARM side with one minor comment. Not blocking but good to fix

tjprescott · 2019-06-28T15:52:58Z

What's up with the JS SDK failing?

weinong · 2019-06-28T18:36:05Z

@tjprescott @number213 who can help look at the SDK issue?

anton-evseev · 2019-07-01T10:15:25Z

I think this is the step that was removed by @sergey-shandar (#6391). My guess is that it's deprecated and Network's release branch is out of sync with master.

weinong · 2019-07-01T17:51:23Z

@bowen0106 can you try rebase your branch?

…rt privateIp. Minor modify on readme.md file.

…o its json file.

…ntType get null property.

…EndpointConnect. 2. Change opertaion id for opertaions that relative to private endpoint and private link service.

…us name.

…body content that contains a private link service alias string. 2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter.

sauryadas · 2019-07-02T21:52:53Z

@shahabhijeet can you please with the go sdk generation? or point to someone who can help?

shahabhijeet · 2019-07-02T21:57:24Z

@jhendrixMSFT will the right person who can help you with Go SDK related questions.

jhendrixMSFT · 2019-07-02T22:12:40Z

The build errors are a known issue for network (not just Go is affected). I'm following up with the owners of the swagger-to-sdk job but for now the failures can be ignored.

jhendrixMSFT · 2019-07-02T22:40:14Z

@AutorestCI regenerate azure-sdk-for-go

lmazuel · 2019-07-02T22:52:05Z

@AutorestCI regenerate azure-sdk-for-go

AutorestCI · 2019-07-02T23:28:21Z

Encountered an unknown error

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/bot_framework.py", line 105, in manage_comment
    response = getattr(self.handler, orderstr)(webhook_data.issue, *split_text)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/restbot.py", line 54, in regenerate
    return self.rebuild(issue, repotag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/restbot.py", line 36, in rebuild
    self.sdk_default_base
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 310, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', branch_name, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git push --set-upstream origin restapi_auto_6332
  stderr: 'To https://github.com/Azure/azure-sdk-for-go.git
 ! [rejected]            restapi_auto_6332 -> restapi_auto_6332 (fetch first)
error: failed to push some refs to 'https://AutorestCI:[email protected]/Azure/azure-sdk-for-go.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.'

sauryadas · 2019-07-03T17:32:31Z

@jhendrixMSFT who's the owner of the swagger to sdk job? we really need this PR to merge ASAP so we can start our work on AKS private clusters which is scheduled to go in preview in 6 weeks.

jhendrixMSFT · 2019-07-03T17:34:52Z

This was resolved yesterday by @lmazuel. Regardless you can still merge the PR.

* Adds base for updating Microsoft.Network from version stable/2019-04-01 to version 2019-06-01 * Updates readme * Updates API version in new specs and examples * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… (#6164) * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration properties. * Fixed LB examples * Fix examples in 2019-06-01 * Remove API version number in privateIPAddressVersion description. * Add privateIPAddressVersion in LoadBalancer examples. * Add privateIPAddressVersion in 2019-06-01 API version. * Update specs to avoid readOnly in the request body (#6228) * typo: netowork May double word the (#6206) * Update cipher suites (#6213) * removing resource group name from PrepareNetworkPoliciesRequest (#6232) * Add exception for property "Conditon" in Network's webapplicationfirewall.json (#6335) * Extend long-running ops fixes to new API version; Suppression (#6336) * Update long-running for new API version * Add suppression for new API * Updated examples to have valid bodies for live put (#6349) * More examples fix after live testing (#6382) * Improved more examples after live testing * Fix validations * Improve descriptions in Network to align with Swagger guidelines (#6350) * Improve descriptions in Network to align with Swagger guidelines * Fix for CI * More examples improvements (#6444) * Add PATCH to Azure Firewall supported operations (#6486) * Add PATCH to Azure Firewall supported operations * Name the parameter how validation expects it * Patch is not a long running operation, so update the specs accordingly * PrivateEndpoint & PrivateLinkService APIs update (#6332) * Add two properties on Subnet for privateIp. Add two new APIs to support privateIp. Minor modify on readme.md file. * Fix some issue found by Model Validation. * Merge all apis relative to private end point / private link service to its json file. * Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property. * Change AutoApprovedPrivateLinkService structure to fit with NRP side. * Delete suppress for merged APIs in readme.md. * 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect. 2. Change opertaion id for opertaions that relative to private endpoint and private link service. * Minor fix for model validation. * Revert opertion id changes for AvailablePrivateEndpointType to previous name. * 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string. 2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter. * Improve Network's examples (#6493) * Removed read-only props from VPNGW example * Fixed LoadBalancer examples: * "outboundRules" array isn't returned for "Basic" SKU load balancer * added example for external LB with outboundRules * added missing read-only properties * Replace "regionName" in examples with real location * Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer * chore: jsonfmt network (#6592) * Adding VpnSiteLink and VpnSiteLinkConnection properties. (#6528) * Added VpnSiteLink/VpnSiteLinkConnection operations. * Sdk changes for vpn site link. * Fixing error. * Fixing more comments. * Fixing json error. * Fixing json files. * Fixing comments. * Fixing more issues. * Fixing more errors. * Fixing more error. * Prettify JSON in VpnConnectionGet.json * Resolving more comments. * Fixing typo. * Adding type in examples of put. * Removing Child resource type. * chore: jsonfmt network-may * Fix incorrect examples

* Adds base for updating Microsoft.Network from version stable/2019-04-01 to version 2019-06-01 * Updates readme * Updates API version in new specs and examples * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… (Azure#6164) * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration properties. * Fixed LB examples * Fix examples in 2019-06-01 * Remove API version number in privateIPAddressVersion description. * Add privateIPAddressVersion in LoadBalancer examples. * Add privateIPAddressVersion in 2019-06-01 API version. * Update specs to avoid readOnly in the request body (Azure#6228) * typo: netowork May double word the (Azure#6206) * Update cipher suites (Azure#6213) * removing resource group name from PrepareNetworkPoliciesRequest (Azure#6232) * Add exception for property "Conditon" in Network's webapplicationfirewall.json (Azure#6335) * Extend long-running ops fixes to new API version; Suppression (Azure#6336) * Update long-running for new API version * Add suppression for new API * Updated examples to have valid bodies for live put (Azure#6349) * More examples fix after live testing (Azure#6382) * Improved more examples after live testing * Fix validations * Improve descriptions in Network to align with Swagger guidelines (Azure#6350) * Improve descriptions in Network to align with Swagger guidelines * Fix for CI * More examples improvements (Azure#6444) * Add PATCH to Azure Firewall supported operations (Azure#6486) * Add PATCH to Azure Firewall supported operations * Name the parameter how validation expects it * Patch is not a long running operation, so update the specs accordingly * PrivateEndpoint & PrivateLinkService APIs update (Azure#6332) * Add two properties on Subnet for privateIp. Add two new APIs to support privateIp. Minor modify on readme.md file. * Fix some issue found by Model Validation. * Merge all apis relative to private end point / private link service to its json file. * Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property. * Change AutoApprovedPrivateLinkService structure to fit with NRP side. * Delete suppress for merged APIs in readme.md. * 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect. 2. Change opertaion id for opertaions that relative to private endpoint and private link service. * Minor fix for model validation. * Revert opertion id changes for AvailablePrivateEndpointType to previous name. * 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string. 2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter. * Improve Network's examples (Azure#6493) * Removed read-only props from VPNGW example * Fixed LoadBalancer examples: * "outboundRules" array isn't returned for "Basic" SKU load balancer * added example for external LB with outboundRules * added missing read-only properties * Replace "regionName" in examples with real location * Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer * chore: jsonfmt network (Azure#6592) * Adding VpnSiteLink and VpnSiteLinkConnection properties. (Azure#6528) * Added VpnSiteLink/VpnSiteLinkConnection operations. * Sdk changes for vpn site link. * Fixing error. * Fixing more comments. * Fixing json error. * Fixing json files. * Fixing comments. * Fixing more issues. * Fixing more errors. * Fixing more error. * Prettify JSON in VpnConnectionGet.json * Resolving more comments. * Fixing typo. * Adding type in examples of put. * Removing Child resource type. * chore: jsonfmt network-may * Fix incorrect examples

bowen0106 requested a review from MikhailTryakhov as a code owner June 13, 2019 06:23

azuresdkci assigned tjprescott Jun 13, 2019

azuresdkci requested a review from tjprescott June 13, 2019 06:24

EvgenyAgafonchikov reviewed Jun 13, 2019

View reviewed changes

anton-evseev suggested changes Jun 17, 2019

View reviewed changes

specification/network/resource-manager/readme.md Outdated Show resolved Hide resolved

tjprescott added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 17, 2019

AutorestCI mentioned this pull request Jun 17, 2019

[AutoPR network/resource-manager] PrivateEndpoint & PrivateLinkService APIs update Azure/azure-sdk-for-java#3952

Merged

anton-evseev reviewed Jun 18, 2019

View reviewed changes

anton-evseev approved these changes Jun 19, 2019

View reviewed changes

EvgenyAgafonchikov reviewed Jun 19, 2019

View reviewed changes

anton-evseev self-requested a review June 20, 2019 12:35

bowen0106 force-pushed the bowen/network-may-pe branch from 9a07258 to 21db5c3 Compare June 20, 2019 17:35

anton-evseev approved these changes Jun 20, 2019

View reviewed changes

ravbhatnagar reviewed Jun 27, 2019

View reviewed changes

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 27, 2019

bowen0106 added 10 commits July 1, 2019 12:13

Add two properties on Subnet for privateIp. Add two new APIs to suppo…

17a742d

…rt privateIp. Minor modify on readme.md file.

Fix some issue found by Model Validation.

1890021

Merge all apis relative to private end point / private link service t…

09f6341

…o its json file.

Fix a typo name from design spec that casue GetAvailablePrivateEndpoi…

b162573

…ntType get null property.

Change AutoApprovedPrivateLinkService structure to fit with NRP side.

738d205

Delete suppress for merged APIs in readme.md.

90533f9

1. Change value to PrivateEndpointConnection when calling put Private…

ebf2a13

…EndpointConnect. 2. Change opertaion id for opertaions that relative to private endpoint and private link service.

Minor fix for model validation.

ee428ab

Revert opertion id changes for AvailablePrivateEndpointType to previo…

9418d48

…us name.

1. Change CheckPrivateLinkServiceVisibility API, the input now has a …

768782d

…body content that contains a private link service alias string. 2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter.

bowen0106 force-pushed the bowen/network-may-pe branch from 69a6005 to 768782d Compare July 1, 2019 19:15

AutorestCI mentioned this pull request Jul 2, 2019

[AutoPR network/resource-manager] PrivateEndpoint & PrivateLinkService APIs update Azure/azure-sdk-for-go#5185

Merged

tjprescott merged commit bf45d1d into Azure:network-may-release Jul 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PrivateEndpoint & PrivateLinkService APIs update #6332

PrivateEndpoint & PrivateLinkService APIs update #6332

bowen0106 commented Jun 13, 2019 •

edited

Loading

AutorestCI commented Jun 13, 2019 •

edited

Loading

AutorestCI commented Jun 13, 2019 •

edited

Loading

AutorestCI commented Jun 13, 2019 •

edited

Loading

AutorestCI commented Jun 13, 2019 •

edited

Loading

AutorestCI commented Jun 13, 2019 •

edited

Loading

azuresdkci commented Jun 13, 2019

EvgenyAgafonchikov left a comment

EvgenyAgafonchikov Jun 13, 2019

bowen0106 Jun 18, 2019

anton-evseev commented Jun 13, 2019

EvgenyAgafonchikov commented Jun 18, 2019

anton-evseev left a comment

EvgenyAgafonchikov Jun 19, 2019 •

edited

Loading

bowen0106 Jun 19, 2019

anton-evseev Jun 20, 2019

bowen0106 Jun 20, 2019

anton-evseev commented Jun 25, 2019

ravbhatnagar left a comment

ravbhatnagar Jun 27, 2019

bowen0106 Jun 27, 2019

ravbhatnagar commented Jun 27, 2019

tjprescott commented Jun 28, 2019

weinong commented Jun 28, 2019

anton-evseev commented Jul 1, 2019

weinong commented Jul 1, 2019

sauryadas commented Jul 2, 2019

shahabhijeet commented Jul 2, 2019

jhendrixMSFT commented Jul 2, 2019

jhendrixMSFT commented Jul 2, 2019

lmazuel commented Jul 2, 2019

AutorestCI commented Jul 2, 2019

sauryadas commented Jul 3, 2019

jhendrixMSFT commented Jul 3, 2019

PrivateEndpoint & PrivateLinkService APIs update #6332

PrivateEndpoint & PrivateLinkService APIs update #6332

Conversation

bowen0106 commented Jun 13, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Jun 13, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jun 13, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jun 13, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jun 13, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Jun 13, 2019 • edited Loading

Automation for azure-sdk-for-ruby

azuresdkci commented Jun 13, 2019

EvgenyAgafonchikov left a comment

Choose a reason for hiding this comment

EvgenyAgafonchikov Jun 13, 2019

Choose a reason for hiding this comment

bowen0106 Jun 18, 2019

Choose a reason for hiding this comment

anton-evseev commented Jun 13, 2019

EvgenyAgafonchikov commented Jun 18, 2019

anton-evseev left a comment

Choose a reason for hiding this comment

EvgenyAgafonchikov Jun 19, 2019 • edited Loading

Choose a reason for hiding this comment

bowen0106 Jun 19, 2019

Choose a reason for hiding this comment

anton-evseev Jun 20, 2019

Choose a reason for hiding this comment

bowen0106 Jun 20, 2019

Choose a reason for hiding this comment

anton-evseev commented Jun 25, 2019

ravbhatnagar left a comment

Choose a reason for hiding this comment

ravbhatnagar Jun 27, 2019

Choose a reason for hiding this comment

bowen0106 Jun 27, 2019

Choose a reason for hiding this comment

ravbhatnagar commented Jun 27, 2019

tjprescott commented Jun 28, 2019

weinong commented Jun 28, 2019

anton-evseev commented Jul 1, 2019

weinong commented Jul 1, 2019

sauryadas commented Jul 2, 2019

shahabhijeet commented Jul 2, 2019

jhendrixMSFT commented Jul 2, 2019

jhendrixMSFT commented Jul 2, 2019

lmazuel commented Jul 2, 2019

AutorestCI commented Jul 2, 2019

sauryadas commented Jul 3, 2019

jhendrixMSFT commented Jul 3, 2019

bowen0106 commented Jun 13, 2019 •

edited

Loading

AutorestCI commented Jun 13, 2019 •

edited

Loading

AutorestCI commented Jun 13, 2019 •

edited

Loading

AutorestCI commented Jun 13, 2019 •

edited

Loading

AutorestCI commented Jun 13, 2019 •

edited

Loading

AutorestCI commented Jun 13, 2019 •

edited

Loading

EvgenyAgafonchikov Jun 19, 2019 •

edited

Loading