-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated examples to have valid bodies for live put #6349
Merged
sergey-shandar
merged 1 commit into
Azure:network-may-release
from
EvgenyAgafonchikov:2019-06-01-ex
Jun 17, 2019
Merged
Updated examples to have valid bodies for live put #6349
sergey-shandar
merged 1 commit into
Azure:network-may-release
from
EvgenyAgafonchikov:2019-06-01-ex
Jun 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-goUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-pythonUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-javaEncountered an unknown error: (azure-sdk-for-java)
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 384, in _make_request
six.raise_from(e, None)
File "<string>", line 2, in raise_from
File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 380, in _make_request
httplib_response = conn.getresponse()
File "/usr/lib/python3.6/http/client.py", line 1331, in getresponse
response.begin()
File "/usr/lib/python3.6/http/client.py", line 297, in begin
version, status, reason = self._read_status()
File "/usr/lib/python3.6/http/client.py", line 258, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/usr/lib/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
File "/usr/lib/python3.6/ssl.py", line 1012, in recv_into
return self.read(nbytes, buffer)
File "/usr/lib/python3.6/ssl.py", line 874, in read
return self._sslobj.read(len, buffer)
File "/usr/lib/python3.6/ssl.py", line 631, in read
v = self._sslobj.read(len, buffer)
socket.timeout: The read operation timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/requests/adapters.py", line 449, in send
timeout=timeout
File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 638, in urlopen
_stacktrace=sys.exc_info()[2])
File "/usr/local/lib/python3.6/dist-packages/urllib3/util/retry.py", line 368, in increment
raise six.reraise(type(error), error, _stacktrace)
File "/usr/local/lib/python3.6/dist-packages/urllib3/packages/six.py", line 686, in reraise
raise value
File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 600, in urlopen
chunked=chunked)
File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 386, in _make_request
self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
File "/usr/local/lib/python3.6/dist-packages/urllib3/connectionpool.py", line 306, in _raise_timeout
raise ReadTimeoutError(self, url, "Read timed out. (read timeout=%s)" % timeout_value)
urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='api.github.com', port=443): Read timed out. (read timeout=15)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
yield context
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 95, in rest_pr_management
dashboard.create_comment("Unable to detect any generation context from this PR.")
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 340, in create_comment
return DashboardComment.get_or_create(self._issue_or_pr, self._header, text)
File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 351, in get_or_create
for comment in get_comments(issue):
File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 64, in __iter__
newElements = self._grow()
File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 76, in _grow
newElements = self._fetchNextPage()
File "/usr/local/lib/python3.6/dist-packages/github/PaginatedList.py", line 201, in _fetchNextPage
headers=self.__headers
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 275, in requestJsonAndCheck
return self.__check(*self.requestJson(verb, url, parameters, headers, input, self.__customConnection(url)))
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 335, in requestJson
return self.__requestEncode(cnx, verb, url, parameters, headers, input, encode)
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 388, in __requestEncode
status, responseHeaders, output = self.__requestRaw(cnx, verb, url, requestHeaders, encoded_input)
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 412, in __requestRaw
response = cnx.getresponse()
File "/usr/local/lib/python3.6/dist-packages/github/Requester.py", line 114, in getresponse
r = verb(url, headers=self.headers, data=self.input, timeout=self.timeout, verify=self.verify, allow_redirects=False)
File "/usr/local/lib/python3.6/dist-packages/requests/sessions.py", line 546, in get
return self.request('GET', url, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/requests/sessions.py", line 533, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.6/dist-packages/requests/sessions.py", line 646, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.6/dist-packages/requests/adapters.py", line 529, in send
raise ReadTimeout(e, request=request)
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='api.github.com', port=443): Read timed out. (read timeout=15) |
Automation for azure-sdk-for-jsUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-rubyUnable to detect any generation context from this PR. |
Can one of the admins verify this patch? |
sergey-shandar
approved these changes
Jun 17, 2019
sergey-shandar
pushed a commit
that referenced
this pull request
Jul 16, 2019
* Adds base for updating Microsoft.Network from version stable/2019-04-01 to version 2019-06-01 * Updates readme * Updates API version in new specs and examples * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… (#6164) * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration properties. * Fixed LB examples * Fix examples in 2019-06-01 * Remove API version number in privateIPAddressVersion description. * Add privateIPAddressVersion in LoadBalancer examples. * Add privateIPAddressVersion in 2019-06-01 API version. * Update specs to avoid readOnly in the request body (#6228) * typo: netowork May double word the (#6206) * Update cipher suites (#6213) * removing resource group name from PrepareNetworkPoliciesRequest (#6232) * Add exception for property "Conditon" in Network's webapplicationfirewall.json (#6335) * Extend long-running ops fixes to new API version; Suppression (#6336) * Update long-running for new API version * Add suppression for new API * Updated examples to have valid bodies for live put (#6349) * More examples fix after live testing (#6382) * Improved more examples after live testing * Fix validations * Improve descriptions in Network to align with Swagger guidelines (#6350) * Improve descriptions in Network to align with Swagger guidelines * Fix for CI * More examples improvements (#6444) * Add PATCH to Azure Firewall supported operations (#6486) * Add PATCH to Azure Firewall supported operations * Name the parameter how validation expects it * Patch is not a long running operation, so update the specs accordingly * PrivateEndpoint & PrivateLinkService APIs update (#6332) * Add two properties on Subnet for privateIp. Add two new APIs to support privateIp. Minor modify on readme.md file. * Fix some issue found by Model Validation. * Merge all apis relative to private end point / private link service to its json file. * Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property. * Change AutoApprovedPrivateLinkService structure to fit with NRP side. * Delete suppress for merged APIs in readme.md. * 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect. 2. Change opertaion id for opertaions that relative to private endpoint and private link service. * Minor fix for model validation. * Revert opertion id changes for AvailablePrivateEndpointType to previous name. * 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string. 2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter. * Improve Network's examples (#6493) * Removed read-only props from VPNGW example * Fixed LoadBalancer examples: * "outboundRules" array isn't returned for "Basic" SKU load balancer * added example for external LB with outboundRules * added missing read-only properties * Replace "regionName" in examples with real location * Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer * chore: jsonfmt network (#6592) * Adding VpnSiteLink and VpnSiteLinkConnection properties. (#6528) * Added VpnSiteLink/VpnSiteLinkConnection operations. * Sdk changes for vpn site link. * Fixing error. * Fixing more comments. * Fixing json error. * Fixing json files. * Fixing comments. * Fixing more issues. * Fixing more errors. * Fixing more error. * Prettify JSON in VpnConnectionGet.json * Resolving more comments. * Fixing typo. * Adding type in examples of put. * Removing Child resource type. * chore: jsonfmt network-may * Fix incorrect examples
celikcigdem
pushed a commit
to celikcigdem/azure-rest-api-specs
that referenced
this pull request
Jul 17, 2019
* Adds base for updating Microsoft.Network from version stable/2019-04-01 to version 2019-06-01 * Updates readme * Updates API version in new specs and examples * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… (Azure#6164) * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration properties. * Fixed LB examples * Fix examples in 2019-06-01 * Remove API version number in privateIPAddressVersion description. * Add privateIPAddressVersion in LoadBalancer examples. * Add privateIPAddressVersion in 2019-06-01 API version. * Update specs to avoid readOnly in the request body (Azure#6228) * typo: netowork May double word the (Azure#6206) * Update cipher suites (Azure#6213) * removing resource group name from PrepareNetworkPoliciesRequest (Azure#6232) * Add exception for property "Conditon" in Network's webapplicationfirewall.json (Azure#6335) * Extend long-running ops fixes to new API version; Suppression (Azure#6336) * Update long-running for new API version * Add suppression for new API * Updated examples to have valid bodies for live put (Azure#6349) * More examples fix after live testing (Azure#6382) * Improved more examples after live testing * Fix validations * Improve descriptions in Network to align with Swagger guidelines (Azure#6350) * Improve descriptions in Network to align with Swagger guidelines * Fix for CI * More examples improvements (Azure#6444) * Add PATCH to Azure Firewall supported operations (Azure#6486) * Add PATCH to Azure Firewall supported operations * Name the parameter how validation expects it * Patch is not a long running operation, so update the specs accordingly * PrivateEndpoint & PrivateLinkService APIs update (Azure#6332) * Add two properties on Subnet for privateIp. Add two new APIs to support privateIp. Minor modify on readme.md file. * Fix some issue found by Model Validation. * Merge all apis relative to private end point / private link service to its json file. * Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property. * Change AutoApprovedPrivateLinkService structure to fit with NRP side. * Delete suppress for merged APIs in readme.md. * 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect. 2. Change opertaion id for opertaions that relative to private endpoint and private link service. * Minor fix for model validation. * Revert opertion id changes for AvailablePrivateEndpointType to previous name. * 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string. 2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter. * Improve Network's examples (Azure#6493) * Removed read-only props from VPNGW example * Fixed LoadBalancer examples: * "outboundRules" array isn't returned for "Basic" SKU load balancer * added example for external LB with outboundRules * added missing read-only properties * Replace "regionName" in examples with real location * Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer * chore: jsonfmt network (Azure#6592) * Adding VpnSiteLink and VpnSiteLinkConnection properties. (Azure#6528) * Added VpnSiteLink/VpnSiteLinkConnection operations. * Sdk changes for vpn site link. * Fixing error. * Fixing more comments. * Fixing json error. * Fixing json files. * Fixing comments. * Fixing more issues. * Fixing more errors. * Fixing more error. * Prettify JSON in VpnConnectionGet.json * Resolving more comments. * Fixing typo. * Adding type in examples of put. * Removing Child resource type. * chore: jsonfmt network-may * Fix incorrect examples
leni-msft
pushed a commit
to leni-msft/azure-rest-api-specs
that referenced
this pull request
May 13, 2022
* Adding prop limitCPUMigration for VM templates * prittier fix Co-authored-by: Siddhant Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.