Skip to content

Commit

Permalink
PrivateEndpoint & PrivateLinkService APIs update (#6332)
Browse files Browse the repository at this point in the history
* Add two properties on Subnet for privateIp. Add two new APIs to support privateIp.

Minor modify on readme.md file.

* Fix some issue found by Model Validation.

* Merge all apis relative to private end point / private link service to its json file.

* Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property.

* Change AutoApprovedPrivateLinkService structure to fit with NRP side.

* Delete suppress for merged APIs in readme.md.

* 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect.
2. Change opertaion id for opertaions that relative to private endpoint and private link service.

* Minor fix for model validation.

* Revert opertion id changes for AvailablePrivateEndpointType to previous name.

* 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string.
2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter.
  • Loading branch information
bowen0106 authored and tjprescott committed Jul 3, 2019
1 parent 1874de9 commit bf45d1d
Show file tree
Hide file tree
Showing 31 changed files with 940 additions and 339 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"parameters": {
"api-version": "2019-04-01",
"location": "regionName",
"subscriptionId": "subId"
},
"responses": {
"200": {
"body": {
"value": [
{
"privateLinkService" : "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPls1"
},
{
"privateLinkService" : "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPls2"
},
{
"privateLinkService" : "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPls3"
}
]
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"parameters": {
"api-version": "2019-04-01",
"location": "regionName",
"subscriptionId": "subId",
"resourceGroupName": "rg1"
},
"responses": {
"200": {
"body": {
"value": [
{
"privateLinkService" : "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPls1"
},
{
"privateLinkService" : "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPls2"
},
{
"privateLinkService" : "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateLinkServices/testPls3"
}
]
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
{
"id": "/subscriptions/subId/providers/Microsoft.Network/availablePrivateEndpointTypes/Microsoft.Provider.resourceType",
"type": "Microsoft.Network/availablePrivateEndpointTypes",
"serviceName": "Microsoft.Provider/resourceType"
"resourceName": "Microsoft.Provider/resourceType"
}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
{
"id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/availablePrivateEndpointTypes/Microsoft.Provider.resourceType",
"type": "Microsoft.Network/availablePrivateEndpointTypes",
"serviceName": "Microsoft.Provider/resourceType"
"resourceName": "Microsoft.Provider/resourceType"
}
]
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"parameters": {
"api-version": "2019-04-01",
"subscriptionId": "subid",
"location": "westus",
"parameters": {
"privateLinkServiceAlias": "mypls.00000000-0000-0000-0000-000000000000.azure.privatelinkservice"
}
},
"responses": {
"200": {
"body": {
"visible": true
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"parameters": {
"api-version": "2019-04-01",
"subscriptionId": "subid",
"location": "westus",
"resourceGroupName": "rg1",
"parameters": {
"privateLinkServiceAlias": "mypls.00000000-0000-0000-0000-000000000000.azure.privatelinkservice"
}
},
"responses": {
"200": {
"body": {
"visible": true
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"parameters": {
"location": "eastus2euap",
"properties": {
"provisioningState": "Succeeded",
"visibility": {
"subscriptions": [
"subscription1",
Expand All @@ -26,7 +25,7 @@
"fqdn2",
"fqdn3"
],
"loadBalancerFrontendIPConfigurations": [
"loadBalancerFrontendIpConfigurations": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/fe-lb"
}
Expand Down Expand Up @@ -74,7 +73,7 @@
"fqdn3"
],
"alias": "ContosoService.{guid}.azure.privatelinkservice",
"loadBalancerFrontendIPConfigurations": [
"loadBalancerFrontendIpConfigurations": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/fe-lb"
}
Expand Down Expand Up @@ -126,7 +125,7 @@
"fqdn3"
],
"alias": "ContosoService.{guid}.azure.privatelinkservice",
"loadBalancerFrontendIPConfigurations": [
"loadBalancerFrontendIpConfigurations": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/fe-lb"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"fqdn3"
],
"alias": "ContosoService.{guid}.azure.privatelinkservice",
"loadBalancerFrontendIPConfigurations": [
"loadBalancerFrontendIpConfigurations": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/fe-lb"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"fqdn2"
],
"alias": "ContosoService.{guid}.azure.privatelinkservice",
"loadBalancerFrontendIPConfigurations": [
"loadBalancerFrontendIpConfigurations": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/fe-lb1"
}
Expand Down Expand Up @@ -95,7 +95,7 @@
"fqdn3"
],
"alias": "ContosoService.{guid}.azure.privatelinkservice",
"loadBalancerFrontendIPConfigurations": [
"loadBalancerFrontendIpConfigurations": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/fe-lb2"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"fqdn3"
],
"alias": "ContosoService.{guid}.azure.privatelinkservice",
"loadBalancerFrontendIPConfigurations": [
"loadBalancerFrontendIpConfigurations": [
{
"id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/fe-lb1"
}
Expand Down Expand Up @@ -96,7 +96,7 @@
"fqdn2"
],
"alias": "ContosoService.{guid}.azure.privatelinkservice",
"loadBalancerFrontendIPConfigurations": [
"loadBalancerFrontendIpConfigurations": [
{
"id": "/subscriptions/subid/resourceGroups/rg2/providers/Microsoft.Network/loadBalancers/lb/frontendIPConfigurations/fe-lb2"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,19 @@
}
},
"responses": {
"200": {}
"200": {
"body": {
"name": "testPlePeConnection",
"properties": {
"privateEndpoint": {
"id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/privateEndpoints/testPe"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "approved it for some reason."
}
}
}
}
}
}
Loading

0 comments on commit bf45d1d

Please sign in to comment.