More examples fix after live testing #6382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-rubyUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-pythonUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-javaUnable to detect any generation context from this PR. |
Automation for azure-sdk-for-goUnable to detect any generation context from this PR. |
|
Can one of the admins verify this patch? |
sergey-shandar
approved these changes
Jun 19, 2019
sergey-shandar
pushed a commit
that referenced
this pull request
Jul 16, 2019
* Adds base for updating Microsoft.Network from version stable/2019-04-01 to version 2019-06-01 * Updates readme * Updates API version in new specs and examples * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… (#6164) * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration properties. * Fixed LB examples * Fix examples in 2019-06-01 * Remove API version number in privateIPAddressVersion description. * Add privateIPAddressVersion in LoadBalancer examples. * Add privateIPAddressVersion in 2019-06-01 API version. * Update specs to avoid readOnly in the request body (#6228) * typo: netowork May double word the (#6206) * Update cipher suites (#6213) * removing resource group name from PrepareNetworkPoliciesRequest (#6232) * Add exception for property "Conditon" in Network's webapplicationfirewall.json (#6335) * Extend long-running ops fixes to new API version; Suppression (#6336) * Update long-running for new API version * Add suppression for new API * Updated examples to have valid bodies for live put (#6349) * More examples fix after live testing (#6382) * Improved more examples after live testing * Fix validations * Improve descriptions in Network to align with Swagger guidelines (#6350) * Improve descriptions in Network to align with Swagger guidelines * Fix for CI * More examples improvements (#6444) * Add PATCH to Azure Firewall supported operations (#6486) * Add PATCH to Azure Firewall supported operations * Name the parameter how validation expects it * Patch is not a long running operation, so update the specs accordingly * PrivateEndpoint & PrivateLinkService APIs update (#6332) * Add two properties on Subnet for privateIp. Add two new APIs to support privateIp. Minor modify on readme.md file. * Fix some issue found by Model Validation. * Merge all apis relative to private end point / private link service to its json file. * Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property. * Change AutoApprovedPrivateLinkService structure to fit with NRP side. * Delete suppress for merged APIs in readme.md. * 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect. 2. Change opertaion id for opertaions that relative to private endpoint and private link service. * Minor fix for model validation. * Revert opertion id changes for AvailablePrivateEndpointType to previous name. * 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string. 2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter. * Improve Network's examples (#6493) * Removed read-only props from VPNGW example * Fixed LoadBalancer examples: * "outboundRules" array isn't returned for "Basic" SKU load balancer * added example for external LB with outboundRules * added missing read-only properties * Replace "regionName" in examples with real location * Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer * chore: jsonfmt network (#6592) * Adding VpnSiteLink and VpnSiteLinkConnection properties. (#6528) * Added VpnSiteLink/VpnSiteLinkConnection operations. * Sdk changes for vpn site link. * Fixing error. * Fixing more comments. * Fixing json error. * Fixing json files. * Fixing comments. * Fixing more issues. * Fixing more errors. * Fixing more error. * Prettify JSON in VpnConnectionGet.json * Resolving more comments. * Fixing typo. * Adding type in examples of put. * Removing Child resource type. * chore: jsonfmt network-may * Fix incorrect examples
celikcigdem
pushed a commit
to celikcigdem/azure-rest-api-specs
that referenced
this pull request
Jul 17, 2019
* Adds base for updating Microsoft.Network from version stable/2019-04-01 to version 2019-06-01 * Updates readme * Updates API version in new specs and examples * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration pr… (Azure#6164) * Add PrivateIPAddressVersion in LoadBalancerFrontendIpConfiguration properties. * Fixed LB examples * Fix examples in 2019-06-01 * Remove API version number in privateIPAddressVersion description. * Add privateIPAddressVersion in LoadBalancer examples. * Add privateIPAddressVersion in 2019-06-01 API version. * Update specs to avoid readOnly in the request body (Azure#6228) * typo: netowork May double word the (Azure#6206) * Update cipher suites (Azure#6213) * removing resource group name from PrepareNetworkPoliciesRequest (Azure#6232) * Add exception for property "Conditon" in Network's webapplicationfirewall.json (Azure#6335) * Extend long-running ops fixes to new API version; Suppression (Azure#6336) * Update long-running for new API version * Add suppression for new API * Updated examples to have valid bodies for live put (Azure#6349) * More examples fix after live testing (Azure#6382) * Improved more examples after live testing * Fix validations * Improve descriptions in Network to align with Swagger guidelines (Azure#6350) * Improve descriptions in Network to align with Swagger guidelines * Fix for CI * More examples improvements (Azure#6444) * Add PATCH to Azure Firewall supported operations (Azure#6486) * Add PATCH to Azure Firewall supported operations * Name the parameter how validation expects it * Patch is not a long running operation, so update the specs accordingly * PrivateEndpoint & PrivateLinkService APIs update (Azure#6332) * Add two properties on Subnet for privateIp. Add two new APIs to support privateIp. Minor modify on readme.md file. * Fix some issue found by Model Validation. * Merge all apis relative to private end point / private link service to its json file. * Fix a typo name from design spec that casue GetAvailablePrivateEndpointType get null property. * Change AutoApprovedPrivateLinkService structure to fit with NRP side. * Delete suppress for merged APIs in readme.md. * 1. Change value to PrivateEndpointConnection when calling put PrivateEndpointConnect. 2. Change opertaion id for opertaions that relative to private endpoint and private link service. * Minor fix for model validation. * Revert opertion id changes for AvailablePrivateEndpointType to previous name. * 1. Change CheckPrivateLinkServiceVisibility API, the input now has a body content that contains a private link service alias string. 2. Change both CheckPrivateLinkServiceVisibility/AutoApprovedPrivateLinkServices API to support for with/without ResourceGroup parameter. * Improve Network's examples (Azure#6493) * Removed read-only props from VPNGW example * Fixed LoadBalancer examples: * "outboundRules" array isn't returned for "Basic" SKU load balancer * added example for external LB with outboundRules * added missing read-only properties * Replace "regionName" in examples with real location * Fixed incorrect descriptions in LoadBalancer: child resource doesn't have to have a unique name within resource group, but within a set of similar resource on parent load balancer * chore: jsonfmt network (Azure#6592) * Adding VpnSiteLink and VpnSiteLinkConnection properties. (Azure#6528) * Added VpnSiteLink/VpnSiteLinkConnection operations. * Sdk changes for vpn site link. * Fixing error. * Fixing more comments. * Fixing json error. * Fixing json files. * Fixing comments. * Fixing more issues. * Fixing more errors. * Fixing more error. * Prettify JSON in VpnConnectionGet.json * Resolving more comments. * Fixing typo. * Adding type in examples of put. * Removing Child resource type. * chore: jsonfmt network-may * Fix incorrect examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.