Add PATCH to Azure Firewall supported operations

[fanymanea]

We are adding PATCH to the list of supported operations for Azure Firewall.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and have all been fixed in this PR.
• The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

• Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
• adding/removing APIs.
• adding/removing properties.
• adding/removing API-version.
• adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

• If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
  Please follow the link to find more details on API review process.

[AutorestCI]

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmp8ny3us_w/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmp8ny3us_w/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4385)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-04"} .

<--- Last few GCs --->

[27278:0x36e2cc0]    89125 ms: Mark-sweep 1381.2 (1425.3) -> 1380.8 (1425.8) MB, 3050.2 / 0.0 ms  (average mu = 0.087, current mu = 0.001) allocation failure scavenge might not succeed
[27278:0x36e2cc0]    90934 ms: Mark-sweep 1381.7 (1425.8) -> 1381.3 (1426.3) MB, 1805.9 / 0.0 ms  (average mu = 0.053, current mu = 0.002) allocation failure scavenge might not succeed


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x2abcee99e6e9 <JSObject>
    0: builtin exit frame: concat(this=0x3939f6640e29 <JSArray[4]>,0x3939f6649559 <JSArray[1]>,0x3939f6640e29 <JSArray[4]>)

    1: Descendants [0x31ea1fc33329] [/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~29] [pc=0x535c3d56055](this=0x31ea1fc3d829 <Object map = 0x1b5315c79051>,/* anonymous */=0x0e443e702801 <the_hole>...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea03c8 v8::internal::Factory::AllocateRawWithAllocationSite(v8::internal::Handle<v8::internal::Map>, v8::internal::PretenureFlag, v8::internal::Handle<v8::internal::AllocationSite>) [node]
11: 0xead4c5 v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, v8::internal::PretenureFlag) [node]
12: 0xead9b4 v8::internal::Factory::NewJSArray(v8::internal::ElementsKind, int, int, v8::internal::ArrayStorageAllocationMode, v8::internal::PretenureFlag) [node]
13: 0xe66e01 v8::internal::ElementsAccessor::Concat(v8::internal::Isolate*, v8::internal::Arguments*, unsigned int, unsigned int) [node]
14: 0xb63d99  [node]
15: 0xb6d498 v8::internal::Builtin_ArrayConcat(int, v8::internal::Object**, v8::internal::Isolate*) [node]
16: 0x535c37dbf7d

[azuresdkci]

Can one of the admins verify this patch?

[AutorestCI]

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmpv6c_go_z/rest/specification/network/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmpv6c_go_z/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '[email protected]/autorest.go@~2.1.133', '--use-onever', '--verbose']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4302)
   Including configuration file 'file:///tmp/tmpv6c_go_z/rest/specification/network/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.133->2.1.133)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2019-02"} .
   Including configuration file 'file:///tmp/tmpv6c_go_z/rest/specification/network/resource-manager/readme.go.md'

<--- Last few GCs --->

[22827:0x3c518c0]   145950 ms: Mark-sweep 1387.6 (1468.9) -> 1387.3 (1474.4) MB, 1710.6 / 0.0 ms  allocation failure GC in old space requested
[22827:0x3c518c0]   147705 ms: Mark-sweep 1387.3 (1474.4) -> 1387.3 (1435.9) MB, 1754.6 / 0.0 ms  last resort GC in old space requested
[22827:0x3c518c0]   149401 ms: Mark-sweep 1387.3 (1435.9) -> 1387.3 (1430.9) MB, 1694.3 / 0.0 ms  last resort GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x86aa0825879 <JSObject>
    1: set [native weak-collection.js:~27] [pc=0x3069aef195e9](this=0x244791939109 <JSWeakMap>,key=0x18b0342134c1 <Object map = 0x19fdc533aa69>,value=0x1e010b33d911 <String[6]: String>)
    2: /* anonymous */(aka /* anonymous */) [/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist/lib/ref/yaml.js:~101] [pc=0x3069aeb6cb99](this=0x246e2c5822d1 <...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0x8cbf4c [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFixedArray(int, v8::internal::PretenureFlag) [node]
 6: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::NewInternal(v8::internal::Isolate*, int, v8::internal::PretenureFlag) [node]
 7: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::New(v8::internal::Isolate*, int, v8::internal::PretenureFlag, v8::internal::MinimumCapacity) [node]
 8: v8::internal::HashTable<v8::internal::ObjectHashTable, v8::internal::ObjectHashTableShape>::EnsureCapacity(v8::internal::Handle<v8::internal::ObjectHashTable>, int, v8::internal::PretenureFlag) [node]
 9: v8::internal::ObjectHashTable::Put(v8::internal::Handle<v8::internal::ObjectHashTable>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
10: v8::internal::JSWeakCollection::Set(v8::internal::Handle<v8::internal::JSWeakCollection>, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int) [node]
11: v8::internal::Runtime_WeakCollectionSet(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x3069aea042fd

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[AutorestCI]

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

[anton-evseev]

Please ignore error in NetworkValidation, it's not related to this PR, it failed due to NuGet not being able to resolve dependencies. I've already reported this error to SDK & Azure PowerShell teams.

D:\a\1\s\Out\azure-powershell\src\Network\Network\Network.csproj : error NU1605: Detected package downgrade: Microsoft.Rest.ClientRuntime from 2.3.20 to 2.3.19. Reference the package directly from the project to select a different version.  [D:\a\1\s\Out\azure-powershell\src\Network\Network.sln]

[fanymanea]

SDK & Azure PowerShell team

Then can you please help me complete this PR?

[ravbhatnagar]

Signing off from ARM side.