Release network microsoft.network official 2023 02 01 #24277
Conversation
…01 to version 2023-02-01
#23978) * add adminstate * update description * add headers to 202 * prettier fix
|
Hi, @htippanaboya Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
ghost
added
the
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| applicationGateway.json | 2023-02-01(a502078) | 2022-11-01(main) |
| applicationGatewayWafDynamicManifests.json | 2023-02-01(a502078) | 2022-11-01(main) |
| applicationSecurityGroup.json | 2023-02-01(a502078) | 2022-11-01(main) |
| availableDelegations.json | 2023-02-01(a502078) | 2022-11-01(main) |
| availableServiceAliases.json | 2023-02-01(a502078) | 2022-11-01(main) |
| azureFirewall.json | 2023-02-01(a502078) | 2022-11-01(main) |
| azureFirewallFqdnTag.json | 2023-02-01(a502078) | 2022-11-01(main) |
| azureWebCategory.json | 2023-02-01(a502078) | 2022-11-01(main) |
| bastionHost.json | 2023-02-01(a502078) | 2022-11-01(main) |
| checkDnsAvailability.json | 2023-02-01(a502078) | 2022-11-01(main) |
| cloudServiceNetworkInterface.json | 2023-02-01(a502078) | 2022-11-01(main) |
| cloudServicePublicIpAddress.json | 2023-02-01(a502078) | 2022-11-01(main) |
| cloudServiceSwap.json | 2023-02-01(a502078) | 2022-11-01(main) |
| customIpPrefix.json | 2023-02-01(a502078) | 2022-11-01(main) |
| ddosCustomPolicy.json | 2023-02-01(a502078) | 2022-11-01(main) |
| ddosProtectionPlan.json | 2023-02-01(a502078) | 2022-11-01(main) |
| dscpConfiguration.json | 2023-02-01(a502078) | 2022-11-01(main) |
| endpointService.json | 2023-02-01(a502078) | 2022-11-01(main) |
| expressRouteCircuit.json | 2023-02-01(a502078) | 2022-11-01(main) |
| expressRouteCrossConnection.json | 2023-02-01(a502078) | 2022-11-01(main) |
| expressRoutePort.json | 2023-02-01(a502078) | 2022-11-01(main) |
| expressRouteProviderPort.json | 2023-02-01(a502078) | 2022-11-01(main) |
| firewallPolicy.json | 2023-02-01(a502078) | 2022-11-01(main) |
| ipAllocation.json | 2023-02-01(a502078) | 2022-11-01(main) |
| ipGroups.json | 2023-02-01(a502078) | 2022-11-01(main) |
| loadBalancer.json | 2023-02-01(a502078) | 2022-11-01(main) |
| natGateway.json | 2023-02-01(a502078) | 2022-11-01(main) |
| network.json | 2023-02-01(a502078) | 2022-11-01(main) |
| network.json | 2023-02-01(a502078) | 2022-06-01-preview(main) |
| networkInterface.json | 2023-02-01(a502078) | 2022-11-01(main) |
| networkManager.json | 2023-02-01(a502078) | 2022-11-01(main) |
| networkManager.json | 2023-02-01(a502078) | 2022-04-01-preview(main) |
| networkManagerActiveConfiguration.json | 2023-02-01(a502078) | 2022-11-01(main) |
| networkManagerActiveConfiguration.json | 2023-02-01(a502078) | 2022-04-01-preview(main) |
| networkManagerConnection.json | 2023-02-01(a502078) | 2022-11-01(main) |
| networkManagerConnection.json | 2023-02-01(a502078) | 2022-04-01-preview(main) |
| networkManagerConnectivityConfiguration.json | 2023-02-01(a502078) | 2022-11-01(main) |
| networkManagerConnectivityConfiguration.json | 2023-02-01(a502078) | 2022-04-01-preview(main) |
| networkManagerEffectiveConfiguration.json | 2023-02-01(a502078) | 2022-11-01(main) |
| networkManagerEffectiveConfiguration.json | 2023-02-01(a502078) | 2022-04-01-preview(main) |
| networkManagerGroup.json | 2023-02-01(a502078) | 2022-11-01(main) |
| networkManagerGroup.json | 2023-02-01(a502078) | 2022-04-01-preview(main) |
| networkManagerScopeConnection.json | 2023-02-01(a502078) | 2022-11-01(main) |
| networkManagerScopeConnection.json | 2023-02-01(a502078) | 2022-04-01-preview(main) |
| networkManagerSecurityAdminConfiguration.json | 2023-02-01(a502078) | 2022-11-01(main) |
| networkManagerSecurityAdminConfiguration.json | 2023-02-01(a502078) | 2022-04-01-preview(main) |
| networkProfile.json | 2023-02-01(a502078) | 2022-11-01(main) |
| networkSecurityGroup.json | 2023-02-01(a502078) | 2022-11-01(main) |
| networkVirtualAppliance.json | 2023-02-01(a502078) | 2022-11-01(main) |
| networkWatcher.json | 2023-02-01(a502078) | 2022-11-01(main) |
| operation.json | 2023-02-01(a502078) | 2022-11-01(main) |
| privateEndpoint.json | 2023-02-01(a502078) | 2022-11-01(main) |
| privateLinkService.json | 2023-02-01(a502078) | 2022-11-01(main) |
| publicIpAddress.json | 2023-02-01(a502078) | 2022-11-01(main) |
| publicIpPrefix.json | 2023-02-01(a502078) | 2022-11-01(main) |
| routeFilter.json | 2023-02-01(a502078) | 2022-11-01(main) |
| routeTable.json | 2023-02-01(a502078) | 2022-11-01(main) |
| securityPartnerProvider.json | 2023-02-01(a502078) | 2022-11-01(main) |
| serviceCommunity.json | 2023-02-01(a502078) | 2022-11-01(main) |
| serviceEndpointPolicy.json | 2023-02-01(a502078) | 2022-11-01(main) |
| serviceTags.json | 2023-02-01(a502078) | 2022-11-01(main) |
| usage.json | 2023-02-01(a502078) | 2022-11-01(main) |
| virtualNetwork.json | 2023-02-01(a502078) | 2022-11-01(main) |
| virtualNetworkGateway.json | 2023-02-01(a502078) | 2022-11-01(main) |
| virtualNetworkTap.json | 2023-02-01(a502078) | 2022-11-01(main) |
| virtualRouter.json | 2023-02-01(a502078) | 2022-11-01(main) |
| virtualWan.json | 2023-02-01(a502078) | 2022-11-01(main) |
| vmssNetworkInterface.json | 2023-02-01(a502078) | 2022-11-01(main) |
| vmssPublicIpAddress.json | 2023-02-01(a502078) | 2022-11-01(main) |
| webapplicationfirewall.json | 2023-02-01(a502078) | 2022-11-01(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The new version is removing enum value(s) 'HttpStatus499' from the old version. New: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L3752:9 Old: Microsoft.Network/stable/2022-11-01/applicationGateway.json#L3747:9 |
|
The new version is removing enum value(s) 'HttpStatus499' from the old version. New: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L3752:9 Old: Microsoft.Network/stable/2022-11-01/applicationGateway.json#L3747:9 |
The following breaking changes are detected by comparison with the latest preview version:
Only 14 items are listed, please refer to log for more details.
️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
️🔄LintDiff inProgress [Detail]
️❌Avocado: 2 Errors, 6 Warnings failed [Detail]
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 452 Errors, 0 Warnings failed [Detail]
Only 14 items are listed, please refer to log for more details.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
| Rule | Message |
|---|
️❌SDK Breaking Change Tracking failed [Detail]
Only 0 items are rendered, please refer to log for more details.
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
Only 0 items are rendered, please refer to log for more details.
️❌ azure-sdk-for-net-track2 failed [Detail]
Only 0 items are rendered, please refer to log for more details.
️🔄 azure-sdk-for-python-track2 inProgress [Detail]
️⚠️ azure-sdk-for-java warning [Detail]
Only 0 items are rendered, please refer to log for more details.
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
Only 0 items are rendered, please refer to log for more details.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
Only 0 items are rendered, please refer to log for more details.
️🔄 azure-resource-manager-schemas inProgress [Detail]
️❌ azure-powershell failed [Detail]
Only 0 items are rendered, please refer to log for more details.
Generated ApiView
|
|
@ArthurMa1978 - Can you please review the PR for any .NET Track2 breaking changes |
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
|
Hi @htippanaboya, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @htippanaboya, Your PR has some issues. Please fix the CI sequentially by following the order of
|
ms-zhenhua
added
the
ARMChangesRequested
|
For avocado validation and model validation errors approved in #23652 (comment) |
|
@konrad-jamrozik #24277 (comment) is this credscan running success, can it be ignored ? |
@htippanaboya can you fix or explain or let someone approved these Breaking Change(Cross-Version), Thanks |
|
Hi @htippanaboya |
|
@qiaozha can you review sdk breaking change for js and approve ? |
|
@tadelesh can you review sdk breaking change for go and approve ? |
Need breaking change board review first. |
|
@mikekistler take a look on this breaking change (cross-version) #24277 (comment) Is there something need fix ? |
|
Removing an enum value from a GA version is a breaking change. What is the justification for doing this? |
|
@mikekistler - The breaking changes was made in this PR #24095. It got the required Breaking change approvals on the PR. |
|
Breaking change previously reviewed and approved in #24095 |
mikekistler
added
the
Approved-BreakingChange
tadelesh
added
the
Approved-SdkBreakingChange-Go
|
@msyyc take a look on this pr. All validation has been approved. If ok, merge it. |
htippanaboya
restored the
release-network-Microsoft.Network-official-2023-02-01
branch
* Adds base for updating Microsoft.Network from version stable/2022-11-01 to version 2023-02-01 * Updates readme * Updates API version in new specs and examples * Fixed double header issue (Azure#23896) * Edited description for additional nics (Azure#24071) * swagger 20230201 adding resource guid (Azure#24154) * Appgw: Remove 499 status code from custom error page (Azure#24095) * Add AdminState Property to Virtual Network Gateway Resource Properties (Azure#23978) * add adminstate * update description * add headers to 202 * prettier fix * AppGW: Add default predefined ssl policy field in resource (Azure#24094) * Fix examples (Azure#24274) --------- Co-authored-by: Mikhail <[email protected]> Co-authored-by: JainRah <[email protected]> Co-authored-by: sssharma24 <[email protected]> Co-authored-by: Prateek Sachan <[email protected]> Co-authored-by: nimaller <[email protected]> Co-authored-by: Sindhu Aluguvelli <[email protected]>
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.