Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update log scrubbing examples #24274

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Update log scrubbing examples #24274

merged 1 commit into from
Jun 7, 2023

Conversation

sindhualuguvelli1
Copy link
Contributor

Data Plane API - Pull Request

Updating selector field in examples when the operator is "EqualsAny". When the operator is "EqualsAny" selector should not be specified.

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

@openapi-workflow-bot
Copy link

Hi, @sindhualuguvelli1 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 2, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 2, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net-track2 failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️🔄 azure-sdk-for-python-track2 inProgress [Detail]
    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 2, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/network/armnetwork https://apiview.dev/Assemblies/Review/dc623e29b61e4a11aed222356602bf56
    Java azure-resourcemanager-network-generated https://apiview.dev/Assemblies/Review/cf6fc26f37d84124ad9bd4028f717335
    JavaScript @azure/arm-network https://apiview.dev/Assemblies/Review/c8f6cb51b691412088ec449afa2a7036

    @ghost ghost added the Network label Jun 2, 2023
    @azure-sdk azure-sdk mentioned this pull request Jun 2, 2023
    Closed
    This was referenced Jun 2, 2023
    Closed
    Closed
    This was referenced Jun 2, 2023
    Closed
    Closed
    Closed
    @JackTn
    Copy link
    Member

    JackTn commented Jun 5, 2023

    @tadelesh help to approve sdk breaking change for go, thanks

    @JackTn
    Copy link
    Member

    JackTn commented Jun 5, 2023

    @qiaozha help to approve sdk breaking change for js, thanks

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jun 5, 2023
    @JackTn
    Copy link
    Member

    JackTn commented Jun 6, 2023 •
    edited
    Loading

    @msyyc take a look on this pr and help to merge it, thanks

    @JackTn JackTn added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 6, 2023
    @JackTn
    Copy link
    Member

    JackTn commented Jun 7, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @msyyc msyyc merged commit a502078 into Azure:release-network-Microsoft.Network-official-2023-02-01 Jun 7, 2023
    @JackTn JackTn mentioned this pull request Jun 7, 2023
    Closed
    msyyc pushed a commit that referenced this pull request Jun 13, 2023
    @htippanaboya @MikhailTryakhov
    @JainRah @sssharma24 @prateek2211 @nimaller @sindhualuguvelli1
    Release network microsoft.network official 2023 02 01 (#24277)
    7c20402 
    * Adds base for updating Microsoft.Network from version stable/2022-11-01 to version 2023-02-01

* Updates readme

* Updates API version in new specs and examples

* Fixed double header issue (#23896)

* Edited description for additional nics (#24071)

* swagger 20230201 adding resource guid (#24154)

* Appgw: Remove 499 status code from custom error page (#24095)

* Add AdminState Property to Virtual Network Gateway Resource Properties (#23978)

* add adminstate

* update description

* add headers to 202

* prettier fix

* AppGW: Add default predefined ssl policy field in resource (#24094)

* Fix examples (#24274)

---------

Co-authored-by: Mikhail <[email protected]>
Co-authored-by: JainRah <[email protected]>
Co-authored-by: sssharma24 <[email protected]>
Co-authored-by: Prateek Sachan <[email protected]>
Co-authored-by: nimaller <[email protected]>
Co-authored-by: Sindhu Aluguvelli <[email protected]>
    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    @htippanaboya @MikhailTryakhov
    @JainRah @sssharma24 @prateek2211 @nimaller @sindhualuguvelli1 @harryli0108
    Release network microsoft.network official 2023 02 01 (Azure#24277)
    a8f713c 
    * Adds base for updating Microsoft.Network from version stable/2022-11-01 to version 2023-02-01

* Updates readme

* Updates API version in new specs and examples

* Fixed double header issue (Azure#23896)

* Edited description for additional nics (Azure#24071)

* swagger 20230201 adding resource guid (Azure#24154)

* Appgw: Remove 499 status code from custom error page (Azure#24095)

* Add AdminState Property to Virtual Network Gateway Resource Properties (Azure#23978)

* add adminstate

* update description

* add headers to 202

* prettier fix

* AppGW: Add default predefined ssl policy field in resource (Azure#24094)

* Fix examples (Azure#24274)

---------

Co-authored-by: Mikhail <[email protected]>
Co-authored-by: JainRah <[email protected]>
Co-authored-by: sssharma24 <[email protected]>
Co-authored-by: Prateek Sachan <[email protected]>
Co-authored-by: nimaller <[email protected]>
Co-authored-by: Sindhu Aluguvelli <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @rravishankar2 rravishankar2 rravishankar2 left review comments

    @msyyc msyyc msyyc approved these changes

    @MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

    Assignees

    @JackTn JackTn

    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript CI-BreakingChange-Go CI-BreakingChange-JavaScript Network resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @sindhualuguvelli1 @JackTn @msyyc @rravishankar2 @tadelesh @AzureRestAPISpecReview @qiaozha