swagger 20230201 adding resource guid #24154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @sssharma24 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
This was referenced May 24, 2023
|
approved for python since breaking is not caused by this PR |
ankhyk
approved these changes
May 31, 2023
ankhyk
added
the
Approved-OkToMerge
lirenhe
merged commit 3bea9ad
into
Azure:release-network-Microsoft.Network-official-2023-02-01
msyyc
pushed a commit
that referenced
this pull request
Jun 13, 2023
* Adds base for updating Microsoft.Network from version stable/2022-11-01 to version 2023-02-01 * Updates readme * Updates API version in new specs and examples * Fixed double header issue (#23896) * Edited description for additional nics (#24071) * swagger 20230201 adding resource guid (#24154) * Appgw: Remove 499 status code from custom error page (#24095) * Add AdminState Property to Virtual Network Gateway Resource Properties (#23978) * add adminstate * update description * add headers to 202 * prettier fix * AppGW: Add default predefined ssl policy field in resource (#24094) * Fix examples (#24274) --------- Co-authored-by: Mikhail <[email protected]> Co-authored-by: JainRah <[email protected]> Co-authored-by: sssharma24 <[email protected]> Co-authored-by: Prateek Sachan <[email protected]> Co-authored-by: nimaller <[email protected]> Co-authored-by: Sindhu Aluguvelli <[email protected]>
harryli0108
pushed a commit
to harryli0108/azure-rest-api-specs
that referenced
this pull request
Jul 28, 2023
* Adds base for updating Microsoft.Network from version stable/2022-11-01 to version 2023-02-01 * Updates readme * Updates API version in new specs and examples * Fixed double header issue (Azure#23896) * Edited description for additional nics (Azure#24071) * swagger 20230201 adding resource guid (Azure#24154) * Appgw: Remove 499 status code from custom error page (Azure#24095) * Add AdminState Property to Virtual Network Gateway Resource Properties (Azure#23978) * add adminstate * update description * add headers to 202 * prettier fix * AppGW: Add default predefined ssl policy field in resource (Azure#24094) * Fix examples (Azure#24274) --------- Co-authored-by: Mikhail <[email protected]> Co-authored-by: JainRah <[email protected]> Co-authored-by: sssharma24 <[email protected]> Co-authored-by: Prateek Sachan <[email protected]> Co-authored-by: nimaller <[email protected]> Co-authored-by: Sindhu Aluguvelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.