Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double Header Fix #24752

Closed
wants to merge 2 commits into from
Closed

Double Header Fix #24752

wants to merge 2 commits into from

Conversation

JainRah
Copy link
Contributor

@JainRah JainRah commented Jul 11, 2023 •
edited by openapi-workflow-bot bot
Loading

ARM (Control Plane) API Specification Update Pull Request

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

ARM API changes review

  • If you want for the ARM team to review this PR, you must add the ARMReview label.
  • The automation may automatically add the ARMReview label, if appropriate.
    If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review

If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.

Getting help

@JainRah JainRah requested a review from MikhailTryakhov as a code owner July 11, 2023 04:35
@openapi-workflow-bot
Copy link

Hi, @JainRah! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

    • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 11, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️❌PrettierCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ HowToFix Code style issues found
    path: stable/2023-02-01/examples/NetworkVirtualAppliancePut.json
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 11, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net-track2 failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 11, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/network/armnetwork https://apiview.dev/Assemblies/Review/31f690bdf0b0456d8cfb79aad39c2388
    Java azure-resourcemanager-network-generated https://apiview.dev/Assemblies/Review/0c7953ff878e43a2ab7ede629f9a30ad
    JavaScript @azure/arm-network https://apiview.dev/Assemblies/Review/046c699e39af46a5879e17be9bdffc5f

    @ghost ghost added the Network label Jul 11, 2023
    @JainRah JainRah changed the title Release network microsoft.network official 2023 02 01 Double Header Fix Jul 11, 2023
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 11, 2023
    This was referenced Jul 11, 2023
    Closed
    Closed
    Closed
    This was referenced Jul 11, 2023
    Closed
    Closed
    Closed
    @raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 11, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 11, 2023
    @kazrael2119
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    No commit pushedDate could be found for PR 24752 in repo Azure/azure-rest-api-specs

    @qiaozha
    Copy link
    Member

    qiaozha commented Jul 12, 2023

    /azp run

    @azure-pipelines
    Copy link

    No commit pushedDate could be found for PR 24752 in repo Azure/azure-rest-api-specs

    @kazrael2119
    Copy link
    Contributor

    @JainRah ，your target branch has been merged to main: #24277, I think you should add your changes in below branch,thanks
    image

    cc @MikhailTryakhov

    @JainRah JainRah closed this Jul 12, 2023
    @JainRah
    Copy link
    Contributor Author

    JainRah commented Jul 12, 2023

    Raised PR for requested branch

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

    Assignees

    @rkmanda rkmanda

    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-JavaScript Network resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @JainRah @kazrael2119 @qiaozha @raosuhas @rkmanda @AzureRestAPISpecReview