-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg 7.2.0: Update E2E tests #38507
Conversation
Seems that tests are currently failing due to WordPress/gutenberg#19050 Some classes have changed so we need to update the selectors. |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~140567 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~46051 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
30c22e1
to
af4d4cf
Compare
Uhm, not sure why the new step is currently failing with When running Calypso locally, that selector is valid, so I wonder if the test is running against a stale image. |
@mmtr I tried That's why I added Differences from CircleCI:
|
Awesome, thanks for clarifying @Stojdza! |
e140ac9
to
aac383a
Compare
Can we keep the new revisions test in a separate PR, and have this PR remain only what's needed to get the plugin updates to pass? |
@@ -52,6 +48,14 @@ export default class GutenbergEditorComponent extends AsyncBaseContainer { | |||
await this.driver.sleep( 2000 ); | |||
} | |||
|
|||
async initEditor( { dismissPageTemplateSelector = false } = {} ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it <3
Thanks for the suggestion @kwight. Small PRs for the win! Moved all new steps and tests that are unrelated to the Gutenberg update to separate PRs:
|
21af37d
to
f3d0d4e
Compare
7cfe257
to
57f2e4b
Compare
Will investigate later
We needed to remove the basic publish post test from the IE11 canary test suite since it was failing and we didn't want to block the Gutenberg update. We'll investigate later what was causing the failure. |
In #38767 we added the Gutenberg basic publish posts to the IE11 canary test suite in order to prevent more IE11 regressions from happening. However, we had to remove it in #38507 after activating Gutenberg 7.2.0 since the test was failing for some reason. This PR adds that test back and properly fixes the test by adding some missing awaits (props @Stojdza)
Changes proposed in this Pull Request
Updates some CSS selectors and texts in order to match the new classes and sentence case changes introduced in Gutenberg 7.2.0.