E2E: Add Gutenberg basic publish post to IE11 canary test suite #38808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmtr
added
[Status] In Progress
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
@Automattic/e2e-test-reviewers any idea why the test fails on IE11? Seems that the posts list is not loading after clicking on "Posts" on the sidebar, but I cannot reproduce that manually on IE11 (tested on BrowserStack). |
|
@mmtr I wasn't sure why the test was failing since video recordings are completely black, and even in some runs screenshots were the same. It was basically shooting in the dark 😄 I created PR to try a couple of things and eventually I managed IE canaries to pass. With this change you should be good to go: 4c67b47 |
|
That's absolutely fantastic. Thanks a lot @Stojdza! |
mmtr
changed the title
gwwar
approved these changes
Jan 14, 2020
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
In #38767 we added the Gutenberg basic publish posts to the IE11 canary test suite in order to prevent more IE11 regressions from happening.
However, we had to remove it in #38507 after activating Gutenberg 7.2.0 since the test was failing for some reason.
This PR adds that test back and properly fixes the test by adding some missing
awaits (props @Stojdza)