Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E: Check Jetpack blocks on Gutenberg #38767

Merged
merged 3 commits into from
Jan 13, 2020
Merged

E2E: Check Jetpack blocks on Gutenberg #38767

merged 3 commits into from
Jan 13, 2020

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Jan 10, 2020

Changes proposed in this Pull Request

  • Adds an extra step to the basic publish post e2e that verifies the Jetpack blocks are registered.
  • Includes the basic publish post e2e in the IE11 canary suite (we had a few IE11 regressions recently, so we aim to have more automated checks that prevent those regressions).

@mmtr mmtr added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2020
@mmtr mmtr requested a review from a team as a code owner January 10, 2020 15:38
@mmtr mmtr self-assigned this Jan 10, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/e2e-gutenberg-jetpack-blocks

@mmtr mmtr mentioned this pull request Jan 10, 2020
Merged
@mmtr mmtr requested a review from a team January 10, 2020 15:50
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

gwwar
gwwar approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmtr, I verified that the new steps here run well locally. Let's wait to see if other folks have feedback on the refactor before merging though

@mmtr mmtr requested a review from a team January 13, 2020 09:28
@mmtr mmtr force-pushed the update/e2e-gutenberg-jetpack-blocks branch from 52fbf2d to b0ef6f9 Compare January 13, 2020 10:48
@mmtr mmtr merged commit 910fe97 into master Jan 13, 2020
@mmtr mmtr deleted the update/e2e-gutenberg-jetpack-blocks branch January 13, 2020 11:46
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2020
@mmtr mmtr mentioned this pull request Jan 13, 2020
Merged
mmtr added a commit that referenced this pull request Jan 15, 2020
@mmtr
E2E: Add Gutenberg basic publish post to IE11 canary test suite (#38808)
a14c02a 
In #38767 we added the Gutenberg basic publish posts to the IE11 canary test suite in order to prevent more IE11 regressions from happening.

However, we had to remove it in #38507 after activating Gutenberg 7.2.0 since the test was failing for some reason.

This PR adds that test back and properly fixes the test by adding some missing awaits (props @Stojdza)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stojdza Stojdza Stojdza left review comments

@gwwar gwwar gwwar approved these changes

Assignees

@mmtr mmtr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmtr @matticbot @gwwar @Stojdza