Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Add E2E test to smoke test block invalidation error on default templates #38383

Closed
gwwar opened this issue Dec 12, 2019 · 6 comments · Fixed by #38765
Closed

Gutenberg: Add E2E test to smoke test block invalidation error on default templates #38383

gwwar opened this issue Dec 12, 2019 · 6 comments · Fixed by #38765
Assignees
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Type] Task

Comments

@gwwar
Copy link
Contributor

gwwar commented Dec 12, 2019

Let's add some tests around FSE page templates loading correctly after a new site is created.

I'd recommend one canary for the homepage, and other full suites on the remaining templates.

@gwwar gwwar added [Type] Task [Goal] Gutenberg Working towards full integration with Gutenberg labels Dec 12, 2019
@ianstewart
Copy link
Contributor

ianstewart commented Dec 12, 2019

While the following screen exists in signup …

image

We'll want e2e tests for at least the three different homepages. (Blog, Business, Professional.)

@gwwar
Copy link
Contributor Author

gwwar commented Dec 12, 2019

For folks who've never added E2E tests before see also PCYsg-o8X-p2

@gwwar gwwar assigned gwwar and unassigned gwwar Dec 12, 2019
@gwwar
Copy link
Contributor Author

gwwar commented Dec 13, 2019

We landed #38397 butI think a canary would still be worthwhile.

@mmtr
Copy link
Member

mmtr commented Dec 23, 2019

We have now a bunch of homepage layouts:

Screenshot 2019-12-23 at 14 14 00

Not sure which one we should pick for the e2e test, but maybe the current theme template could be a good candidate in order to have the e2e more maintainable and less prone to failures when changing the SPT flow.

@mmtr mmtr self-assigned this Dec 23, 2019
@mmtr
Copy link
Member

mmtr commented Dec 23, 2019

Actually, disregard my previous comment. After reading twice the issue summary, I realized that we want to check the default homepage created after creating a new site. There is no template selector on that flow, so I guess that the test could verify the homepage can be loaded in the block editor without any block validation error.

@mmtr
Copy link
Member

mmtr commented Dec 24, 2019

Added an extra step in #38507 to the basic sign up e2e canary test that verifies there are no errors when editing the homepage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants