Run tests against live branch for Edge user #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmtr
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
I don't know how to test this, but I verified changes here makes sense and we're executing the CircleCI build with the same args used on the full suite:
wp-e2e-tests-gh-bridge/index.js
Line 296 in 48af194
bsessions85
approved these changes
Jan 2, 2020
|
Merging this since you are out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will enable e2e tests to run against live branch for Gutenberg Edge user (discussed in #82 (review)).
I tested this change against dummy PR and jobs for Edge user have set
BRANCHNAMEwhich were missing before. More context what was the issue - Automattic/wp-calypso#38507 (comment)