Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the schedule notice in deposits list shows consistent info as Payments Overview summary #8026

Closed
Jinksi opened this issue Jan 16, 2024 · 6 comments · Fixed by #8263
Closed
Assignees
Labels
component: payouts Issues related to Payouts priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement.

Comments

@Jinksi
Copy link
Member

Jinksi commented Jan 16, 2024

Description

In #7883 we shipped a notice which was intended to be a quick and temporary solution to #7887.

Screenshot 2024-01-16 at 13 26 22

We should make further improvements to how we communicate the deposit schedule on the deposits list screen by displaying the same wording as the Payments Overview screen deposit schedule message.

@Jinksi Jinksi added type: enhancement The issue is a request for an enhancement. component: payouts Issues related to Payouts needs design The issue requires design input/work from a designer. labels Jan 16, 2024
@rogermattic
Copy link

Hey @Jinksi ! Thanks for creating this issue :)

It would be great if we could keep the logic of how this notice behaves, however, change the design so it's rendered inline in that table, with this copy. This is how it might look like:

It would be great if we could change the design and the copy of this notice to be rendered inline in the table with the same logic. Here's a mockup:

Deposits

The copy should read:

Your next deposit is scheduled for January 19, 2024. You can change your deposit schedule in Payments Settings.

Let me know what you think!

@haszari haszari removed the needs design The issue requires design input/work from a designer. label Jan 18, 2024
@Jinksi
Copy link
Member Author

Jinksi commented Jan 18, 2024

Looks great, thanks @rogermattic! I've updated the issue description with your new design.

@haszari
Copy link
Contributor

haszari commented Feb 8, 2024

Note this issue is dependent on what we decide for calculating the next payout date. See this issue for details:

That issue is blocked while we discuss the risks/benefits of calculating payout date. Adding blocked here, as we'll want this message to use consistent wording / details.

@haszari haszari added status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. labels Feb 8, 2024
@haszari haszari self-assigned this Feb 12, 2024
@haszari haszari added this to the Helix WooPayments 7.3 milestone Feb 12, 2024
@Jinksi
Copy link
Member Author

Jinksi commented Feb 15, 2024

This is now unblocked since we have an outcome on the wording of this for Payments → Overview in #8184 – we're not showing an estimated date.

@Jinksi Jinksi removed the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Feb 15, 2024
@haszari haszari assigned haszari and unassigned haszari Feb 18, 2024
@haszari
Copy link
Contributor

haszari commented Feb 20, 2024

Grabbing this since it would be good to get this done and shipped alongside #8184 in 7.3.

@haszari
Copy link
Contributor

haszari commented Feb 22, 2024

Splitting this into two issues, as we need to refactor to get this notice into the table.

#8260 will requires refactor of the table, and likely update of @woocommerce/components. Splitting off to separate issue to unblock making the existing notice consistent & not show estimated payout date.

@haszari haszari changed the title Improve how we communicate the deposit schedule on the deposit list screen Ensure the deposit schedule notice in deposits shows consistent info as Payments Overview summary Feb 22, 2024
@haszari haszari changed the title Ensure the deposit schedule notice in deposits shows consistent info as Payments Overview summary Ensure the schedule notice in deposits list shows consistent info as Payments Overview summary Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: payouts Issues related to Payouts priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement.
Projects
None yet
3 participants