Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WooPayments Server to determine next scheduled deposit date (vs. calculating manually) #8146

Closed
haszari opened this issue Feb 7, 2024 · 4 comments
Assignees
Labels
category: core WC Payments core related issues, where it’s obvious. component: payouts Issues related to Payouts priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. type: enhancement The issue is a request for an enhancement.

Comments

@haszari
Copy link
Contributor

haszari commented Feb 7, 2024

Description

In Payments > Overview, we show an approximate date for the next scheduled payout:

Screenshot 2024-02-07 at 2 32 43 PM

Currently this is calculated in the plugin, based on the deposit schedule.

Ideally we would delegate this logic to WooPayments Server, as the authority. And the parallel logic in plugin should be removed.

Additional context

We're looking at adding next expected deposit date to a deposits/overview-all API response:

@zmaglica
Copy link
Contributor

zmaglica commented Feb 8, 2024

This issue impacts Deposits, so assigning to Helix (based on team responsibilities Pc2DNy-3z-p2) @haszari .
Assigning as part of Gamma Triage process PcreKM-yM-p2.

@zmaglica zmaglica added type: enhancement The issue is a request for an enhancement. component: payouts Issues related to Payouts category: core WC Payments core related issues, where it’s obvious. labels Feb 8, 2024
@haszari haszari added the priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability label Feb 8, 2024
@haszari
Copy link
Contributor Author

haszari commented Feb 8, 2024

Note the server issue is blocked on internal discussions of risk/benefit, so marking this as blocked until that discussion resolves.

@haszari haszari added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Feb 8, 2024
@haszari haszari self-assigned this Feb 13, 2024
@haszari
Copy link
Contributor Author

haszari commented Feb 13, 2024

Closing – we've decided that we shouldn't estimate the next deposit date as we can't guarantee accuracy and it's not in our control. See follow up issue to remove the estimate from the UI and provide merchant with info / guidance on when they can expect funds in their account.

@haszari haszari closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2024
@haszari
Copy link
Contributor Author

haszari commented Feb 13, 2024

Setting estimate to 0 as this is closed / not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: core WC Payments core related issues, where it’s obvious. component: payouts Issues related to Payouts priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants