Show a deposit schedule notice on the deposits list page #7883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +276 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Jinksi
changed the title
Jinksi
changed the base branch from
develop
to
fix/7874-show-deposit-schedule-when-zero-available-balance
shendy-a8c
reviewed
Dec 12, 2023
| @@ -1,7 +1,7 @@ | |||
| /** | |||
| * Internal dependencies | |||
| */ | |||
| import { | |||
| import type { | |||
There was a problem hiding this comment.
I think I asked you this but forgot the reason.
Googled and found https://medium.com/@quizzesforyou/import-vs-import-type-in-typescript-8e5177b62bea
There was a problem hiding this comment.
This is my personal preference, I think it is more explicit === improved code readability.
shendy-a8c
requested changes
Dec 12, 2023
|
I've now made this notice dismissable by the user in 3ed5c04. It will no show up again unless the user changes their deposit schedule settings. See screen recording Screen.Recording.2023-12-13.at.11.21.29.mov |
Jinksi
force-pushed
the
fix/7874-show-deposit-schedule-when-zero-available-balance
branch
from
34215f7 to
9cec48f
Compare
Co-authored-by: Shendy <[email protected]>
Jinksi
force-pushed
the
fix/7874-show-deposit-schedule-when-zero-available-balance
branch
from
f6135dd to
ed4a651
Compare
…-zero-available-balance
Co-authored-by: Shendy <[email protected]>
when deposit schedule settings are changed, invalidate dismissal option
Co-authored-by: Timur Karimov <[email protected]>
Jinksi
force-pushed
the
add/7877-deposit-list-next-deposit-notice
branch
from
d4bb460 to
c52f63b
Compare
…nce' into add/7877-deposit-list-next-deposit-notice
brucealdridge
approved these changes
Dec 13, 2023
|
Rebased to |
|
@Jinksi it does look like the history is still muddled |
Yeh it looks like it includes commits from |
Base automatically changed from
fix/7874-show-deposit-schedule-when-zero-available-balance
to
release/6.9.2
December 13, 2023 05:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7877
Based on PR from #7875 since it relies on changes to the
DepositSchedulecomponent.Changes proposed in this Pull Request
Adds a notice to the Deposits List screen to communicate the deposit schedule for the account. The "next deposit" part of the message is not rendered here since this screen can include multiple currencies with differing next deposit dates.
This notice will only be rendered if deposits are unrestricted (not blocked or on a restricted schedule).
This notice is dismissable by the user. When this occurs, the dismissal state will persist until the user changes their deposit schedule settings.
Screen.Recording.2023-12-13.at.11.21.29.mov
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge