Add deposit schedule help tooltip to deposits list screen so it's consistent with Payments Overview #8263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2024 14:16
…consistently displayed
- short term fix - this hack & component will be replaced soon (InlineNotice, #8260)
6 tasks
haszari
changed the title
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +71 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
shendy-a8c
changed the title
shendy-a8c
approved these changes
Feb 25, 2024
There was a problem hiding this comment.
Changes look good and now I see help tooltip just like on Payments Overview page.
I have some feedbacks which I went ahead and made the change myself for faster iteration (I hope you don't mind).
- Need changelog. I already add one a38dcd0. Feel free to modify.
- There was a failed unit test which expects an empty element when deposit schedule is
manual. I fixed it with 15d8774.
The other day when I set my deposit schedule to manual via Stripe dashboard, I saw a lonely tooltip like this on Payments Overview page:
On deposits list page, it looked like this:
Now, it's fixed.
… only rendered when there is a valid schedule
Thanks @shendy-a8c ! I refactored this a little since we can null out higher-level components if there is no schedule:
Thanks also for fixing the changelog & unit test 🙌🏻 I'm going to merge soon/today (assuming no problems, I have tested with schedule & manual). If you have any feedback or see issues let me know, we can handle in a follow up issue. |
Jinksi
pushed a commit
that referenced
this pull request
Mar 28, 2024
…sistent with Payments Overview (#8263) Co-authored-by: Rua Haszard <[email protected]> Co-authored-by: Shendy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8026
Changes proposed in this Pull Request
This PR:
DepositSchedule.But why?
Testing instructions
Payments > Deposits.Payments > OverviewBonus points: check with a range of schedules, and store in new-account waiting period, deposits blocked etc.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge