Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTable & Calendly: Improve save functions by wrapping links in divs #14754

Merged
merged 3 commits into from
Feb 24, 2020
Merged

OpenTable & Calendly: Improve save functions by wrapping links in divs #14754

merged 3 commits into from
Feb 24, 2020

Conversation

scruffian
Copy link
Member

Changes proposed in this Pull Request:

  • When links aren't wrapped in block level elements they can create strange display issues:

Screenshot 2020-02-21 at 13 18 22

Let's wrap them in `
`s to work around this. I've also had to add deprecations for the old save functions.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Testing instructions:

  • Add a Calendly and OpenTable block to a page
  • Make the blocks unavailable (you can do this by commenting out the line that registers them)
  • Check that the links appear inside the theme content like this:
Screenshot 2020-02-21 at 13 16 55

Proposed changelog entry for your changes:

  • no changelog

@scruffian scruffian added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] OpenTable [Block] Calendly labels Feb 21, 2020
@scruffian scruffian requested a review from a team February 21, 2020 13:30
@scruffian scruffian self-assigned this Feb 21, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello scruffian! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D39198-code before merging this PR. Thank you!

@scruffian scruffian changed the title wrap links in divs OpenTable & Calendly: Improve save functions by wrap links in divs Feb 21, 2020
@scruffian scruffian changed the title OpenTable & Calendly: Improve save functions by wrap links in divs OpenTable & Calendly: Improve save functions by wrapping links in divs Feb 21, 2020
@jetpackbot
Copy link

jetpackbot commented Feb 21, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against 28d77cd

Copons
Copons previously approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@Copons Copons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! 🙇

@Copons
Copy link
Contributor

Copons commented Feb 21, 2020

Wait, actually, you say

I've also had to add deprecations for the old save functions.

But I don't see those deprecations in the PR diff... 🤔

@matticbot
Copy link
Contributor

scruffian, Your synced wpcom patch D39198-code has been updated.

@scruffian
Copy link
Member Author

You're right, I forgot to push them. They are there now...

@jeherve jeherve added this to the 8.3 milestone Feb 21, 2020
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 21, 2020
@matticbot
Copy link
Contributor

scruffian, Your synced wpcom patch D39198-code has been updated.

@scruffian scruffian added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 24, 2020
@scruffian
Copy link
Member Author

I wonder if we should do it like this: #14630

jeherve
jeherve approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me. 👍

@jeherve jeherve removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 24, 2020
@jeherve jeherve added the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 24, 2020
@jeherve jeherve merged commit 18d1f9c into master Feb 24, 2020
@jeherve jeherve deleted the update/save-for-calendly-and-opentable branch February 24, 2020 23:08
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 24, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: add #14754
ba3069a
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Revert "OpenTable & Calendly: Improve save functions by wrapping link…
aae885a 
…s… (#14754)"

This reverts commit 18d1f9c.
@jeherve jeherve mentioned this pull request Feb 25, 2020
Merged
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: 8.3 running changelog (#14642)
8797bea 
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
@jeherve
Copy link
Member

jeherve commented Feb 25, 2020

Noting that this was reverted in #14793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Copons Copons Copons approved these changes

@jeherve jeherve jeherve approved these changes

Assignees

@scruffian scruffian

Labels
[Block] Calendly [Block] OpenTable [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.
5 participants
@scruffian @matticbot @jetpackbot @Copons @jeherve