-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify distinction between Dashboard widgets #14574
Clarify distinction between Dashboard widgets #14574
Conversation
Fix Automattic#13952. Add headers to clarify that two different features are being shown in the Dashboard footer widget, for Jetpack.
This is an automated check which relies on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I left some comments below.
[not verified] (giving error about not escaping the blocked attempts / spam count)
Because Travis CI #43386.6 job timed out (??): develop.git.wordpress.org[0: 198.143.164.245]: errno=Connection timed out [not verified]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @coleshaw !
Does that last screenshot reflect the latest changes? If so, could we replace the first one on the original post, please?
This is looking good to me, but I'd like to see two changes before merging:
- Smaller font-size on the product name headings.
- Slightly larger margin-bottom on those same headings.
This should make the product names complementary to the valuable information below: the actual stats and descriptions. I've added a mock on #13952 (comment) :
Finally, should we be using the “Anti-spam” name instead of Akismet @jeherve ?
That's a good point, let's do that! We can take that opportunity to change "Protect" into "Brute force attack protection" as well, to stay consistent with the Jetpack Settings screen. |
Protect -> Brute force attack protection Akismet -> Anti-spam
@keoshi @jeherve , thanks for the feedback. I've updated the code and posted new screenshots in the original PR description. I also updated a couple instances of "Protect" and "Akismet" in the widget, not just in the heading -- do those other changes make sense? Or do you only want the headings to use "Brute force attack protection" and "Anti-spam", and I should leave the other text strings alone? |
I think your changes make sense! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks again, @coleshaw !
* 8.3 release: changelog * Changelog: add #14516 * Changelog: add #14574 * Bring in changes from 8.2.1 and 8.2.2 * Update stable version * Bring in 8.2.3 changes * Changelog: add #14714 * Changelog: add #14639 * Changelog: add #14678 * Changelog: add #14673 * Changelog: add #14687 * Changelog: add #14704 * Changelog: add #14702 * Changelog: add #14541 * Changelog: add #14657 * Changelog: add #14622 * Changelog: add #14582 * Changelog: add #14638 * Changelog: add #14633 * Changelog: add #14571 * Changelog: add #14592 * Changelog: add #14539 * Changelog: add #14514 * Changelog: add #14643 * Changelog: add #14494 * Changelog: add #13739 * Changelog: add #14707 * Changelog: add #14736 * Changelog: add #14706 * Changelog: add #14730 * Changelog: add #14685 * Changelog: add #14727 * Changelog: add #14711 * Changelog: add #14742 * Changelog: add #14746 * Changelog: add #14725 * Changelog: add #13999 * Changelog: add #14740 * Changelog: add #14759 * Changelog: add #14703 * Changelog: add #14753 * Changelog: add #14754 * Changelog: add #14645 * Cahngelog: add #14599
Fixes #13952
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
N/A
Testing instructions:
Proposed changelog entry for your changes: