Tiled gallery: rounded corners #14704
Conversation
simison
added
[Type] Enhancement
|
Caution: This PR has changes that must be merged to WordPress.com |
| @@ -33,6 +34,12 @@ $tiled-gallery-max-column-count: 20; | |||
| display: flex; | |||
| } | |||
| } | |||
|
|
|||
| @for $i from 1 through $tiled-gallery-max-rounded-corners { | |||
There was a problem hiding this comment.
This will generate 20 lines of CSS like this. Figured it's lightweight enough addition when limited to 20 or so.
Alternatively (maybe in another PR) we can have this in a separate CSS file which we enqueue only when they have rounded corners
Another alternative is to generate this in PHP for the exact number as inline CSS, allowing the setting to become unlimited instead of capped to 20.
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: March 3, 2020. |
| @@ -128,6 +128,10 @@ const blockAttributes = { | |||
| default: 'none', | |||
| type: 'string', | |||
| }, | |||
| roundedCorners: { | |||
There was a problem hiding this comment.
borderRadius could be another name and match CSS rule, but figured this is more self-explanatory.
| @@ -3,6 +3,7 @@ | |||
| */ | |||
| import { __, sprintf } from '@wordpress/i18n'; | |||
| import { Component } from '@wordpress/element'; | |||
| import classnames from 'classnames'; | |||
There was a problem hiding this comment.
Confirmed that this doesn't end up to built bundle meant for frontend _inc/blocks/tiled-gallery/view.js and make it needlessly bigger.
| @@ -12,6 +13,7 @@ import GalleryImageSave from '../gallery-image/save'; | |||
| import Mosaic from './mosaic'; | |||
| import Square from './square'; | |||
| import { isSquareishLayout, photonizedImgProps } from '../utils'; | |||
| import { LAYOUT_CIRCLE, MAX_ROUNDED_CORNERS } from '../constants'; | |||
There was a problem hiding this comment.
Confirmed that this doesn't pull in wp.i18n dependency on frontend bundle.
|
simison, Your synced wpcom patch D38974-code has been updated. |
jeherve
added
[Status] Ready to Merge
|
simison, Your synced wpcom patch D38974-code has been updated. |
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
|
Synced in r202963-wpcom |
* 8.3 release: changelog * Changelog: add #14516 * Changelog: add #14574 * Bring in changes from 8.2.1 and 8.2.2 * Update stable version * Bring in 8.2.3 changes * Changelog: add #14714 * Changelog: add #14639 * Changelog: add #14678 * Changelog: add #14673 * Changelog: add #14687 * Changelog: add #14704 * Changelog: add #14702 * Changelog: add #14541 * Changelog: add #14657 * Changelog: add #14622 * Changelog: add #14582 * Changelog: add #14638 * Changelog: add #14633 * Changelog: add #14571 * Changelog: add #14592 * Changelog: add #14539 * Changelog: add #14514 * Changelog: add #14643 * Changelog: add #14494 * Changelog: add #13739 * Changelog: add #14707 * Changelog: add #14736 * Changelog: add #14706 * Changelog: add #14730 * Changelog: add #14685 * Changelog: add #14727 * Changelog: add #14711 * Changelog: add #14742 * Changelog: add #14746 * Changelog: add #14725 * Changelog: add #13999 * Changelog: add #14740 * Changelog: add #14759 * Changelog: add #14703 * Changelog: add #14753 * Changelog: add #14754 * Changelog: add #14645 * Cahngelog: add #14599
Adds rounded corners feature to tiled gallery block.
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
Add tiled gallery block and some images to it
Confirm that you can make images nicely round with the sidebar setting.
Oh, except with Circle layout which obviously is already pretty darn round.
Store galleries without this change and try to open them with this change; confirm nothing breaks.
Test the roundness at the frontend of the site
Proposed changelog entry for your changes: