Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Block: Map Controls UI Fixes #14685

Merged
merged 3 commits into from
Feb 20, 2020
Merged

Map Block: Map Controls UI Fixes #14685

merged 3 commits into from
Feb 20, 2020

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Feb 14, 2020 •
edited
Loading

Fixes #11892

Changes proposed in this Pull Request:

  • Prevent theme styles adding a border radius to all buttons affecting the Map block controls too.
Before After
image Screenshot 2020-02-14 at 17 11 07
  • Add the fullscreen control as a block attribute.

Screenshot 2020-02-19 at 15 00 05

In the editor, the fullscreen button will always be disabled.

Testing instructions:

  • ⚠️ Before applying the PR add a Map block to a post in order to test if the block attributes are migrated correctly.
  • Test the PR with a theme that adds border radius to buttons (e.g. Twenty Nineteen).
  • Open the editor and make sure the pre-existing Map block show up without issues. Check in the code editor that has the new showFullscreenButton attribute.
  • Preview on the front end and make sure the horizontal separator in the zoom controls is straight (compare to before/after screens).
  • Enable and disable the "Show fullscreen button" setting, and check that it works as expected in both editor and front end, and that the fullscreen control is always disabled in the editor.

Proposed changelog entry for your changes:

  • Add a "show fullscreen button" setting to the Map block.

@Copons Copons added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Map labels Feb 14, 2020
@Copons Copons requested a review from a team February 14, 2020 17:10
@Copons Copons self-assigned this Feb 14, 2020
@jetpackbot
Copy link

jetpackbot commented Feb 14, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 3, 2020.
Scheduled code freeze: February 25, 2020

Generated by 🚫 dangerJS against 9612420

@Copons Copons force-pushed the update/map-block-zoom-controls branch from 488b289 to eee244e Compare February 19, 2020 14:59
@Copons Copons added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Feb 19, 2020
@Copons Copons requested a review from a team February 19, 2020 15:09
jeherve
jeherve requested changes Feb 19, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works quite nicely, that's a nice addition! I only have 2 minor nit-picky comments.

extensions/blocks/map/component.js Outdated Show resolved Hide resolved
extensions/blocks/map/edit.js Outdated Show resolved Hide resolved
@jeherve jeherve added this to the 8.3 milestone Feb 19, 2020
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 19, 2020
@Copons Copons force-pushed the update/map-block-zoom-controls branch from eee244e to 9612420 Compare February 20, 2020 15:39
@Copons Copons added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 20, 2020
jeherve
jeherve approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 20, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello Copons! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D39150-code before merging this PR. Thank you!

@Copons Copons merged commit d419e78 into master Feb 20, 2020
@Copons Copons deleted the update/map-block-zoom-controls branch February 20, 2020 17:30
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 20, 2020
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: add #14685
74bb1ee
jeherve added a commit that referenced this pull request Feb 25, 2020
@jeherve
Changelog: 8.3 running changelog (#14642)
8797bea 
* 8.3 release: changelog

* Changelog: add #14516

* Changelog: add #14574

* Bring in changes from 8.2.1 and 8.2.2

* Update stable version

* Bring in 8.2.3 changes

* Changelog: add #14714

* Changelog: add #14639

* Changelog: add #14678

* Changelog: add #14673

* Changelog: add #14687

* Changelog: add #14704

* Changelog: add #14702

* Changelog: add #14541

* Changelog: add #14657

* Changelog: add #14622

* Changelog: add #14582

* Changelog: add #14638

* Changelog: add #14633

* Changelog: add #14571

* Changelog: add #14592

* Changelog: add #14539

* Changelog: add #14514

* Changelog: add #14643

* Changelog: add #14494

* Changelog: add #13739

* Changelog: add #14707

* Changelog: add #14736

* Changelog: add #14706

* Changelog: add #14730

* Changelog: add #14685

* Changelog: add #14727

* Changelog: add #14711

* Changelog: add #14742

* Changelog: add #14746

* Changelog: add #14725

* Changelog: add #13999

* Changelog: add #14740

* Changelog: add #14759

* Changelog: add #14703

* Changelog: add #14753

* Changelog: add #14754

* Changelog: add #14645

* Cahngelog: add #14599
@Copons Copons restored the update/map-block-zoom-controls branch March 3, 2020 18:23
@Copons Copons mentioned this pull request Mar 3, 2020
Closed
@Copons Copons deleted the update/map-block-zoom-controls branch March 3, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@Copons Copons

Labels
[Block] Map [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.

Map block: maps without markers forget their position
4 participants
@Copons @jetpackbot @matticbot @jeherve